MIME-Version: 1.0
References: <OS0PR01MB57163087F86621D44D9A72BF94BB2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAD21AoD1_-ypJg7e0WEqDyCGBgOhH8ka3M1nPj1Dk=ADG44+GQ@mail.gmail.com>
 <OS0PR01MB57164FB1294A5CBE590097EE94842@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1+pWwcbhJMm-VBugavEvhMGTwx7eD4MZ5nhND1YOp17Cg@mail.gmail.com>
 <CAD21AoBw_DX3L5mBN3kryc0mZ1TzbT-GFhWPjLubKAHRtVh-bg@mail.gmail.com>
 <CAA4eK1+CmM-O17ryj7VaeS=d0gCKiAj6Np_3KQ8BAFoTS1s6Wg@mail.gmail.com>
 <CAD21AoBY7KoiJZW-dOoMoS0WwBtDfw_g+5rw1DoyqhoJc7nuWA@mail.gmail.com> <CAA4eK1Kp0qopesYYQ0OvH4+1UZ4XBVKiNkMGtgk80SCmcfkYhQ@mail.gmail.com>
In-Reply-To: <CAA4eK1Kp0qopesYYQ0OvH4+1UZ4XBVKiNkMGtgk80SCmcfkYhQ@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Sat, 26 Apr 2025 23:06:21 -0700
Message-ID: <CAD21AoA1sQN8OY7O_Z8hLeGxY-Bdafe8B4+0JD6W4C+EpMFhvg@mail.gmail.com>
Subject: Re: Fix premature xmin advancement during fast forward decoding
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, shveta malik <shveta.malik@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAD21AoA1sQN8OY7O_Z8hLeGxY-Bdafe8B4%2B0JD6W4C%2BEpMFhvg%40mail.gmail.com>
Precedence: bulk

On Sat, Apr 26, 2025 at 5:01=E2=80=AFAM Amit Kapila <amit.kapila16@gmail.co=
m> wrote:
>
> On Sat, Apr 26, 2025 at 12:01=E2=80=AFAM Masahiko Sawada <sawada.mshk@gma=
il.com> wrote:
> >
> > On Fri, Apr 25, 2025 at 4:42=E2=80=AFAM Amit Kapila <amit.kapila16@gmai=
l.com> wrote:
> > >
> > > Can you think of any better ideas?
> >
> > No idea. Hmm, there seems no reasonable way to fix this issue for back
> > branches. I consented to the view that these costs were something that
> > we should have paid from the beginning.
> >
>
> Right, I feel we should go with the simple change proposed by Hou-San
> for now to fix the bug. If, in the future, we encounter any cases
> where such optimizations can help for fast-forward mode, then we can
> consider it. Does that sound reasonable to you?

Yes, agreed with this approach.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com