MIME-Version: 1.0
References: <ZtpgHSGPrQNTZ-mX@momjian.us> <202409070955.wyuhquqflbxg@alvherre.pgsql>
 <Zt-zGmTub6eK_Z7W@momjian.us> <CAGECzQQfRVehQON65qNu-T_1O7VE+aFi0uPgvSEG4PHaijbUiw@mail.gmail.com>
In-Reply-To: <CAGECzQQfRVehQON65qNu-T_1O7VE+aFi0uPgvSEG4PHaijbUiw@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Tue, 10 Sep 2024 09:52:42 -0700
Message-ID: <CAD21AoAqQJWXX+0a9KZO+sXUdJ3Co1T+Jo_7Wh53Q5YB98rOYA@mail.gmail.com>
Subject: Re: First draft of PG 17 release notes
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Bruce Momjian <bruce@momjian.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAD21AoAqQJWXX%2B0a9KZO%2BsXUdJ3Co1T%2BJo_7Wh53Q5YB98rOYA%40mail.gmail.com>
Precedence: bulk

On Mon, Sep 9, 2024 at 11:29=E2=80=AFPM Jelte Fennema-Nio <postgres@jeltef.=
nl> wrote:
>
> On Tue, 10 Sept 2024 at 04:47, Bruce Momjian <bruce@momjian.us> wrote:
> > Yes.  There are so many changes at the source code level it is unwise t=
o
> > try and get them into the main release notes.  If someone wants to
> > create an addendum, like was suggested for pure performance
> > improvements, that would make sense.
>
> I agree that the release notes cannot fit every change. But I also
> don't think any extension author reads the complete git commit log
> every release, so taking the stance that they should be seems
> unhelpful. And the "Source Code" section does exist so at some level
> you seem to disagree with that too. So what is the way to decide that
> something makes the cut for the "Source Code" section?
>
> I think as an extension author there are usually three types of
> changes that are relevant:
> 1. New APIs/hooks that are meant for extension authors
> 2. Stuff that causes my existing code to not compile anymore
> 3. Stuff that changes behaviour of existing APIs code in a
> incompatible but silent way
>
> For 1, I think adding them to the release notes makes total sense,
> especially if the new APIs are documented not only in source code, but
> also on the website. Nathan his change is of this type, so I agree
> with him it should be in the release notes.

+1. I think that the increment JSON parser that is already mentioned
in the release note would fall in this type too; it's not a feature
aimed just for extension authors, but it's kind of source and internal
changes IMO. Since the DSM registry feature is described in the doc, I
think it would make sense to have it in the release notes and probably
has a link to the "Requesting Shared Memory After Startup" section.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com