MIME-Version: 1.0
References: <20230329.132155.629765142788133576.horikyota.ntt@gmail.com>
 <20230329.173456.1185961934810139447.horikyota.ntt@gmail.com>
 <CAAKRu_Yg4-kWH_EN7wtpm3z9B+H27UTmOxzzYv1Vg=YdZ6v_rw@mail.gmail.com>
 <CAD21AoCGdxYAJHmE_nXw_MFw1+Qtn3vcThRu5FiadukgQnpWeQ@mail.gmail.com>
 <935191FB-083B-4060-89FC-466F61FAA391@yesql.se> <CAAKRu_aoa0YT36q2n3xa9MZYdepeH4Jyf2EVJj=7YdC_1c974Q@mail.gmail.com>
 <CAAKRu_bSsChKsyEy1ZV2XJQ22FoDdA56efjNr9==m2TO94557w@mail.gmail.com>
 <CAD21AoDi4i4tj1Cf9BG0q2iyVhHisQ2xxVBZajEqExX6t6_b3g@mail.gmail.com>
 <CAAKRu_bkg+0WAGTxsy0HP75RzFbPwqz3ctYq1kThjFhSL69upw@mail.gmail.com>
 <1252075.1680547394@sss.pgh.pa.us> <20230403190837.qubpnwugfe2k2g46@awork3.anarazel.de>
 <CAAKRu_ap7nhmqtKQ1TRo3LzHG3FK=YpGO=O0019M3BbN7ysm3A@mail.gmail.com>
 <7E06F879-7E20-4A6A-862F-CA72CDC9A323@yesql.se> <CAAKRu_b1HjGCTsFpUnmwLNS8NeXJ+JnrDLhT1osP+Gq9HCU+Rw@mail.gmail.com>
 <CBF0083E-5893-4B35-9498-142A835D03DC@yesql.se> <CAAKRu_bJ2DJxYoMkyMo9UpoX74LY5d2Jir86QWFUftrGKWP5Bw@mail.gmail.com>
 <CA+TgmoYDYHht9zsHye3tywx7oWGMP4s_6AGefHkDsMuGHLzT7w@mail.gmail.com>
 <CAAKRu_auVL_uE794zwiX6t18LJvKtJ5mrmV9tkbpWzS8AYeChQ@mail.gmail.com>
 <CAAKRu_aX+MLn32kPnAQ30WChbiLTkKKmY9e8+B1ZY1BokpQZYA@mail.gmail.com>
 <CAAKRu_aH-UbvNCQq-EouNUTjtGexQTRVo7ik_vYR4WUocVny7w@mail.gmail.com>
 <CA+TgmoY3EaCz3_7F3+Sb3FUHonf4nxdC-_UWnn6fWEPtXU7t5g@mail.gmail.com>
 <D0A88FB1-56A6-4CD5-B886-8539B7BA7F58@yesql.se> <CAAKRu_YmQg_i=0DBfPzy1MMc2GjfuJFo=0rFv4fCzRQStLhjvw@mail.gmail.com>
 <CAAKRu_beQECOV4WfU6nG0hhEVobCnH88Y8MQi1LrTwMfRyxuCw@mail.gmail.com>
 <5028847C-937A-4CC2-B127-AFF5F9FB79C5@yesql.se> <CAAKRu_Znk6WCCQqEw8hv3+X1Fm8gG0x4KKRAkKmO2JOcA-77-g@mail.gmail.com>
 <2B703533-102A-47E5-A4F7-C6A68C09BB27@yesql.se> <CAD21AoBS7o6Ljt_vfqPQPf67AhzKu3fR0iqk8B=vVYczMugKMQ@mail.gmail.com>
 <CAAKRu_bETD+Ari600h6fRjX2p8rJSeMAUp=_y88juqOZgouTSg@mail.gmail.com>
 <23D2F3D0-90C2-428A-817F-1E16194DDC2D@yesql.se> <CAD21AoD22LdRdvwmiybmOpr+0d1gCEMyOLs9CoU46rycZb-mJg@mail.gmail.com>
In-Reply-To: <CAD21AoD22LdRdvwmiybmOpr+0d1gCEMyOLs9CoU46rycZb-mJg@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Mon, 17 Apr 2023 11:04:22 +0900
Message-ID: <CAD21AoBaBbLTejxYDpHg_oHhXO1RgzKTY1-qj8DjeWGcv9Fnbg@mail.gmail.com>
Subject: Re: Should vacuum process config file reload more often
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Melanie Plageman <melanieplageman@gmail.com>, Robert Haas <robertmhaas@gmail.com>, 
	Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, 
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, 
	Amit Kapila <amit.kapila16@gmail.com>
Content-Type: multipart/mixed; boundary="0000000000003bb0ae05f97e9e80"
Archived-At: <https://www.postgresql.org/message-id/CAD21AoBaBbLTejxYDpHg_oHhXO1RgzKTY1-qj8DjeWGcv9Fnbg%40mail.gmail.com>
Precedence: bulk

--0000000000003bb0ae05f97e9e80
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 12, 2023 at 12:05=E2=80=AFAM Masahiko Sawada <sawada.mshk@gmail=
.com> wrote:
>
> On Fri, Apr 7, 2023 at 10:23=E2=80=AFPM Daniel Gustafsson <daniel@yesql.s=
e> wrote:
> >
> > > On 7 Apr 2023, at 15:07, Melanie Plageman <melanieplageman@gmail.com>=
 wrote:
> > > On Fri, Apr 7, 2023 at 2:53=E2=80=AFAM Masahiko Sawada <sawada.mshk@g=
mail.com> wrote:
> > >
> > > Definitely seems worth fixing as it kind of defeats the purpose of th=
e
> > > original commit. I wish I had noticed before!
> > >
> > > Your fix has:
> > >            !(avopts && (avopts->vacuum_cost_limit >=3D 0 ||
> > >                        avopts->vacuum_cost_delay >=3D 0));
> > >
> > > And though delay is required to be >=3D 0
> > >                        avopts->vacuum_cost_delay >=3D 0
> > >
> > > Limit does not. It can just be > 0.
> > >
> > > postgres=3D# create table foo (a int) with (autovacuum_vacuum_cost_li=
mit =3D 0);
> > > ERROR:  value 0 out of bounds for option "autovacuum_vacuum_cost_limi=
t"
> > > DETAIL:  Valid values are between "1" and "10000".
> > >
> > > Though >=3D is also fine, the rest of the code in all versions always
> > > checks if limit > 0 and delay >=3D 0 since 0 is a valid value for del=
ay
> > > and not for limit. Probably best we keep it consistent (though the wh=
ole
> > > thing is quite confusing).
> >
> > +1
>
> +1. I misunderstood the initial value of autovacuum_vacuum_cost_limit rel=
option.

I've attached an updated patch for fixing at_dobalance condition.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

--0000000000003bb0ae05f97e9e80
Content-Type: application/octet-stream; 
	name="0001-Fix-the-condition-of-joining-autovacuum-workers-to-b.patch"
Content-Disposition: attachment; 
	filename="0001-Fix-the-condition-of-joining-autovacuum-workers-to-b.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lgk6zcsa0>
X-Attachment-Id: f_lgk6zcsa0

RnJvbSA4NzVlMGNhMTk2NWZiMzcxYTk4MmQwZWQ5YjgwNWM0NWZhZWVhYjIyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXNhaGlrbyBTYXdhZGEgPHNhd2FkYS5tc2hrQGdtYWlsLmNv
bT4KRGF0ZTogTW9uLCAxNyBBcHIgMjAyMyAxMDo1OToxNyArMDkwMApTdWJqZWN0OiBbUEFUQ0hd
IEZpeCB0aGUgY29uZGl0aW9uIG9mIGpvaW5pbmcgYXV0b3ZhY3V1bSB3b3JrZXJzIHRvIGJhbGFu
Y2UKIGNhbGN1bGF0aW9uLgoKUHJldmlvdXNseSwgd2UgZXhjbHVkZSBhbiBhdXRvdmFjdXVtIHdv
cmtlciBmcm9tIGJhbGFuY2UgY2FsY3VsYXRpb24KaWYgdGhlIHRhYmxlJ3MgYXV0b3ZhY3V1bV92
YWN1dW1fY29zdF9kZWxheSBzdG9yYWdlIG9wdGlvbiBpcyA+CjAuIEhvd2V2ZXIsIHNpbmNlIHRo
ZSBpbml0aWFsIHZhbHVlIGFuZCBtaW5pbXVtIHZhbHVlIG9mCmF1dG92YWN1dW1fdmFjdXVtX2Nv
c3RfZGVsYXkgc3RvcmFnZSBvcHRpb24gYXJlIC0xIGFuZCAwIHJlc3BlY3RpdmVseSwKd2Ugc2hv
dWxkIGV4Y2x1ZGUgaXQgaWYgdGhlIHRhYmxlJ3MgYXV0b3ZhY3V1bV92YWN1dW1fY29zdF9kZWxh
eQpzdG9yYWdlIG9wdGlvbiBpcyA+PSAwLgotLS0KIHNyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvYXV0
b3ZhY3V1bS5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0
aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9hdXRvdmFjdXVtLmMg
Yi9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL2F1dG92YWN1dW0uYwppbmRleCA1M2M4ZjhkNzljLi4z
M2Q4MGIwNjdiIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL2F1dG92YWN1dW0u
YworKysgYi9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL2F1dG92YWN1dW0uYwpAQCAtMjk1Miw3ICsy
OTUyLDcgQEAgdGFibGVfcmVjaGVja19hdXRvdmFjKE9pZCByZWxpZCwgSFRBQiAqdGFibGVfdG9h
c3RfbWFwLAogCQkgKi8KIAkJdGFiLT5hdF9kb2JhbGFuY2UgPQogCQkJIShhdm9wdHMgJiYgKGF2
b3B0cy0+dmFjdXVtX2Nvc3RfbGltaXQgPiAwIHx8Ci0JCQkJCQkgYXZvcHRzLT52YWN1dW1fY29z
dF9kZWxheSA+IDApKTsKKwkJCQkJCSBhdm9wdHMtPnZhY3V1bV9jb3N0X2RlbGF5ID49IDApKTsK
IAl9CiAKIAloZWFwX2ZyZWV0dXBsZShjbGFzc1R1cCk7Ci0tIAoyLjMxLjEKCg==
--0000000000003bb0ae05f97e9e80--