MIME-Version: 1.0
References: 
 <CA+hUKG+Yv+ps=nS2T8SS1UDU=iySHSr4sGHYiYGkPTpZx6Ooww@mail.gmail.com>
 <CA+hUKGKOuA4vTkFk01RSLqyM0pzNjYm-3h2zAtW48Ffc7FjjNg@mail.gmail.com>
 <CA+hUKG+ue0KC5KSqMuL5zi7uCSuXCLP_B+sZSq5=yS84606ZsA@mail.gmail.com>
 <423491f5-2eaa-454e-8dc9-037d69c1a8f9@eisentraut.org>
 <CA+hUKG+fApBC7Ziq2HP6K-6ymD=AafyvYQq9HGfyRCoBw-PGtQ@mail.gmail.com>
 <d9e7731c-ca1b-477c-9298-fa51e135574a@eisentraut.org>
 <CA+hUKGLbEhVb029AQJDCZ4+QgcqVmERJGZefxS=+b+SBBSGW8A@mail.gmail.com>
 <2652c576-29b3-4b4a-b61b-10275cacadcb@eisentraut.org>
 <CA+hUKG+iJtpun-sFqRYgJQt7eWEZnrsG_i=d_PRyHBqGrahCQw@mail.gmail.com>
 <Z0PICeukFeEutR83@paquier.xyz>
 <CA+hUKGK1J_jsS1bgRTWW9swuGYMrt8pijYAr4VUjcih7Hhqx-w@mail.gmail.com>
 <679e8c35-0429-478e-8805-607d15b82e53@eisentraut.org>
 <CA+hUKGLMpy4sXaVduYDoNWtynm5NS4f=k7M51qg4SPHzUkdxvw@mail.gmail.com>
 <b8b34a1c-1210-4998-8340-274bc73f3bad@eisentraut.org>
 <3f16f601-6785-4751-9fd9-2bfd5117e760@eisentraut.org>
 <CAD21AoBO71nQE5eR_MxA+CjzjrvUUsmeauDPJbrEF7D7dfHqBQ@mail.gmail.com>
 <1a0bad5f-0ab1-46bc-a70b-9290291c9cd8@eisentraut.org>
In-Reply-To: <1a0bad5f-0ab1-46bc-a70b-9290291c9cd8@eisentraut.org>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri, 28 Mar 2025 17:01:14 -0700
Message-ID: 
 <CAD21AoBeHVsh6+UMSb-bbFFeTc4G1jOkBAvq-9BPMAuMoid3-A@mail.gmail.com>
Subject: Re: On non-Windows, hard depend on uselocale(3)
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Thomas Munro <thomas.munro@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
	Andrew Dunstan <andrew@dunslane.net>, Tristan Partin <tristan@neon.tech>,
 Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoBeHVsh6%2BUMSb-bbFFeTc4G1jOkBAvq-9BPMAuMoid3-A%40mail.gmail.com>
Precedence: bulk

On Fri, Mar 28, 2025 at 9:32=E2=80=AFAM Peter Eisentraut <peter@eisentraut.=
org> wrote:
>
> On 28.03.25 17:14, Masahiko Sawada wrote:
> > On Fri, Mar 28, 2025 at 8:30=E2=80=AFAM Peter Eisentraut <peter@eisentr=
aut.org> wrote:
> >>
> >> On 09.02.25 08:32, Peter Eisentraut wrote:
> >>> Checking the status of this thread ...
> >>>
> >>> The patches that removed the configure checks for _configthreadlocale=
(),
> >>> and related cleanup, have been committed.
> >>>
> >>> The original patch to "Tidy up locale thread safety in ECPG library" =
is
> >>> still outstanding.
> >>>
> >>> Attached is a rebased version, based on the posted v6, with a couple =
of
> >>> small fixups from me.
> >>>
> >>> I haven't re-reviewed it yet, but from scanning the discussion, it lo=
oks
> >>> close to done.
> >>
> >> After staring at this a few more times, I figured it was ready enough
> >> and I committed it.
> >
> > It seems that some bf animals such as jackdaw are unhappy with this
> > commit[0][1]. I also got the same 'undefined reference to symbol
> > error' locally when building test_json_parser.
>
> Yeah, looks like we'll have to revert this for now.  But I'm confused,
> because I don't see any clear pattern for which platforms or
> configurations it's failing and for which not.
>

Not sure it would help the investigation but I got the linker error
when building with 'make' but not with 'meson'. Looking at the build
logs, when building test_json_parser with meson, it adds -lpthread as
follows:

% /home/masahiko/work/gcc/12.2.0/bin/gcc -v -o
src/test/modules/test_json_parser/test_json_parser_incremental_shlib
src/test/modules/test_json_parser/test_json_parser_incremental_shlib.p/test=
_json_parser_incremental.c.o
-Wl,--as-needed -Wl,--no-undefined
'-Wl,-rpath,$ORIGIN/../../../interfaces/libpq:/lib/../lib64'
-Wl,-rpath-link,/lib/../lib64
-Wl,-rpath-link,/home/masahiko/pgsql/source/dev_master/build/src/interfaces=
/libpq
-Wl,--start-group src/common/libpgcommon_excluded_shlib.a
src/common/libpgcommon_shlib.a
src/common/libpgcommon_shlib_config_info.a
src/common/libpgcommon_shlib_ryu.a src/port/libpgport_shlib.a
src/interfaces/libpq/libpq.so.5.18 -lm -ldl -pthread -lrt
/usr/lib64/libz.so /lib/../lib64/libzstd.so /usr/lib64/liblz4.so
/usr/lib64/libssl.so /usr/lib64/libcrypto.so -Wl,--end-group

whereas with 'make' it doesn't:

% gcc -v -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Werror=3Dvla -Wendif-labels
-Wmissing-format-attribute -Wimplicit-fallthrough=3D3
-Wcast-function-type -Wshadow=3Dcompatible-local -Wformat-security
-fno-strict-aliasing -fwrapv -fexcess-precision=3Dstandard
-Wno-format-truncation -Wno-stringop-truncation -g -g -O0
test_json_parser_incremental.o -L../../../../src/port
-L../../../../src/common   -Wl,--as-needed
-Wl,-rpath,'/home/masahiko/pgsql/master/lib',--enable-new-dtags
-lpgcommon_excluded_shlib -L../../../../src/common -lpgcommon_shlib
-L../../../../src/port -lpgport_shlib
-L../../../../src/interfaces/libpq -lpq  -o
test_json_parser_incremental_shlib

FYI the following change fixed the issue in my local env:

--- a/src/test/modules/test_json_parser/Makefile
+++ b/src/test/modules/test_json_parser/Makefile
@@ -27,7 +27,7 @@ test_json_parser_incremental$(X):
test_json_parser_incremental.o $(WIN32RES)
    $(CC) $(CFLAGS) $^ $(PG_LIBS_INTERNAL) $(LDFLAGS) $(LDFLAGS_EX)
$(PG_LIBS) $(LIBS) -o $@

 test_json_parser_incremental_shlib$(X):
test_json_parser_incremental.o $(WIN32RES)
-   $(CC) $(CFLAGS) $^ $(LDFLAGS) -lpgcommon_excluded_shlib
$(libpq_pgport_shlib) $(filter -lintl, $(LIBS)) -o $@
+   $(CC) $(CFLAGS) $^ $(LDFLAGS) -lpgcommon_excluded_shlib
$(libpq_pgport_shlib) $(filter -lintl, $(LIBS)) $(LIBS) -o $@

 test_json_parser_perf$(X): test_json_parser_perf.o $(WIN32RES)
    $(CC) $(CFLAGS) $^ $(PG_LIBS_INTERNAL) $(LDFLAGS) $(LDFLAGS_EX)
$(PG_LIBS) $(LIBS) -o $@

It seems that no MacOS and NetBSD animals failed due to this error
because they have LC_C_LOCALE. But I'm not sure why some animals
successfully built test_json_parser() even without -lpthread or
-pthread[1][2].

Regards,

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dprion&d=
t=3D2025-03-28%2015%3A33%3A03&stg=3Dmake-testmodules
[2] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dbushmas=
ter&dt=3D2025-03-28%2015%3A32%3A01&stg=3Dmake-testmodules

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com