Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wA1Cr-001zGC-28 for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Apr 2026 07:50:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wA1Cp-00FQ17-2f for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Apr 2026 07:50:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wA1Cp-00FQ0y-1N for pgsql-hackers@lists.postgresql.org; Tue, 07 Apr 2026 07:50:39 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wA1Cn-00000000zhA-0qsv for pgsql-hackers@lists.postgresql.org; Tue, 07 Apr 2026 07:50:38 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-2b0ba3bfe16so45283625ad.1 for ; Tue, 07 Apr 2026 00:50:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775548236; cv=none; d=google.com; s=arc-20240605; b=WdsRrS9bDZe3QGvR5aM7ptB/DyZPw1ibl3pe6hXrWA/GHKMJ5TUAvIkE/JzmrfM50t XI6GDUxWi99z9s/DpkdmSZj5D06ty8CazlpuYJ8NVeyiE89Gq1N0RDi6bkf7J13uIc39 rckTpEHfUyfNEAIvsKYVh623FxcCIYkgLFqETf4+ZPQflK+gtq1Sv9EBjBhd9G6+sLde Li8mzwzR3ieT9ogtJpvfN/uIIXNVI3sMfRD6DvE3qmOpMT1/dFbxbinuYfHj9Z1dL2S6 +Ta5r3ZWvSuMSC8g/8wh7pFPVLTSy9iUeGdGMLOaZ+xGteL18Fzg34JJobNXKVedQX8P WDug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=u2c0C2i3LOB3Ta4+Vypb2hvbGQKprGHUVnVWPFH0pVU=; fh=7ecEoNkg93afB5bSP5oPTSMZnZcsvoPNuRd+5wuT0vI=; b=cfihPrty0T26nEE0bkQwmYT0hwu0d9QFJ6SQkr2xJLQjnJXv65nWwgHochbhc1vTb2 Af5Cb/eODEamBwqV1o1Mtoes8ycUFKKstszcUIrvWDZP5Z3+LcAA3AfPSVr+nqpxjLWG RSrEtXmV9QR9ynOYc009dQWhBzVshnRRSaQZg92OTFA/8TIyLXr0O3VwWoKtQCmjUnaJ SK578B0TneIFPl9sVbFvK8Xavb9D8xZeGWBTsUM0w41UDwMOQktfS7G+7oKdQ/T8SIR6 BeGvohzGpeRGO6vlYN8/e3Bae8FJNOVN78s0oIXLtcxLbAsoDuPpJlwgORW1pC3NVawt G5vw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775548236; x=1776153036; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=u2c0C2i3LOB3Ta4+Vypb2hvbGQKprGHUVnVWPFH0pVU=; b=IAgT38dRwEiQTL8mVdE58HLqhxAqyKYnYThnC4jJInb4c7qYWTUnMWM70ak75dh5jL mKp4lSG9HqRe4ieEWiw6x4JvMNKZeOxB4JwTPuM8U44VUB5rQP/MHF+w59DGZG/0dMO/ fnR1/zihD+SDA5Bqd0fPnPyvLPiupGaF1i1I2UylUEqfcmWhCBlYS10otXGfJvtUMX35 l27Z+fhnRXl4MIw3UhLx2EuFQNIkPnPUdp17CTgESEMBKrOFd/r/El3tssM3ydC+hWnO CrXBHHfnU/8Hl+wiqEFQFGQq4zcffPV0EqQd8KNmiUrbD6oZr6W/ulMb/Xhk8G+WVrsZ FCOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775548236; x=1776153036; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=u2c0C2i3LOB3Ta4+Vypb2hvbGQKprGHUVnVWPFH0pVU=; b=LXb+sGb0sCV9YHgWy+SpGLyq0fJrW84qBV4qpu3iTOITWKxG8RQ4f6GA2X3/6AIcz5 pyqBevilEgifHszuQRJcn2CaVWmROw41EPih+qFOtel+0sx4Ybvi2YT0cnF+Uo50Qijs pq1gnzrW2MkUaEXl1VB8cl/oICmRYvMXniUiqOdF8J3dMnk199DAXugEmxzPgRSFEP59 pL0BTEZSy+0ICKFLLFvqDCecN9x5TVTkRrlzAWwZhvGFlfmMa1jEKLeucW2KQ3wJru8U K0EK6XAuMtfCPo2yVU5DanFfdSAUGLLVDSRArzN6HJYxS1sPT6dLL3jthFoXflNUYtkI NZHg== X-Forwarded-Encrypted: i=1; AJvYcCWJhGTfaLxvwISaKynwJOGbTAPgkEtkmi7ldGtY8avgv1/MvTcck7+m7/xsVlk0tBy81F5FYpSfL53xHUcY@lists.postgresql.org X-Gm-Message-State: AOJu0YxLAWKGe9Cj8h0vT2DSOyV4HApTWxPiRZiLL2zJzUkdK0z3+xU8 LC3kMkTaPJjfI7dBBKK++uCo2OCtcLZbZ/BeDGmdta1IArDy8xM+389eidcB8XH9lDWuuGkVp+z r9O2hO8qDUQo6EGQTZZ2D0LyOVB+0TNY= X-Gm-Gg: AeBDievlihKaK8mz27tK7LsvxQvCGklniA/eUYg9uiGQtLD7NvS/SnZXJqe1EfF2pJH vw/EHYW0YILXrdKED5wGffdceuvS8E9AKJVLcXgnBMtBoVGdWV7mC5vGxDpTLgW95kxXJ0tlGdf T8WhRBPDu+h9VseLC93tPS5h++Ps6nv4NEUalNiD+dY6fbqTa7X70NWs20KCpt17yHoPB0UGz6N zFQDTjSDvOs5wnSVqkvpIH5nMuFF/tDFCLvMFdpueAGOpWuVBi1wusjOm99xyq2CXuQI7W8Umsy r7Xcc+mo X-Received: by 2002:a17:902:d2ce:b0:2b2:3eec:c75b with SMTP id d9443c01a7336-2b281b8eb03mr145434565ad.2.1775548236361; Tue, 07 Apr 2026 00:50:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Masahiko Sawada Date: Tue, 7 Apr 2026 00:49:57 -0700 X-Gm-Features: AQROBzCJWuJbY0o1fEMTAJUFsujoj5NHGE9zfJGTdBE_G7sKu8mQtOFfL20iBlg Message-ID: Subject: Re: POC: Parallel processing of indexes in autovacuum To: Daniil Davydov <3danissimo@gmail.com> Cc: Alexander Korotkov , SATYANARAYANA NARLAPURAM , Bharath Rupireddy , Sami Imseih , Matheus Alcantara , Maxim Orlov , Postgres hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Apr 4, 2026 at 1:38=E2=80=AFAM Daniil Davydov <3danissimo@gmail.com= > wrote: > > Hi, > > On Sat, Apr 4, 2026 at 8:12=E2=80=AFAM Masahiko Sawada wrote: > > > > Regarding the regression tests, ISTM we no longer need > > 'autovacuum-leader-before-indexes-processing' injection point since it > > currently tests that parallel workers update their delay parameters > > during the initialization (i.e., in parallel_vacuum_main()). In order > > to verify the behavior of workers updating their delay parameters > > while processing indexes, we would need another injection ponit to > > stop parallel workers, which seems overkill to me. So I removed it but > > the test still covers the propagation logic. > > > > Regarding the patch, I don't think it's a good idea to include > > bgworker_internals.h from reloptions.c: > > > > I'd leave the maximum value as 1024. > > OK, let's leave it. > > > > > I've attached patch and please check it. I think it's a good shape and > > I'm going to push it next Monday barrying objections. > > > > Thank you for updating the patch! > All changes look good to me. Thank you! Pushed. > BTW, what about the "opt-in vs. opt-out style" issue? > As I wrote here [1], we can consider a new approach - allow the user to s= et the > autovacuum_max_workers reloption even if GUC parameter is zero. > I think it can satisfy all possible use cases. I've just replied to the email. Please check it[1]. Regards, [1] https://www.postgresql.org/message-id/CAD21AoDEfe5-tYSqa%3DMGLP5TX5QH2i= rVZVyULCeTQj0J92Hp1A%40mail.gmail.com --=20 Masahiko Sawada Amazon Web Services: https://aws.amazon.com