MIME-Version: 1.0
References: 
 <CAB-JLwbBFNuASyEnZWP0Tck9uNkthBZqi6WoXNevUT6+mV8XmA@mail.gmail.com>
 <CAD21AoA6i2ui8FMZeuU_KxX4t-fM8G==zTW2Dp6-goujttrpew@mail.gmail.com>
 <CAB-JLwZpp=7c9_r0beWWJxRh2BS_2Vvth8UDv7H57DBeaqggVg@mail.gmail.com>
 <CAD21AoDT3sL2COprsRumM9zEpL1Bk5VWboK4V2mRnjGua8xfeA@mail.gmail.com>
 <CAD21AoDQM62GOtaTzD_CVMSsFhv6o9c0Au1dSM1QuxeKFkWAKw@mail.gmail.com>
 <CAD21AoCz7HjEr3oeb=haK31YHxHZLcvD_wx_a-+xLPKywq++3A@mail.gmail.com>
 <TY4PR01MB16907733B75A99117F013AFCA947FA@TY4PR01MB16907.jpnprd01.prod.outlook.com>
 <CAD21AoA9YgiY1rVKMPZwB00WU_G4UfzoawY=7hyd7hpvBPcK6w@mail.gmail.com>
 <CAA4eK1KoSi60dtakJzn0MxNnHF1Yf4indSAffTjJxQG_31jsgQ@mail.gmail.com>
 <CAD21AoB4B3MOxJ7-v9YLjV5fTOtaLRUhX3jN3kqhEi7D7-uY4A@mail.gmail.com>
 <0c28fbd1-3320-4e9b-815c-6d62753aa063@wi3ck.info>
 <CAD21AoCmHpKrNg9D3mcOA973CZ5N_dBLxb8pERpSxEeRLSQxpA@mail.gmail.com>
 <CAD21AoAEVyxwn_bMWHvcU-Gcz3aUVjAtMbdgfoJ8MZNiLLEh0g@mail.gmail.com>
 <CAHut+Pv-N2YO3KB4Ohzkv97eiXC=JyU1cbpDsaSXm+jb7-OPCw@mail.gmail.com>
In-Reply-To: 
 <CAHut+Pv-N2YO3KB4Ohzkv97eiXC=JyU1cbpDsaSXm+jb7-OPCw@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Tue, 24 Mar 2026 11:45:13 -0700
Message-ID: 
 <CAD21AoC-DwnY4TwfApdBA3=+FGrz7foDf+J5fQ7x7kKbvOnmmg@mail.gmail.com>
Subject: Re: Initial COPY of Logical Replication is too slow
To: Peter Smith <smithpb2250@gmail.com>
Cc: Jan Wieck <jan@wi3ck.info>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoC-DwnY4TwfApdBA3%3D%2BFGrz7foDf%2BJ5fQ7x7kKbvOnmmg%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 23, 2026 at 11:59=E2=80=AFPM Peter Smith <smithpb2250@gmail.com=
> wrote:
>
> Hi Sawada-San.
>
> Here are some review comments for the v3-0001 test code.

Thank you for reviewing the patch!

>
> =3D=3D=3D=3D=3D=3D
> src/test/regress/expected/publication.out
>
> 1.
> +-- Clean up
> +DROP FUNCTION test_gpt(text[], relname);
> +ERROR:  type "relname" does not exist
>
> This seems a mistake. If the DROP FUNCTION was differently written
> there there would be no error. PSA.

Fixed.

>
> =3D=3D=3D=3D=3D=3D
> src/test/regress/sql/publication.sql
>
> 2.
> +SELECT * FROM test_gpt('pub_normal', 'tbl_normal');
> +SELECT * FROM test_gpt('pub_schema', 'tbl_normal'); -- no result
>
> These tests seem strangely different from all the others because
> everything else has both a "good result" test and a "no result" test
> for every publication.
>
> So I think there should be a "no result" test for 'pub_normal'
>
> So I think there should be a "good result" test for 'pub_schema'

Added.

>
> ~~~
>
> 3.
> Consider renaming that 'tbl_parent' to something like 'tbl_root'.
> because 'parent' always makes me think of INHERITED parent/child
> tables, rather than partitioned tables and their partitions. If you do
> this, then you might also want to tweak several publication names --
> e.g. 'pub_part_parent' -> 'pub_part_root'

Hmm, there are already some queries using 'parent' in the same .sql
file. I'll leave these names.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com