MIME-Version: 1.0
References: <C1D2509E-E5D1-46B0-932C-B57AA7B963A1@gmail.com>
In-Reply-To: <C1D2509E-E5D1-46B0-932C-B57AA7B963A1@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri, 26 Jun 2026 14:09:26 -0700
Message-ID: 
 <CAD21AoCsbjvgk5tOarepYF28dW7P6NG8SLVDQ72A7AJ3yEjriw@mail.gmail.com>
Subject: Re: COPY: validate option presence rather than option values
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoCsbjvgk5tOarepYF28dW7P6NG8SLVDQ72A7AJ3yEjriw%40mail.gmail.com>
Precedence: bulk

On Tue, May 5, 2026 at 9:26=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wro=
te:
>
> Hi,
>
> While testing COPY TO (FORMAT json), I noticed that the doc says FORCE_AR=
RAY is only allowed with FORMAT json:
> ```
>    <varlistentry id=3D"sql-copy-params-force-array">
>     <term><literal>FORCE_ARRAY</literal></term>
>     <listitem>
>      <para>
>       Force output of square brackets as array decorations at the beginni=
ng
>       and end of output, and commas between the rows. It is allowed only =
in
>       <command>COPY TO</command>, and only when using
>       <literal>json</literal> format. The default is
>       <literal>false</literal>.
>      </para>
>     </listitem>
>    </varlistentry>
> ```
>
> However, this succeeds:
> ```
> evantest=3D# copy t1 to stdout (format csv, force_array false);
> 1
> ```
>
> So this is clearly validating the parsed value of force_array, rather tha=
n whether the option was specified at all.

Hmm, I'm not sure this is actually a problem in practice. It seems
straightforward to me that the documentation stating 'it is allowed
only when...' can be interpreted as 'it is allowed to be enabled only
when...'. My concern is that the proposed patch could make the command
unnecessarily less flexible. This is especially true in cases where
users programmatically generate a template COPY query and pass
explicit boolean values (true/false) to the options. Also, other
commands like VACUUM handle their boolean options in the exact same
manner:

=3D# vacuum (parallel 1, full) pg_class;
ERROR:  VACUUM FULL cannot be performed in parallel
=3D# vacuum (parallel 1, full off) pg_class;
VACUUM

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com