MIME-Version: 1.0
References: <CA0C373A-6857-4C4C-BF67-5C72AABA0E0D@greg.burd.me>
 <36B1B121-A962-4CB3-B22C-23BA4F13F8D1@greg.burd.me>
In-Reply-To: <36B1B121-A962-4CB3-B22C-23BA4F13F8D1@greg.burd.me>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Tue, 16 Sep 2025 15:00:40 -0700
Message-ID: 
 <CAD21AoD4DOkiF1ZPZJn1bnZBx7WuTYqGx1j8nMk9FyCMrwm83w@mail.gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
To: Greg Burd <greg@burd.me>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Nathan Bossart <nathandbossart@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
	Robert Haas <robertmhaas@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoD4DOkiF1ZPZJn1bnZBx7WuTYqGx1j8nMk9FyCMrwm83w%40mail.gmail.com>
Precedence: bulk

On Tue, Sep 16, 2025 at 12:04=E2=80=AFPM Greg Burd <greg@burd.me> wrote:
>
> I've re-written the set of tests as suggested (I hope!).  I've not
> re-run the coverage report (yet) to ensure we're at least as well
> covered as v3, but attached is v4 for your inspection (amusement?).
> I've tried to author the SQL tests such that failures clearly indicate
> what's at gone wrong.
>
> This exercise turned into a lot more LOC than I'd expected, I hope it
> provides some value to the community for testing this important data
> structure and helps to codify the API clearly.

Thank you for updating the patch. It seems cfbot caught a regression
test error[1] in a 32-bit build.

Regards,

[1] https://cirrus-ci.com/task/5290864655728640

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com