MIME-Version: 1.0
References: 
 <CAB-JLwbBFNuASyEnZWP0Tck9uNkthBZqi6WoXNevUT6+mV8XmA@mail.gmail.com>
 <CAD21AoA6i2ui8FMZeuU_KxX4t-fM8G==zTW2Dp6-goujttrpew@mail.gmail.com>
 <CAB-JLwZpp=7c9_r0beWWJxRh2BS_2Vvth8UDv7H57DBeaqggVg@mail.gmail.com>
 <CAD21AoDT3sL2COprsRumM9zEpL1Bk5VWboK4V2mRnjGua8xfeA@mail.gmail.com>
 <CAD21AoDQM62GOtaTzD_CVMSsFhv6o9c0Au1dSM1QuxeKFkWAKw@mail.gmail.com>
 <CAD21AoCz7HjEr3oeb=haK31YHxHZLcvD_wx_a-+xLPKywq++3A@mail.gmail.com>
 <TY4PR01MB16907733B75A99117F013AFCA947FA@TY4PR01MB16907.jpnprd01.prod.outlook.com>
 <CAD21AoA9YgiY1rVKMPZwB00WU_G4UfzoawY=7hyd7hpvBPcK6w@mail.gmail.com>
 <CAA4eK1KoSi60dtakJzn0MxNnHF1Yf4indSAffTjJxQG_31jsgQ@mail.gmail.com>
 <CAD21AoB4B3MOxJ7-v9YLjV5fTOtaLRUhX3jN3kqhEi7D7-uY4A@mail.gmail.com>
 <0c28fbd1-3320-4e9b-815c-6d62753aa063@wi3ck.info>
 <CAD21AoCmHpKrNg9D3mcOA973CZ5N_dBLxb8pERpSxEeRLSQxpA@mail.gmail.com>
 <CAD21AoAEVyxwn_bMWHvcU-Gcz3aUVjAtMbdgfoJ8MZNiLLEh0g@mail.gmail.com>
 <CAFPTHDb9ZiXzSu0N_1naOqAfLPWMOQV=o+WpL_EBLc5_5PEWvw@mail.gmail.com>
In-Reply-To: 
 <CAFPTHDb9ZiXzSu0N_1naOqAfLPWMOQV=o+WpL_EBLc5_5PEWvw@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Tue, 24 Mar 2026 11:42:10 -0700
Message-ID: 
 <CAD21AoDQpOdZe36aBPbFXcTTGodC99_oHED9LR3KrzOYFbGuvw@mail.gmail.com>
Subject: Re: Initial COPY of Logical Replication is too slow
To: Ajin Cherian <itsajin@gmail.com>
Cc: Jan Wieck <jan@wi3ck.info>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoDQpOdZe36aBPbFXcTTGodC99_oHED9LR3KrzOYFbGuvw%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 23, 2026 at 11:54=E2=80=AFPM Ajin Cherian <itsajin@gmail.com> w=
rote:
>
> On Thu, Mar 19, 2026 at 10:30=E2=80=AFAM Masahiko Sawada <sawada.mshk@gma=
il.com> wrote:
> >
> > I've attached the patch to implement this idea. The patch still
> > introduces a new function but it overloads
> > pg_get_publication_tables(). We might be able to handle different
> > input (array or text) in pg_get_publication_tables() better, but it's
> > enough for discussion at least.
> >
>
> The patch looks like a good performance improvement. Some minor comments:
>
> 1. src/test/regress/expected/publication.out
>
> +-- Clean up
> +DROP FUNCTION test_gpt(text[], relname);
> +ERROR:  type "relname" does not exist
>
> Cleanup actually fails. Second parameter should be text, not relname.
>
> 2. src/include/catalog/pg_proc.dat
>
> +  proallargtypes =3D> '{text,oid,oid,oid,int2vector,pg_node_tree}',
> +  proargmodes =3D> '{i,i,o,o,o,o}',
> +  proargnames =3D> '{pubname,relid,pubid,relid,attrs,qual}',
>
> Having two arguments with the same name "relid" seems odd, although
> one is input and other is output parameter, how about calling input
> parameter as target_relid?
>
> 3. src/backend/replication/logical/tablesync.c
>
> +
> +        if (server_version >=3D 190000)
> +        {
> +            /*
> +             * We can pass relid to pg_get_publication_table_info() sinc=
e
> +             * version 19.
> +             */
> +            appendStringInfo(&cmd,
> +                             "SELECT DISTINCT"
>
> In multiple places in the code pg_get_publication_table_info() is
> used, instead of pg_get_publication_tables()

Thank you for reviewing the patch! I agree with all the above points.
I'll share the updated patch soon.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com