MIME-Version: 1.0
References: 
 <OSZPR01MB63104E7449DBE41932DB19F1FD1B9@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <CAFiTN-v9r17Ae5uFJbFPQqdQyFtJb5=nZXBu8h1HW6xA9msrtg@mail.gmail.com>
 <OSZPR01MB63102546180646AEE1C66C34FDE09@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <CAA4eK1+vE1_iTty_2Z73_GgA6d26Kh9Oh+kY5uLi6kdterMV1Q@mail.gmail.com>
 <TYAPR01MB586604F7A7E27A6A1A695E32F5EA9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
 <CAA4eK1+b-Y=4a39Ux3mc7h8Y+ea+0qjYjMbKkGNwg9y=kf3fSQ@mail.gmail.com>
 <CAD21AoAAjhpS71y3xhZ8sAnX9GK4X31-+h-9RroTmMx4fpocSw@mail.gmail.com>
 <CAHut+Pvn-b0dC2_NO5Vu+8Nfh+MrTuuw_fi1nOo1oLdDPVNNWA@mail.gmail.com>
 <CAA4eK1LbHVsheSYu6uLfVREiNXFWRkS+ps8rfXKUhDBpk+FizA@mail.gmail.com>
 <OSZPR01MB6310AAE12BC281158880380DFDEB9@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <CAD21AoCL53znFEtFeb-wZ6X9F72aGBTZh5jmKoAAQdZwcG-0UQ@mail.gmail.com>
 <CAA4eK1KFRdPSGnkHSoR1T+Z08XsaL12fX8xMj_ZpAR6LR+RJYQ@mail.gmail.com>
 <TYAPR01MB58662090E3858FBD84226F6CF5E89@TYAPR01MB5866.jpnprd01.prod.outlook.com>
In-Reply-To: 
 <TYAPR01MB58662090E3858FBD84226F6CF5E89@TYAPR01MB5866.jpnprd01.prod.outlook.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Thu, 22 Dec 2022 16:59:30 +0900
Message-ID: 
 <CAD21AoDXHkCo2SLMgm1TxhBKJJ5srMPc=sjzc0webAG9ONk4cA@mail.gmail.com>
Subject: Re: Force streaming every change in logical decoding
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
	"shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
 Peter Smith <smithpb2250@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoDXHkCo2SLMgm1TxhBKJJ5srMPc%3Dsjzc0webAG9ONk4cA%40mail.gmail.com>
Precedence: bulk

On Thu, Dec 22, 2022 at 4:18 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Amit,
>
> Thank you for updating the patch. I have also checked the patch
> and basically it has worked well. Almost all things I found were modified
> by v4.
>
> One comment: while setting logical_decoding_mode to wrong value,
> I got unfriendly ERROR message.
>
> ```
> postgres=# SET logical_decoding_mode = 1;
> ERROR:  invalid value for parameter "logical_decoding_mode": "1"
> HINT:  Available values: , immediate
> ```
>
> Here all acceptable enum should be output as HINT, but we could not see the empty string.
> Should we modify config_enum_get_options() for treating empty string, maybe
> like (empty)?

Good point. I think the hint message can say "The only allowed value
is \"immediate\" as recovery_target does. Or considering the name of
logical_decoding_mode, we might want to have a non-empty string, say
'normal' as Kuroda-san proposed, as the default value.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com