MIME-Version: 1.0
References: 
 <CAA5RZ0s+kZZRMSF4HW7tZ9W2jS1o4B+Fg8dr5a-T6mANX+mdQA@mail.gmail.com>
In-Reply-To: 
 <CAA5RZ0s+kZZRMSF4HW7tZ9W2jS1o4B+Fg8dr5a-T6mANX+mdQA@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Tue, 7 Apr 2026 00:28:56 -0700
Message-ID: 
 <CAD21AoDZG6CUE9by0T2N33Zedw4iH0JF=9YoCuniXcugO+ixog@mail.gmail.com>
Subject: Re: test_autovacuum/001_parallel_autovacuum is broken
To: Sami Imseih <samimseih@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 Daniil Davydov <3danissimo@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000a71997064ed9be47"
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoDZG6CUE9by0T2N33Zedw4iH0JF%3D9YoCuniXcugO%2Bixog%40mail.gmail.com>
Precedence: bulk

--000000000000a71997064ed9be47
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 6, 2026 at 7:24=E2=80=AFPM Sami Imseih <samimseih@gmail.com> wr=
ote:
>
> Hi,
>
> I noticed that the test introduced in parallel autovacuum in 1ff3180ca01 =
was
> very slow, but eventually succeeded. I tracked it down to the point in
> the test that is waiting for "parallel autovacuum worker updated cost par=
ams".

Thank you for the report.

>
> This portion of the test that is waiting for the cost params to propagate=
 to the
> workers is getting stuck on wait_for_autovacuum_complete(). At the time
> it's stuck the injection point from the previous test
> autovacuum-start-parallel-vacuum
> is still active on template1 tables.
(snip)
> I think we can remove the second wait_for_autovacuum_complete()
> call in the test, as all we really need is to wait_for_log to guarantee
> the cost parameters were updated. No need to wait for the autovacuum
> to complete.

It sound like a good idea. In the test 2, we make garbage tuples on
test_autovac table but it doesn't necessarily mean that autovacuum
would work only on that table. Also given that the purpose of this
test is to check the propagation works fine, we can verify it whatever
tables eligible for parallel vacuum.

I've attached the patch, and am going to push it barring any objections.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

--000000000000a71997064ed9be47
Content-Type: text/x-patch; charset="UTF-8";
	name="0001-Remove-an-unstable-wait-from-parallel-autovacuum-reg.patch"
Content-Disposition: attachment;
	filename="0001-Remove-an-unstable-wait-from-parallel-autovacuum-reg.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnoasdtr0>
X-Attachment-Id: f_mnoasdtr0

RnJvbSAyZWJjOGRmOWY3Y2U3NTc4MjAyNDdkNmU5N2I0MTA5Zjk1Y2U4NWY2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXNhaGlrbyBTYXdhZGEgPHNhd2FkYS5tc2hrQGdtYWlsLmNv
bT4KRGF0ZTogTW9uLCA2IEFwciAyMDI2IDIxOjM4OjE1IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0g
UmVtb3ZlIGFuIHVuc3RhYmxlIHdhaXQgZnJvbSBwYXJhbGxlbCBhdXRvdmFjdXVtIHJlZ3Jlc3Np
b24KIHRlc3QuCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hh
cnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpUaGUgdGVzdCAwMDFf
cGFyYWxsZWxfYXV0b3ZhY3V1bS5wbCB2ZXJpZmllZCB0aGF0IHZhY3V1bSBkZWxheQpwYXJhbWV0
ZXJzIGFyZSBwcm9wYWdhdGVkIHRvIHBhcmFsbGVsIHZhY3V1bSB3b3JrZXJzIGJ5IHVzaW5nCmlu
amVjdGlvbiBwb2ludHMuIEl0IHByZXZpb3VzbHkgd2FpdGVkIGZvciBhdXRvdmFjdXVtIHRvIGNv
bXBsZXRlIG9uCnRoZSB0ZXN0X2F1dG92YWMgdGFibGUuIEhvd2V2ZXIsIHNpbmNlIGluamVjdGlv
biBwb2ludHMgYXJlCmNsdXN0ZXItd2lkZSwgYW4gYXV0b3ZhY3V1bSB3b3JrZXIgY291bGQgYmUg
dHJpZ2dlcmVkIG9uIHRhYmxlcyBpbgpvdGhlciBkYXRhYmFzZXMgKGUuZy4sIHRlbXBsYXRlMSkg
YW5kIGdldCBzdHVjayBhdCB0aGUgc2FtZSBpbmplY3Rpb24KcG9pbnQuIFRoaXMgY291bGQgbGVh
ZCB0byBhIHRpbWVvdXQgd2hlbiB0aGUgdGVzdCB3YWl0cyBmb3IgdGhlCmV4cGVjdGVkIHRhYmxl
J3MgYXV0b3ZhY3V1bSB0byBmaW5pc2guCgpUaGlzIGNvbW1pdCByZW1vdmVzIHRoZSB3YWl0IGZv
ciBhdXRvdmFjdXVtIGNvbXBsZXRpb24gZnJvbSB0aGlzCnNwZWNpZmljIHRlc3QgY2FzZS4gU2lu
Y2UgdGhlIHByaW1hcnkgZ29hbCBpcyB0byB2ZXJpZnkgdGhlCnByb3BhZ2F0aW9uIG9mIHBhcmFt
ZXRlciB1cGRhdGVz4oCUd2hpY2ggaXMgYWxyZWFkeSBjb25maXJtZWQgdmlhIGxvZwptZXNzYWdl
c+KAlHdhaXRpbmcgZm9yIHRoZSBlbnRpcmUgdmFjdXVtIHByb2Nlc3MgdG8gZmluaXNoIGlzCnVu
bmVjZXNzYXJ5IGFuZCBwcm9uZSB0byBpbnN0YWJpbGl0eSBpbiBjb25jdXJyZW50IHRlc3QgZW52
aXJvbm1lbnRzLgoKQXV0aG9yOglTYW1pIEltc2VpaCA8c2FtaW1zZWloQGdtYWlsLmNvbT4KRGlz
Y3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS9DQUE1UlowcytrWlpSTVNGNEhXN3RaOVcyalMx
bzRCK0ZnOGRyNWEtVDZtQU5YK21kUUFAbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMvdGVzdC9tb2R1
bGVzL3Rlc3RfYXV0b3ZhY3V1bS90LzAwMV9wYXJhbGxlbF9hdXRvdmFjdXVtLnBsIHwgMiAtLQog
MSBmaWxlIGNoYW5nZWQsIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvbW9k
dWxlcy90ZXN0X2F1dG92YWN1dW0vdC8wMDFfcGFyYWxsZWxfYXV0b3ZhY3V1bS5wbCBiL3NyYy90
ZXN0L21vZHVsZXMvdGVzdF9hdXRvdmFjdXVtL3QvMDAxX3BhcmFsbGVsX2F1dG92YWN1dW0ucGwK
aW5kZXggYzVhMmU3ODI0NmEuLmZjNGRkMjJmNWViIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9tb2R1
bGVzL3Rlc3RfYXV0b3ZhY3V1bS90LzAwMV9wYXJhbGxlbF9hdXRvdmFjdXVtLnBsCisrKyBiL3Ny
Yy90ZXN0L21vZHVsZXMvdGVzdF9hdXRvdmFjdXVtL3QvMDAxX3BhcmFsbGVsX2F1dG92YWN1dW0u
cGwKQEAgLTE3Nyw4ICsxNzcsNiBAQCAkbm9kZS0+d2FpdF9mb3JfbG9nKAogCXFyL3BhcmFsbGVs
IGF1dG92YWN1dW0gd29ya2VyIHVwZGF0ZWQgY29zdCBwYXJhbXM6IGNvc3RfbGltaXQ9NTAwLCBj
b3N0X2RlbGF5PTUsIGNvc3RfcGFnZV9taXNzPTEwLCBjb3N0X3BhZ2VfZGlydHk9MTAsIGNvc3Rf
cGFnZV9oaXQ9MTAvLAogCSRsb2dfb2Zmc2V0KTsKIAotd2FpdF9mb3JfYXV0b3ZhY3V1bV9jb21w
bGV0ZSgkbm9kZSwgJGF2X2NvdW50KTsKLQogIyBDbGVhbnVwCiAkbm9kZS0+c2FmZV9wc3FsKAog
CSdwb3N0Z3JlcycsIHFxewotLSAKMi41My4wCgo=
--000000000000a71997064ed9be47--