MIME-Version: 1.0
References: 
 <CALDaNm0Wg8XwfqUVnBSSahOtNxGDLNOW1_tc4ikZK=tGfqje-A@mail.gmail.com>
 <TYCPR01MB8373A9B6508E44E547A98EF5ED779@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <TYCPR01MB83734A7A0596AC7ADB0DCB51ED779@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <20211217.140309.1173685089580065514.horikyota.ntt@gmail.com>
 <TYCPR01MB83736371B66F90C71365ED11ED7B9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAJcOf-dmfinJDr=nOmjX1qNiU_mvW5tG3GyVwsQzRnUBb2ky0A@mail.gmail.com>
 <TYCPR01MB8373176545F7AE2CCDA23B81ED7D9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <OS3PR01MB6275734F2CCB71ACFE9074509E7D9@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <TYCPR01MB8373D519CDCA9AAFAF25B140ED7D9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <OS3PR01MB627528A542EFDBDED8DC7F289E7E9@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <TYCPR01MB8373E658CEE48FE05505A120ED529@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <TYCPR01MB6128626D92918A0C7ECC3257FB379@TYCPR01MB6128.jpnprd01.prod.outlook.com>
 <TYCPR01MB8373F9A42F49D77BDD1EF63CED379@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <TYCPR01MB83736F5F71CAB17BDD0F144EED3A9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAD21AoCn-03CSw_RmdGjopTAYnWGHRAE=-tbu2Zx5u8jSwbQvg@mail.gmail.com>
 <TYCPR01MB8373A3E1BE237BAF38185BF2ED3D9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <TYCPR01MB837371FCC441D2FE44D2242BED029@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAHut+Pv9gW6+xFH-iQ+=2A9o3-y+Mt-xE-7L+Q59Dy7_YX1Ebg@mail.gmail.com>
 <TYWPR01MB8362B30A904274A911C0B1CCED039@TYWPR01MB8362.jpnprd01.prod.outlook.com>
 <CAD21AoDs3Qur4vTNE3+mNdZ1jzk9ELFRAdHPLwVP1ZwK+XKXXA@mail.gmail.com>
 <TYCPR01MB837345FB72E3CE9C827AF42CED049@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAA4eK1JzUivU_nmSJ4g+26oeEua9QE9bXawk17Q7Kmd9XT8QbA@mail.gmail.com>
In-Reply-To: 
 <CAA4eK1JzUivU_nmSJ4g+26oeEua9QE9bXawk17Q7Kmd9XT8QbA@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri, 25 Mar 2022 14:36:28 +0900
Message-ID: 
 <CAD21AoDw4s=e7ES2y6+GW1A_aahzPCm4nk1qHw9Y+sqxQ5wmqQ@mail.gmail.com>
Subject: Re: Failed transaction statistics to measure the logical replication
 progress
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>,
 Peter Smith <smithpb2250@gmail.com>,
	"tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
 "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 "vignesh21@gmail.com" <vignesh21@gmail.com>,
	"houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 Greg Nancarrow <gregn4422@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoDw4s%3De7ES2y6%2BGW1A_aahzPCm4nk1qHw9Y%2BsqxQ5wmqQ%40mail.gmail.com>
Precedence: bulk

On Thu, Mar 24, 2022 at 12:30 PM Amit Kapila <amit.kapila16@gmail.com> wrot=
e:
>
> On Thu, Mar 3, 2022 at 8:58 AM osumi.takamichi@fujitsu.com
> <osumi.takamichi@fujitsu.com> wrote:
> >
>
> This patch introduces two new subscription statistics columns
> (apply_commit_count and apply_rollback_count) to the
> pg_stat_subscription_stats view for counting cumulative transactions
> commits/rollbacks for a particular subscription. Now, users can
> already see the total number of xacts committed/rolled back in a
> particular database via pg_stat_database, so this can be considered
> duplicate information.

Right.

> OTOH, some users might be interested in the
> stats for a subscription to know how many transactions are
> successfully applied during replication because the information in
> pg_stat_database also includes the operations that happened on the
> node.

I'm not sure how useful this information is in practice. What can we
use this information for?

IIRC the original purpose of this proposed feature is to provide a way
for the users to understand the size and count of the succeeded and
failed transactions. At some point, the patch includes the statistics
of only the counts of commits, rollbacks, and errors. If new
statistics also include the size, it might be useful to achieve the
original goal. But I=E2=80=99m concerned that adding only apply_commit_coun=
t
and apply_rollback_count ends up adding the duplicate statistics with
no concrete use cases.

> I am not sure if it is worth adding this additional information or how
> useful it will be for users. Does anyone else want to weigh in on
> this?
>
> If nobody else sees value in this then I feel it is better to mark
> this patch as Returned with feedback or Rejected. We can come back to
> it later if we see more demand for this.

Marking as Returned with feedback makes sense to me.

Regards,

--=20
Masahiko Sawada
EDB:  https://www.enterprisedb.com/