MIME-Version: 1.0
References: 
 <CAEoWx2m1Vo97Jg9=K7JAZ0xdkg5D=GkgOxZR1=EW7mUfy008fw@mail.gmail.com>
 <1D199FA4-C146-493B-B29A-A1BF1084DBBC@gmail.com>
 <5218079D-02C5-484C-922D-BCF908A55F91@gmail.com>
In-Reply-To: <5218079D-02C5-484C-922D-BCF908A55F91@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri, 6 Mar 2026 11:33:47 -0800
Message-ID: 
 <CAD21AoDwp1D6-xm3p28RvUJKHcZM+9YtjUzNk38kLitN_Nbq4Q@mail.gmail.com>
Subject: Re: Trivial Fix: use palloc_array/repalloc_array for BufFile file
 arrays
To: Chao Li <li.evan.chao@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoDwp1D6-xm3p28RvUJKHcZM%2B9YtjUzNk38kLitN_Nbq4Q%40mail.gmail.com>
Precedence: bulk

Hi,

On Tue, Mar 3, 2026 at 5:31=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wro=
te:
>
>
>
> > On Dec 25, 2025, at 11:34, Chao Li <li.evan.chao@gmail.com> wrote:
> >
> >
> >
> >> On Dec 25, 2025, at 11:12, Chao Li <li.evan.chao@gmail.com> wrote:
> >>
> >> Hi Hackers,
> >>
> >> I noticed this error while working on [1].
> >>
> >> In BufFile, the fields is claimed as an array:
> >> ```
> >> struct BufFile
> >> {
> >>    File *files; /* palloc'd array with numFiles entries */
> >> ```
> >>
> >> However, it=E2=80=99s allocated by palloc_object():
> >> ```
> >> file->files =3D palloc_object(File);
> >> ```
> >>
> >> And reallocated by repalloc():
> >> ```
> >>    file->files =3D (File *) repalloc(file->files,
> >>        (file->numFiles + 1) * sizeof(File));
> >> ```
> >>
> >> This trivial patch just changes to use palloc_array/repalloc_array, wh=
ich makes the intent clearer.
> >>
> >> Best regards,
> >> --
> >> Chao Li (Evan)
> >> HighGo Software Co., Ltd.
> >> https://www.highgo.com/
> >>
> >>
> >>
> >>
> >> <v1-0001-Use-palloc_array-repalloc_array-for-BufFile-file-.patch>
> >
> >
> > Sorry for missing the reference of [1]:
> >
> > [1] https://postgr.es/m/aUStrqoOCDRFAq1M@paquier.xyz
> >
> > Best regards,
> > --
> > Chao Li (Evan)
> > HighGo Software Co., Ltd.
> > https://www.highgo.com/
> >
>
> PFA v2:
>  * Rebased
>  * Updated the commit message

I've reviewed the v2 patch and here is a comment:

- file->files =3D palloc_object(File);
+ file->files =3D palloc_array(File, 1);

I'm not a fan of this change. This change looks like trying to
distinguish allocated memory by palloc_object() and palloc_array()
even though underlying memory is identical. I'm concerned about this
change creating unnecessary coding conventions.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com