MIME-Version: 1.0
References: <129bcfbf-47a6-e58a-190a-62fc21a17d03@migops.com>
 <3046422.1637337334@sss.pgh.pa.us> <a776f2d0-7ef8-f734-48b7-2aa383f41b2b@migops.com>
 <C7B3C461-2A44-4A73-B71F-933AD2DC3C6A@amazon.com> <3ea14054-af0c-3f21-0ced-04c896438bdc@dunslane.net>
 <08e09a01-5762-3b2e-1fa7-513478ab7394@migops.com> <e16e7928-a51e-47d9-94fa-f5b50cab58ce@darold.net>
 <MEAPR01MB3031B4F594E62343BF1F8EDBB684A@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <tencent_8C7890411E85257F512EFE4F0DD00EE29806@qq.com> <786b70c5-ee75-4450-84e7-936a20de63b9@gmail.com>
 <tencent_C8613B4D6335418C79F6961F457CF8583508@qq.com> <MEAPR01MB3031D75330A64DD25A5B8A04B685A@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <7aa9c67e-c423-43c4-89e8-4fbe8f5019d2@darold.net> <MEAPR01MB30311B76AFD06D3CAEAEF9C7B685A@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <3002ddbd-64b5-499e-b15c-e1c1720cc356@darold.net> <MEAPR01MB303185AAA6F5BF90759D5E86B685A@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <94634e38-7184-42a1-b9e1-7611076e1c08@darold.net> <MEAPR01MB303142AEB3F47886C171194EB682A@MEAPR01MB3031.ausprd01.prod.outlook.com>
In-Reply-To: <MEAPR01MB303142AEB3F47886C171194EB682A@MEAPR01MB3031.ausprd01.prod.outlook.com>
From: Yuefei Shi <shiyuefei1004@gmail.com>
Date: Fri, 9 Jan 2026 14:10:47 +0800
Message-ID: <CAD43U4WHJm=UkxbfhxQRxQRxtdtu7AGj77uO2fF78THQWCaYTg@mail.gmail.com>
Subject: Re: Pasword expiration warning
To: Japin Li <japinli@hotmail.com>
Cc: Gilles Darold <gilles@darold.net>, songjinzhou <tsinghualucky912@foxmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>, 
	"Bossart, Nathan" <bossartn@amazon.com>, Tom Lane <tgl@sss.pgh.pa.us>, 
	liu xiaohui <liuxh.zj.cn@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000a2aa580647ee639a"
Archived-At: <https://www.postgresql.org/message-id/CAD43U4WHJm%3DUkxbfhxQRxQRxtdtu7AGj77uO2fF78THQWCaYTg%40mail.gmail.com>
Precedence: bulk

--000000000000a2aa580647ee639a
Content-Type: text/plain; charset="UTF-8"

A few review comments for V8.

===
1.

+		if (password_expire_warning > 0 && vuntil < PG_INT64_MAX)
+		{
+			TimestampTz result = (vuntil - now) / USECS_PER_SEC; /* in seconds */
+
+			if (result <= (TimestampTz) password_expire_warning)
+				MyClientConnectionInfo.warning_message =
+						psprintf("your password will expire in %d day(s)", (int)
(result / 86400));
+		}

Please consider localization of the warning message.


2. typo fix

a. `Controls how many time ...` should be `Controls how much time ...`.

b. `Sets how many time before password expire to emit ...` should be
`Sets how much time before password expires to emit ...`

--000000000000a2aa580647ee639a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">A few review comments for V8.<div><br></div><div>=3D=3D=3D=
</div><div>1.</div><div><pre style=3D"color:rgb(0,0,0)">+		if (password_exp=
ire_warning &gt; 0 &amp;&amp; vuntil &lt; PG_INT64_MAX)
+		{
+			TimestampTz result =3D (vuntil - now) / USECS_PER_SEC; /* in seconds */
+
+			if (result &lt;=3D (TimestampTz) password_expire_warning)
+				MyClientConnectionInfo.warning_message =3D
+						psprintf(&quot;your password will expire in %d day(s)&quot;, (int) (=
result / 86400));
+		}</pre><pre style=3D"color:rgb(0,0,0)">Please consider localization of t=
he warning message.</pre><pre style=3D"color:rgb(0,0,0)"><br></pre><pre sty=
le=3D"color:rgb(0,0,0)">2. typo fix</pre><pre style=3D"color:rgb(0,0,0)">a.=
 `Controls how many time ...` should be `Controls how much time ...`.</pre>=
<pre style=3D"color:rgb(0,0,0)">b. `Sets how many time before password expi=
re to emit ...` should be `Sets how much time before password expires to em=
it ...`

</pre><pre style=3D"color:rgb(0,0,0)"><br></pre></div></div>

--000000000000a2aa580647ee639a--