MIME-Version: 1.0
References: <202603201311.yhtqmvektawm@alvherre.pgsql>
 <bf49721a-a56f-4bdc-ac48-5d4dc1d01805@dunslane.net>
 <8ec9b67d-939e-4b22-8d56-a5129f92d32d@app.fastmail.com>
 <CAN4CZFNYM5jNA_gLu9miAXg_7c8Z2zf-ePc+0rzidAV3CBs=cw@mail.gmail.com>
 <555cdee4-c024-4872-9d96-82ef4216239c@dunslane.net>
 <SY7PR01MB10921A6E1E08A48F3426FE529B651A@SY7PR01MB10921.ausprd01.prod.outlook.com>
 <CAKFQuwYcppypeGBwa7ZbDAfoUXSv+kLhJuAXsdwBmKrvy8wDFw@mail.gmail.com>
 <a533fb1b-0f2c-4fc9-ab3b-6fb5ddac1800@dunslane.net>
 <a1c4dd3e-6694-4b7b-8432-f3b584735ff3@dunslane.net>
 <ptyiexyhmtxf4lm524s7o7w64r26ra237uusv4tjav4yhpmeoo@vfwwllz7tivb>
 <ocjzhjrnhagzimxo3jz42e3liybwed5nijnw7uadm5yyjurlux@kt3q6szjapre>
 <5c67dc79-909a-4e17-8606-6686667da6c6@dunslane.net>
 <a947587c-8538-4527-9146-ab78450c49b0@dunslane.net>
In-Reply-To: <a947587c-8538-4527-9146-ab78450c49b0@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
Date: Wed, 29 Apr 2026 11:35:07 -0400
Message-ID: 
 <CAD5tBcJMgM4oyvij7pRYxs+Fj0FqVEtHdofS1=YgiohrjZefng@mail.gmail.com>
Subject: Re: pg_get__*_ddl consolidation
To: Andres Freund <andres@anarazel.de>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 Japin Li <japinli@hotmail.com>,
	Zsolt Parragi <zsolt.parragi@percona.com>, Euler Taveira <euler@eulerto.com>,
	=?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000051de6f06509b18c9"
Archived-At: 
 <https://www.postgresql.org/message-id/CAD5tBcJMgM4oyvij7pRYxs%2BFj0FqVEtHdofS1%3DYgiohrjZefng%40mail.gmail.com>
Precedence: bulk

--00000000000051de6f06509b18c9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 26, 2026 at 10:07=E2=80=AFAM Andrew Dunstan <andrew@dunslane.ne=
t> wrote:

>
> On 2026-04-06 Mo 7:39 AM, Andrew Dunstan wrote:
> >
> > On 2026-04-05 Su 4:03 PM, Andres Freund wrote:
> >
> >
> >>> But do we really have to create a new database and a new tablespace
> >>> for these?
> >>> Database and tablespace creations are quite heavyweight operations.
> >>>
> >>> We already have an existing tablespace and an existing database as
> >>> part of the
> >>> regression tests. Couldn't you make do with those?
> >> Didn't do anything about that.
> >>
> >
> > Well, the trouble is that the database test runs a bunch of alter and
> > revoke statements on the created database, that we probably don't want
> > to persist on the existing regression database. I could see an
> > argument for converting this to a TAP test that would only be run
> > once, given our current very profligate running of the core regression
> > suite. That goes doubly for the tablespace test, which could also
> > probably use ALTER TABLESPACE instead of creating a bunch of
> > tablespaces and then dropping them.
> >
> >
> >
>
> Here's a patch that converts all these into a single TAP test, and
> reduces the number of tablespace creations.
>
>
>
>
pushed.

cheers

andrew

--00000000000051de6f06509b18c9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Apr 26,=
 2026 at 10:07=E2=80=AFAM Andrew Dunstan &lt;<a href=3D"mailto:andrew@dunsl=
ane.net">andrew@dunslane.net</a>&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex"><br>
On 2026-04-06 Mo 7:39 AM, Andrew Dunstan wrote:<br>
&gt;<br>
&gt; On 2026-04-05 Su 4:03 PM, Andres Freund wrote:<br>
&gt;<br>
&gt;<br>
&gt;&gt;&gt; But do we really have to create a new database and a new table=
space <br>
&gt;&gt;&gt; for these?<br>
&gt;&gt;&gt; Database and tablespace creations are quite heavyweight operat=
ions.<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; We already have an existing tablespace and an existing databas=
e as <br>
&gt;&gt;&gt; part of the<br>
&gt;&gt;&gt; regression tests. Couldn&#39;t you make do with those?<br>
&gt;&gt; Didn&#39;t do anything about that.<br>
&gt;&gt;<br>
&gt;<br>
&gt; Well, the trouble is that the database test runs a bunch of alter and =
<br>
&gt; revoke statements on the created database, that we probably don&#39;t =
want <br>
&gt; to persist on the existing regression database. I could see an <br>
&gt; argument for converting this to a TAP test that would only be run <br>
&gt; once, given our current very profligate running of the core regression=
 <br>
&gt; suite. That goes doubly for the tablespace test, which could also <br>
&gt; probably use ALTER TABLESPACE instead of creating a bunch of <br>
&gt; tablespaces and then dropping them.<br>
&gt;<br>
&gt;<br>
&gt;<br>
<br>
Here&#39;s a patch that converts all these into a single TAP test, and <br>
reduces the number of tablespace creations.<br>
<br>
<br><br></blockquote><div><br></div><div>pushed.</div><div><br></div><div>c=
heers</div><div><br></div><div>andrew=C2=A0</div></div></div>

--00000000000051de6f06509b18c9--