MIME-Version: 1.0
References: 
 <CAAJ_b94hkpAJ-Q8FKjGgpbRTmmXOd-agKo1Eii4yOH2N++N36Q@mail.gmail.com>
 <401bf08a-c8f1-48e2-9a30-78deaa9fa7c5@dunslane.net>
 <CAAJ_b94jrauD_FAegTnODszjnF0O+ZFLtXhXBSPhyThRUqSNVg@mail.gmail.com>
 <CAAJ_b94fiDcsN6k27hV9772kNjEbtZG5ESQvXL1KQoUcRcxrGA@mail.gmail.com>
 <CAAJ_b95JZ7SunSeCgxB3+pC+38B5smD9y4uubAGmZTNo0xtHog@mail.gmail.com>
 <CAN4CZFMn_9wgEG0q-9CCXynZ85FzVFoyVU=okWESA42U542ajw@mail.gmail.com>
 <CAAJ_b95Oj6Kb6YGsV42Gqy=N7GuOX+FMmEtUbS7NC6BvARN2mQ@mail.gmail.com>
 <CAAJ_b96AG+p+n+DZPc4isTDR_rD_-dYfVJGXhG0k2CG+kdzU9g@mail.gmail.com>
 <9a2be101-!42c9-40dd-9860-aa12f06bf0e0@dunslane.net>
 <2178517.1774064942@sss.pgh.pa.us>
 <ab45bcgOw9Flrj3K@paquier.xyz> <2197317.1774074840@sss.pgh.pa.us>
 <1663e08f-2711-42ed-a3c7-08632c852911@dunslane.net>
 <2250061.1774104346@sss.pgh.pa.us>
 <2555285.1774131847@sss.pgh.pa.us> <2609460.1774153487@sss.pgh.pa.us>
 <CAD5tBcLVWKnph3iB-VPuPKR0dCckOJRFZW2-4H7HTTmhw8-vOg@mail.gmail.com>
 <2790913.1774200584@sss.pgh.pa.us> <2880042.1774203473@sss.pgh.pa.us>
In-Reply-To: <2880042.1774203473@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
Date: Sun, 22 Mar 2026 17:19:09 -0400
Message-ID: 
 <CAD5tBcLsYDz+Nzx8MryjxiKaN3fGKd4ZgXuN1Jn=CYxw9dh+AA@mail.gmail.com>
Subject: Re: pg_waldump: support decoding of WAL inside tarfile
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>,
	Zsolt Parragi <zsolt.parragi@percona.com>,
 Robert Haas <robertmhaas@gmail.com>,
	Chao Li <li.evan.chao@gmail.com>,
 Jakub Wartak <jakub.wartak@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000b3f990064da378b4"
Archived-At: 
 <https://www.postgresql.org/message-id/CAD5tBcLsYDz%2BNzx8MryjxiKaN3fGKd4ZgXuN1Jn%3DCYxw9dh%2BAA%40mail.gmail.com>
Precedence: bulk

--000000000000b3f990064da378b4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 22, 2026 at 2:17=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> I wrote:
> > ... We can make this function far simpler
> > and more obviously correct if we just accept that we'll read a
> > WAL file completely before spilling it.  See my proposed
> > alternative to 0004, attached.
>
> Actually, we can make that better yet by not expecting
> get_archive_wal_entry to clean up after init_archive's
> failure to free all irrelevant hashtable entries.
> Better version attached.
>
>
>

Yeah, this looks good.  I know we also still need to do something about
rmtree trying to remove files we haven't closed. But what we have so far in
this set LGTM. If you want to push this I'm good, otherwise I'll look at it
tomorrow or Tuesday.

cheers

andrew

--000000000000b3f990064da378b4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Mar 22,=
 2026 at 2:17=E2=80=AFPM Tom Lane &lt;<a href=3D"mailto:tgl@sss.pgh.pa.us">=
tgl@sss.pgh.pa.us</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p=
adding-left:1ex">I wrote:<br>
&gt; ... We can make this function far simpler<br>
&gt; and more obviously correct if we just accept that we&#39;ll read a<br>
&gt; WAL file completely before spilling it.=C2=A0 See my proposed<br>
&gt; alternative to 0004, attached.<br>
<br>
Actually, we can make that better yet by not expecting<br>
get_archive_wal_entry to clean up after init_archive&#39;s<br>
failure to free all irrelevant hashtable entries.<br>
Better version attached.<br>
<br><br></blockquote><div><br></div><div><br></div><div>Yeah, this looks go=
od.=C2=A0 I know we also still need to do something about rmtree trying to =
remove files we haven&#39;t closed. But what we have so far in this set LGT=
M. If you want to push this I&#39;m good, otherwise I&#39;ll look at it tom=
orrow or Tuesday.</div><div><br></div><div>cheers</div><div><br></div><div>=
andrew</div></div></div>

--000000000000b3f990064da378b4--