MIME-Version: 1.0
References: <aRrHBj7I4CeV21dj@paquier.xyz>
 <CACJufxGGzkb58BU+YyTa9cBAawhybwk2cPFZ1XupS-8xuAzN9A@mail.gmail.com>
 <aRwGeN7o22HJclg5@paquier.xyz>
 <CADkLM=czQ0UUyBn3AiHZfJJWRwXH5e2xn056yG0mpuXpW09RSw@mail.gmail.com>
 <CACJufxHVKiVEvCsc11oxOM=0GgjqChFwi-ii4RJuw95ZFB_fHQ@mail.gmail.com>
 <CADkLM=eRop0t==hg0TU3KuDH6DgnUxQ6vZxV9th=6vW1JG36MQ@mail.gmail.com>
 <CACJufxGgEnOzFq0HjmkKBTnEUgToGFC0g0A4wPWoJMzOuoWUhw@mail.gmail.com>
 <CADkLM=crdyK3w7-EDEdDfXHGidxm2ms+bQYNFOZUD4eOLuLXEQ@mail.gmail.com>
 <aSVas5CIr1mvR2VK@paquier.xyz>
 <EFE9F959-01C6-45D3-9EEE-F06C766EF3CA@gmail.com>
 <aSV_kS5_pL4DYw1J@paquier.xyz>
In-Reply-To: <aSV_kS5_pL4DYw1J@paquier.xyz>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Tue, 25 Nov 2025 23:32:49 -0600
Message-ID: 
 <CADkLM=cmTTq-+ZLi+wz5NP6_vccDMqhvMAqJ58PBz6RgMJWttQ@mail.gmail.com>
Subject: Re: Extended Statistics set/restore/clear functions.
To: Michael Paquier <michael@paquier.xyz>
Cc: Chao Li <li.evan.chao@gmail.com>, jian he <jian.universality@gmail.com>,
	Tomas Vondra <tomas@vondra.me>, pgsql-hackers@lists.postgresql.org,
 tgl@sss.pgh.pa.us
Content-Type: multipart/alternative; boundary="000000000000d22c27064478ba82"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3DcmTTq-%2BZLi%2Bwz5NP6_vccDMqhvMAqJ58PBz6RgMJWttQ%40mail.gmail.com>
Precedence: bulk

--000000000000d22c27064478ba82
Content-Type: text/plain; charset="UTF-8"

> Finally, the consts are non-appealing for me for functions that are
> internally used in these files.


I'm curious why you find them non-appealing for non-exposed functions, if
you have time to elaborate.


>   And forgot one:
> valid_subsequent_attnum()'s duplication is actually adapted IMO, the
> argument lists could have different assumptions depending on the type
> of extended stats we are dealing with.


Yeah, I saw that, reviewing the diff-of-diffs just now.

--000000000000d22c27064478ba82
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div>=C2=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">Finally, the con=
sts are non-appealing for me for functions that are<br>
internally used in these files.</blockquote><div><br></div><div>I&#39;m cur=
ious why you find them non-appealing for non-exposed functions, if you have=
 time to elaborate.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p=
adding-left:1ex">=C2=A0 And forgot one:<br>
valid_subsequent_attnum()&#39;s duplication is actually adapted IMO, the<br=
>
argument lists could have different assumptions depending on the type<br>
of extended stats we are dealing with.</blockquote><div><br></div><div>Yeah=
, I saw that, reviewing the diff-of-diffs just now.</div></div></div>

--000000000000d22c27064478ba82--