MIME-Version: 1.0
References: 
 <CADkLM=cz=bEvRRj0mSffMrVW56M=1O-KqavCZv19on-MQrkZwg@mail.gmail.com>
 <aateiqvWO53UjoNI@nathan> <aathGcXAIpiUSP_s@nathan>
 <CAA5RZ0vCuDDd6-H00aabjLri0yO_AMJQ4Lb4017pepqU5WNyFg@mail.gmail.com>
 <aa7sZcuRrlkeVJGX@nathan>
 <CADkLM=eUR5co+o3PU8M=Fo8rRynj4xf=PFtt2KisD96bdrPEOg@mail.gmail.com>
 <CAA5RZ0s674FM8vcEqr+DUVjWOpYSPS-rG8uANdJKEnSyo+tObA@mail.gmail.com>
 <CADkLM=cYLk7bi3QVMBGWsFEzNfpqyV1Es3tWCwfERS88MdULWQ@mail.gmail.com>
 <aa81xZp421DSkHiW@nathan>
 <CADkLM=dhYeJtP+8h8k4ULCu-P1pNHmFyDFBm8B0WU6A6i+NgPQ@mail.gmail.com>
 <abBIu0lYyFYAq5fx@nathan>
In-Reply-To: <abBIu0lYyFYAq5fx@nathan>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Tue, 10 Mar 2026 12:42:02 -0400
Message-ID: 
 <CADkLM=d-=_hbOUsMc4u_ScLmSNox6EbzFCmaMn7MTh6f_SLU_A@mail.gmail.com>
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000a17821064cae336c"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3Dd-%3D_hbOUsMc4u_ScLmSNox6EbzFCmaMn7MTh6f_SLU_A%40mail.gmail.com>
Precedence: bulk

--000000000000a17821064cae336c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 10, 2026 at 12:37=E2=80=AFPM Nathan Bossart <nathandbossart@gma=
il.com>
wrote:

> On Mon, Mar 09, 2026 at 06:42:46PM -0400, Corey Huinker wrote:
> > If you want 0003 split into two (one for pg_stats_ext and one for
> > pg_stats_ext_exprs) I can do that, but they felt like a package deal to
> me.
>
> Sorry to throw a curveball here, but I think the best way to structure th=
is
> patch set is as follows:
>
> * 0001: Just the test changes (e.g., replacing * with column lists).  By
> doing that first, the actual functionality changes in 0002 will be easier
> to see.
>

Makes sense.


>
> * 0002: Adding columns to the all the views (this one will do a catalog
> bump).  If we need to make a couple of test adjustments to verify the OID=
s
> or attribute IDs, that's fine, but those can be pretty minimal.
>

So all three views in one go. +1


>
> * 0003: Associated pg_dump changes.
>

On it.

--000000000000a17821064cae336c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Mar 10,=
 2026 at 12:37=E2=80=AFPM Nathan Bossart &lt;<a href=3D"mailto:nathandbossa=
rt@gmail.com">nathandbossart@gmail.com</a>&gt; wrote:<br></div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex">On Mon, Mar 09, 2026 at 06:42:46PM -0=
400, Corey Huinker wrote:<br>
&gt; If you want 0003 split into two (one for pg_stats_ext and one for<br>
&gt; pg_stats_ext_exprs) I can do that, but they felt like a package deal t=
o me.<br>
<br>
Sorry to throw a curveball here, but I think the best way to structure this=
<br>
patch set is as follows:<br>
<br>
* 0001: Just the test changes (e.g., replacing * with column lists).=C2=A0 =
By<br>
doing that first, the actual functionality changes in 0002 will be easier<b=
r>
to see.<br></blockquote><div><br></div><div>Makes sense.</div><div>=C2=A0</=
div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
* 0002: Adding columns to the all the views (this one will do a catalog<br>
bump).=C2=A0 If we need to make a couple of test adjustments to verify the =
OIDs<br>
or attribute IDs, that&#39;s fine, but those can be pretty minimal.<br></bl=
ockquote><div><br></div><div>So all three views in one go.=C2=A0+1</div><di=
v>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
* 0003: Associated pg_dump changes.<br></blockquote><div><br></div>On it.<d=
iv><br></div><div>=C2=A0</div></div></div>

--000000000000a17821064cae336c--