MIME-Version: 1.0
References: 
 <CA+TgmoYqMtWb4zLUkT98oFnEkJ=Wz0Pw-ggDJrp9wnSXPzUaeQ@mail.gmail.com>
 <CAPmGK161TJ4G01eptv3sBqgxa4SNHDE9VRqoC6jy5Y6G3D8yDw@mail.gmail.com>
 <CA+TgmoZpwfTGqqp=0efV99e_BMYWdLFq2XKRWVSDcukifkZMeA@mail.gmail.com>
 <CADkLM=dxe8NbQu4RNi2OFXpaRKdpS0-CHGm6Mqtf_rW155BM4g@mail.gmail.com>
 <CADkLM=cV=uezAKyZdyyxnZOBRhGLUSbeYfDj5_jbDCLP9LP24Q@mail.gmail.com>
 <CA+TgmoaVcgZJpwxyi7HEfNMJhmm7BXkTQ468jvxkW2QzQZRkvg@mail.gmail.com>
 <CADkLM=dy18dDJ+j3-_Ofn11vt5J7zF33oTWnE6N=ePc83uS91A@mail.gmail.com>
 <CAPmGK15MfVT2H+PUvA_nAJvySGr_pAVkVx3KcnVXWGO36acWLA@mail.gmail.com>
 <CADkLM=dr5bfB8YN-bV1U0NDvyVO7a6uuz0BsAi89a1Md4A==8g@mail.gmail.com>
 <CAPmGK14P2GRe78hp6fZ3vExU_9RRDjMsYVOx7AALvUQ-hKTUiQ@mail.gmail.com>
 <CADkLM=cL9ZGvO-72QWyXA5Wqv-4P3T1fp+VFJy5e6k3Hf=POMw@mail.gmail.com>
 <CA+TgmoZdTVeXRQo__cEr_1y+mUO9nubOX=6PEfw7Cr0UfZQn6w@mail.gmail.com>
 <CADkLM=fe=ycPdwT2wE_iYwK8e8viMbWvwWhXR9vDe+55KKF-KQ@mail.gmail.com>
 <CADkLM=dWJaw04u9FU=WkykOy7bu7B5eKmoDkfVz6JXh7mdemkw@mail.gmail.com>
 <CA+TgmoY3a_S0munZ0wg4hQpMKVMyM_jpi6aGhFR0gAm1jLukag@mail.gmail.com>
 <CADkLM=cdKjgphHpFW8kKukHF+DVYKogHcqLXO=BA8MGfiRFqQA@mail.gmail.com>
 <CADkLM=c9BEuA9vPjE9Wco6+Lz-HSnnmBZrFhi=-yNi0K8tmZug@mail.gmail.com>
 <CAPmGK17W1sUB3JnkRoBpgO0_iSH5HRcc0_nxk8Us4KYsQhuQxg@mail.gmail.com>
 <CA+TgmoZd5MDhcx6uav6MWxhM42yWcfaRAHYKNtNkuog=yrKAgw@mail.gmail.com>
 <CADkLM=f_c7Xoq-bSzw28LgvxPa+OQ3rVow=xwkTyjz1J0=pMdw@mail.gmail.com>
 <CAPmGK14dY-Cex2rc08TinQjHR4Q1L6nqPBfdEBRZusP7n_TZSA@mail.gmail.com>
 <CADkLM=enKc-3-uTjUSXXhoRhSKDHVdb_ate+S2dtkEcscW5bvA@mail.gmail.com>
In-Reply-To: 
 <CADkLM=enKc-3-uTjUSXXhoRhSKDHVdb_ate+S2dtkEcscW5bvA@mail.gmail.com>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Tue, 30 Jun 2026 11:21:08 -0500
Message-ID: 
 <CADkLM=d9q3mMPxMNuO5arj5ipY-3cFajuQWq1h-foBXiaUGmqg@mail.gmail.com>
Subject: Re: use of SPI by postgresImportForeignStatistics
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000150b1006557af7fc"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3Dd9q3mMPxMNuO5arj5ipY-3cFajuQWq1h-foBXiaUGmqg%40mail.gmail.com>
Precedence: bulk

--000000000000150b1006557af7fc
Content-Type: text/plain; charset="UTF-8"

>
>
> My initial concern was that this would bloat up postgres_fdw with type
> conversion code, but the patch shows that it isn't that bad.
>

One additional thought - in an offline conversation I had with Robert Haas,
he had taken the position that any FDW was likely pulling values across a
wire protocol and then synthesizing postgres-looking statistics from that,
so going with cstring inputs was fine, possibly preferable. I'm
highlighting that we're now passing in NullableDatums in case he wanted to
object to that change.

--000000000000150b1006557af7fc
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">=
<div class=3D"gmail_quote"><br><div>My initial concern was that this would =
bloat up postgres_fdw with type conversion code, but the patch shows that i=
t isn&#39;t that bad.</div></div></div></div></blockquote><div><br></div><d=
iv>One additional thought - in an offline conversation I had with Robert Ha=
as, he had taken the position that any FDW was likely pulling values across=
 a wire protocol and then synthesizing postgres-looking statistics from tha=
t, so going with cstring inputs was fine, possibly preferable. I&#39;m high=
lighting that we&#39;re now passing in NullableDatums in case he wanted to =
object to that change.</div></div></div>

--000000000000150b1006557af7fc--