MIME-Version: 1.0
References: 
 <CADkLM=coCVy92QkVUUTLdo5eO2bMDtwMrzRn_8miAhX+uPaqXg@mail.gmail.com>
 <CAA5RZ0vY5jHXQEOyUdjW7tPrXb9TY_bdr8ZpCRuALj1zU5DD_w@mail.gmail.com>
 <CADkLM=d8vuFzQSrV+8MfviK3-TyG8r45yEbnOUd6VJGEoyNmHA@mail.gmail.com>
 <CAA5RZ0tSYjO4Frt-SkpV1kmXn4jYTdVP-1XEMtFF2yJ9B4scDg@mail.gmail.com>
In-Reply-To: 
 <CAA5RZ0tSYjO4Frt-SkpV1kmXn4jYTdVP-1XEMtFF2yJ9B4scDg@mail.gmail.com>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Thu, 5 Mar 2026 15:40:16 -0500
Message-ID: 
 <CADkLM=d=udo8pxPeLQA6Z2YKLMgTvJM_Uh2mYtsCE38fJ8xodw@mail.gmail.com>
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
To: Sami Imseih <samimseih@gmail.com>
Cc: nathandbossart@gmail.com, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000005bdc15064c4cf22f"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3Dd%3Dudo8pxPeLQA6Z2YKLMgTvJM_Uh2mYtsCE38fJ8xodw%40mail.gmail.com>
Precedence: bulk

--0000000000005bdc15064c4cf22f
Content-Type: text/plain; charset="UTF-8"

>
> >> "pg_stats.relation" with a description of "Name of table or index" is
> >> more appropriate.
> >> It is a change that we can possibly make in a major version. Looked
> >> through the archives,
> >> and did not see this being reported/discussed.
> >
> >
> > I don't see it changing in any version, minor or major.
>
> This could be a separate discussion as it's not the fault of this patch,
> but clearly "tablename" is not correct here.
>

Certainly up for debate, but changing it would break existing scripts, and
that's generally a non-starter around here.


> I noticed that you changed the tests to selecting individual columns. I am
> not clear as to why this is better?
>
> -SELECT *
> +SELECT schemaname, tablename, attname, attnum, inherited, null_frac,
> avg_width,
> +    n_distinct, most_common_vals, most_common_freqs, histogram_bounds,
> +    correlation, most_common_elems, most_common_elem_freqs,
> +    elem_count_histogram, range_length_histogram, range_empty_frac,
> +    range_bounds_histogram
>

Well, the oid is now a part of the view, and that's not stable from one
regression run to the next, so we have to exclude it.

--0000000000005bdc15064c4cf22f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">&gt;&gt; &quot;pg_stats.relation&q=
uot; with a description of &quot;Name of table or index&quot; is<br>
&gt;&gt; more appropriate.<br>
&gt;&gt; It is a change that we can possibly make in a major version. Looke=
d<br>
&gt;&gt; through the archives,<br>
&gt;&gt; and did not see this being reported/discussed.<br>
&gt;<br>
&gt;<br>
&gt; I don&#39;t see it changing in any version, minor or major.<br>
<br>
This could be a separate discussion as it&#39;s not the fault of this patch=
,<br>
but clearly &quot;tablename&quot; is not correct here.<br></blockquote><div=
><br></div><div>Certainly up for debate, but changing it would break existi=
ng scripts, and that&#39;s generally a non-starter around here.</div><div><=
/div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I n=
oticed that you changed the tests to selecting individual columns. I am<br>
not clear as to why this is better?<br>
<br>
-SELECT *<br>
+SELECT schemaname, tablename, attname, attnum, inherited, null_frac, avg_w=
idth,<br>
+=C2=A0 =C2=A0 n_distinct, most_common_vals, most_common_freqs, histogram_b=
ounds,<br>
+=C2=A0 =C2=A0 correlation, most_common_elems, most_common_elem_freqs,<br>
+=C2=A0 =C2=A0 elem_count_histogram, range_length_histogram, range_empty_fr=
ac,<br>
+=C2=A0 =C2=A0 range_bounds_histogram<br></blockquote><div><br></div><div>W=
ell, the oid is now a part of the view, and that&#39;s not stable from one =
regression run to the next, so we have to exclude it.</div></div></div>

--0000000000005bdc15064c4cf22f--