MIME-Version: 1.0
References: 
 <CADkLM=fv1JfY4Ufa-jcwwNbjQixNViskQ8jZu3Tz_p656i_4hQ@mail.gmail.com>
 <CAMsGm5dpfm2PHL8XZvC-JSd+UPkgx3rpReUA=G=4+rUCH+Ntcw@mail.gmail.com>
 <CADkLM=eD_S8mGhPfu5+hXXvXgR0-cxGpGd9dgPzD+nCuO7HFaQ@mail.gmail.com>
 <CACJufxHCMzrHOW=wRe8L30rMhB3sjwAv1LE928Fa7sxMu1Tx-g@mail.gmail.com>
 <04afcd1f-ed7d-4c0a-add1-50e3719ccbf9@postgresfriends.org>
 <CACJufxGRAnwJzu7nMq4ZP=yqa1Sz=qR+mR1TmY0aCDjJoJRRtg@mail.gmail.com>
 <762ae707-7fdc-43d8-a77a-3a10d12ce21d@postgresfriends.org>
 <CACJufxFy+DFpJ2e-czyCTAgSJXNFaQGWFKA4mjbW-LAMGc1YBA@mail.gmail.com>
 <CADkLM=f1Jv81=s5Ckazx3zZq=M5KoBJMJkOZux_-L+gezODCEQ@mail.gmail.com>
 <CACJufxGw_OY7K3rfG4kDb902O2guhT-wgTjTJQ=pWeVWRTHpHQ@mail.gmail.com>
 <CADkLM=cFSg3+6Sk00dLAF7Q7jnrKBk6+N5gRxT5BCxRvaGtR-g@mail.gmail.com>
 <CACJufxE_aO5FtBGwhDym-Fwe7k8oJY7a8jcYDx77=t3maPvG0g@mail.gmail.com>
 <CADkLM=chahh6ddZFjLL6AUdqzL_Px0raTu-5Jzn2WN8yELtmJw@mail.gmail.com>
 <CACJufxE053=bO3pDUpGba6Yz3VGpU_XCbg4HO6Rew5EJ7k7VnQ@mail.gmail.com>
 <CACJufxF--5d=fmoRBHfqJE9Vy38dCURNKYOKKpujRCnoTEQ7nQ@mail.gmail.com>
 <CACJufxHpMJn22Nu_wmG6eV_S8SAM6KM+GhMO7GuzVb=d9q5C4A@mail.gmail.com>
 <CACJufxHM2e3DQmbRdDZvWyG3ZCLyOg6XFifvOz_TGy1tGw7NHw@mail.gmail.com>
 <CADkLM=daTLuRcwzc6Egtwvh4XYgtABWuMBVnEznd-dXqmXfzUw@mail.gmail.com>
 <CACJufxEcrrcaeFW+zYsjgb6r+ijzwszyxeHk3wxGY+3idiA2ZA@mail.gmail.com>
 <CADkLM=ehavqENDBCcYQufPFKboV90+o_uFdhcrh=Ymq_TNqo=A@mail.gmail.com>
 <CADkLM=ecTybe9Z9TSRD-NKZ=-V4DuGVRtXZGO6+F7=m3Gg9GGQ@mail.gmail.com>
 <CACJufxH5OSeY0-qirksn8S2FUycxON-O=iwc0-Nne1MTAguGhQ@mail.gmail.com>
 <CADkLM=eFasBpS1cqf67TpKGbKoUSy00FuT05Yz4RpXQBpqktuw@mail.gmail.com>
 <CACJufxHrE0s7G0xg1frWo2+tFLTLaikKCObixH-4p9zMYKtHFw@mail.gmail.com>
 <CACJufxFEzD3mqc+MDpgzvdt+4Azbn2pF6TWW=dSCqSK7OHoL6A@mail.gmail.com>
 <CALdSSPjd2fJHw8TrugumZSQwJ8VmSVn55OfQ+Wuogaq0ss=HGQ@mail.gmail.com>
 <CACJufxFzqAshLFw-xTqpz3Mu=6nMLnPiD8bBhbqX6KcFPVjEHw@mail.gmail.com>
 <CAAJ_b95nmvAYhxt2NwRAdGtvR-6STbiaFguMSLh3PmjUVE7rdg@mail.gmail.com>
 <CACJufxHw9Y3fvh+rZj4ukLo=v54Dpafzk7Xvee_wi9zFZ6pOfg@mail.gmail.com>
 <CAAJ_b97+iUAQRoOpogZHRHdr+YQug0TaEeAp9GnT5Bnp8-6oMg@mail.gmail.com>
 <CACJufxHGxB7KPAStUHZcWhFEDXsnU06qOugh60X4hHG6J-xoUA@mail.gmail.com>
 <CADkLM=f0xruKRH+6XvCsM1EVic9y4BL4AFo3VUfvRLdu-Qp5Gg@mail.gmail.com>
 <CADkLM=e4y2bLv-6_JY5c6vC9QtweW9VfxVmVJFpcriy8Rs23TA@mail.gmail.com>
 <CACJufxGO_qmyGjBvkwhCZzm6bWiqj8iyd1dGbL+_guok6yPMCQ@mail.gmail.com>
 <CADkLM=cZ7N+f4Bj-8MiccFcTASjBB2r1_s3BD9OFbbQOwK01cg@mail.gmail.com>
 <CACJufxE7yoH42juViFvYuCQMPwXMWxDVwiugs-BW+N4oUXB=1w@mail.gmail.com>
In-Reply-To: 
 <CACJufxE7yoH42juViFvYuCQMPwXMWxDVwiugs-BW+N4oUXB=1w@mail.gmail.com>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Fri, 13 Mar 2026 02:10:13 -0400
Message-ID: 
 <CADkLM=dFZ8-mBJDkiZZ4JadnJy8zLExUoo_b1FOs2Ozrtge=gQ@mail.gmail.com>
Subject: Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User
 Functions
To: jian he <jian.universality@gmail.com>
Cc: Amul Sul <sulamul@gmail.com>, Kirill Reshke <reshkekirill@gmail.com>,
	Vik Fearing <vik@postgresfriends.org>,
 Isaac Morland <isaac.morland@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000009b9911064ce1b9e3"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3DdFZ8-mBJDkiZZ4JadnJy8zLExUoo_b1FOs2Ozrtge%3DgQ%40mail.gmail.com>
Precedence: bulk

--0000000000009b9911064ce1b9e3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

>
>
> To do that, we need to refactor the RangeVarGetRelidExtended function
> to make it error-safe.
> We can also change it as:
>

Ok, thanks.

Hmm, seems we've got a new compile error:


FAILED: [code=3D1] src/backend/postgres_lib.a.p/executor_execExpr.c.o
cc -Isrc/backend/postgres_lib.a.p -Isrc/include -I../src/include
-I/usr/include/libxml2 -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D6=
4
-Wall -Winvalid-pch -O2 -g -fno-strict-aliasing -fwrapv
-fexcess-precision=3Dstandard -D_GNU_SOURCE -Wmissing-prototypes
-Wpointer-arith -Werror=3Dvla -Wendif-labels -Wmissing-format-attribute
-Wcast-function-type -Wshadow=3Dcompatible-local -Wformat-security
-Wimplicit-fallthrough=3D5 -Wdeclaration-after-statement
-Wmissing-variable-declarations -Wno-format-truncation
-Wno-stringop-truncation -fPIC -DWITH_GZFILEOP -pthread -DBUILDING_DLL -MD
-MQ src/backend/postgres_lib.a.p/executor_execExpr.c.o -MF
src/backend/postgres_lib.a.p/executor_execExpr.c.o.d -o
src/backend/postgres_lib.a.p/executor_execExpr.c.o -c
../src/backend/executor/execExpr.c
../src/backend/executor/execExpr.c: In function =E2=80=98ExecInitQual=E2=80=
=99:
../src/backend/executor/execExpr.c:269:49: error: =E2=80=98escontext=E2=80=
=99 undeclared
(first use in this function); did you mean =E2=80=98errcontext=E2=80=99?
  269 |         state->escontext =3D (ErrorSaveContext *) escontext;
      |                                                 ^~~~~~~~~
      |                                                 errcontext
../src/backend/executor/execExpr.c:269:49: note: each undeclared identifier
is reported only once for each function it appears in

--0000000000009b9911064ce1b9e3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><br>
To do that, we need to refactor the RangeVarGetRelidExtended function<br>
to make it error-safe.<br>
We can also change it as:<br></blockquote><div><br></div><div>Ok, thanks.=
=C2=A0<br><br></div><div>Hmm, seems we&#39;ve got a new compile error:</div=
><div>=C2=A0</div><div><br></div><div>FAILED: [code=3D1] src/backend/postgr=
es_lib.a.p/executor_execExpr.c.o <br>cc -Isrc/backend/postgres_lib.a.p -Isr=
c/include -I../src/include -I/usr/include/libxml2 -fdiagnostics-color=3Dalw=
ays -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -O2 -g -fno-strict-aliasin=
g -fwrapv -fexcess-precision=3Dstandard -D_GNU_SOURCE -Wmissing-prototypes =
-Wpointer-arith -Werror=3Dvla -Wendif-labels -Wmissing-format-attribute -Wc=
ast-function-type -Wshadow=3Dcompatible-local -Wformat-security -Wimplicit-=
fallthrough=3D5 -Wdeclaration-after-statement -Wmissing-variable-declaratio=
ns -Wno-format-truncation -Wno-stringop-truncation -fPIC -DWITH_GZFILEOP -p=
thread -DBUILDING_DLL -MD -MQ src/backend/postgres_lib.a.p/executor_execExp=
r.c.o -MF src/backend/postgres_lib.a.p/executor_execExpr.c.o.d -o src/backe=
nd/postgres_lib.a.p/executor_execExpr.c.o -c ../src/backend/executor/execEx=
pr.c<br>../src/backend/executor/execExpr.c: In function =E2=80=98ExecInitQu=
al=E2=80=99:<br>../src/backend/executor/execExpr.c:269:49: error: =E2=80=98=
escontext=E2=80=99 undeclared (first use in this function); did you mean =
=E2=80=98errcontext=E2=80=99?<br>=C2=A0 269 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 s=
tate-&gt;escontext =3D (ErrorSaveContext *) escontext;<br>=C2=A0 =C2=A0 =C2=
=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~~<br>=C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 errcontext<br>../src/backend/executor/execExpr.c:269:49: note: each =
undeclared identifier is reported only once for each function it appears in=
</div><div>=C2=A0</div></div></div>

--0000000000009b9911064ce1b9e3--