MIME-Version: 1.0
References: <y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
 <6af48508a32499a8be3398cafffd29fb6188c44b.camel@j-davis.com>
 <CADkLM=cG8=gde_KjGiQC_wt0K3knJCy_mwvd-sW=f=3M2eSrEg@mail.gmail.com>
 <rp6int5sqs5bn7g35brqz7w3t7il6tn2dgpm7tr3pev626wnc4@fi7a3enofhct>
 <Z8j8HXlIIGYPA9L8@nathan>
 <CADkLM=e-H5H+pY8iA58ie28PVSRJ1HBpzyy1=FWmy0Hm+s4boQ@mail.gmail.com>
 <6rpmhyrtci4epuzay7y5xvd2cwdwb6zmtt6ofxrvakyawxhm7s@6grajbpr4kij>
 <CADkLM=ct+i2G=Z+c_8np1+C75uvzjUK_SBsouUvgWMHRs2cnyg@mail.gmail.com>
 <xe3yjkcthy7f377zjayuckxyd62z5cekgjau3j4vp6elbicson@cx2uiilwmxyy>
 <CADkLM=f1n2_Vomq0gKab7xdxDHmJGgn=DE48P8fzQOp3Mrs1Qg@mail.gmail.com>
 <pbjbvxnq36xo2ooufcnlfqsqnxuvggbqxbx3myjtswokshfjbl@hfihx57z4j4t>
 <CA+TgmoYGuEC=E4TbomRyqO8+Uav=90G0dYXw=rA1d5UmRB76Yg@mail.gmail.com>
 <bd0513e4b1ea2b2f2d06f02720c6579711cb62a6.camel@j-davis.com>
 <CABV9wwO5v8Nu8q+xWexMdL3Z+2xS=fFJMQetBSHy3tR64wNHOA@mail.gmail.com>
 <bec4c2feb4ef51c129ee6e1912fffa911a3c7229.camel@j-davis.com>
 <CABV9wwP_ajEbLhCzfCO2Sy0180AshYwQFViys=QhyZA7sW2_qw@mail.gmail.com>
 <CADkLM=dvG_F2giHEAGJ=DGVGNmujUt0vAaXNSDkDXzbzcGQbxQ@mail.gmail.com>
 <CAJSLCQ10++5GLeoRwNMQMKuaVrikEp2X6feBv=kYDtWmsVy-Pw@mail.gmail.com>
 <d8a3beed2682fde95936ee779e411b907df1148a.camel@j-davis.com>
 <CADkLM=c+r05srPy9w+-+nbmLEo15dKXYQ03Q_xyK+riJerigLQ@mail.gmail.com>
 <CADkLM=ceOSsx_=oe73QQ-BxUFR2Cwqum7-UP_fPe22DBY0NerA@mail.gmail.com>
 <e7ed5a10113d04be3d02558fe6cff06a42a8777f.camel@j-davis.com>
 <5812bf576f181e2f94944cab485cee46f611ed3e.camel@j-davis.com>
 <CADkLM=c0dOJZUQuWzVcE2BsJSVRGcX7HkJH8wYjo+OD83WFqcg@mail.gmail.com>
 <0576fa4dbd6e62e027b41e0ef9254896540f1cb4.camel@j-davis.com>
 <CADkLM=f5Dy3RtGOq=2RH2z4xLXNTwSYCAu-d5ggzQFrb8nCsyg@mail.gmail.com>
 <CADkLM=ftC94muGKH+z1irdBUXO2+tmBMLdqDAAxcct=H+LE1Eg@mail.gmail.com>
 <CADkLM=desCuf3dVHasADvdUVRmb-5gO0mhMO5u9nzgv6i7U86Q@mail.gmail.com>
 <f248676c32cbb3a4dd0da13bc84af43760239bf2.camel@j-davis.com>
In-Reply-To: <f248676c32cbb3a4dd0da13bc84af43760239bf2.camel@j-davis.com>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Sat, 29 Mar 2025 01:44:57 -0400
Message-ID: 
 <CADkLM=dG+8jW4UAwP69o7Q92FOXpoN8Pb9kD_Fck1_BBn+gwgQ@mail.gmail.com>
Subject: Re: Statistics Import and Export
To: Jeff Davis <pgsql@j-davis.com>
Cc: Robert Treat <rob@xzilla.net>, Robert Haas <robertmhaas@gmail.com>,
	Andres Freund <andres@anarazel.de>,
 Nathan Bossart <nathandbossart@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>,
	jian he <jian.universality@gmail.com>, Bruce Momjian <bruce@momjian.us>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
 Magnus Hagander <magnus@hagander.net>,
	Stephen Frost <sfrost@snowman.net>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 alvherre@alvh.no-ip.org
Content-Type: multipart/alternative; boundary="000000000000a314c2063174b0f3"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3DdG%2B8jW4UAwP69o7Q92FOXpoN8Pb9kD_Fck1_BBn%2BgwgQ%40mail.gmail.com>
Precedence: bulk

--000000000000a314c2063174b0f3
Content-Type: text/plain; charset="UTF-8"

>
> The first is that i_relallfrozen is undefined in versions earlier than
> 18. That's trivial to fix, we just add "0 AS relallfrozen," in the
> earlier versions, but still refrain from outputting it.
>

Ok, so long as we refrain from outputting it, I'm cool with whatever we
store internally.


> The second is that the pg_upgrade test (when run with
> olddump/oldinstall) compares the before and after dumps, and if the
> "before" version is 17, then it will not have the relallfrozen argument
> to pg_restore_relation_stats. We might need a filtering step in
> adjust_new_dumpfile?
>

That sounds trickier. Do we already have filtering steps that are sensitive
to the "before" version dump?

--000000000000a314c2063174b0f3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">
The first is that i_relallfrozen is undefined in versions earlier than<br>
18. That&#39;s trivial to fix, we just add &quot;0 AS relallfrozen,&quot; i=
n the<br>
earlier versions, but still refrain from outputting it.<br></blockquote><di=
v><br></div><div>Ok, so long as we refrain from outputting it, I&#39;m cool=
 with whatever we store internally.</div><div><br></div><div>=C2=A0</div><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft:1px solid rgb(204,204,204);padding-left:1ex">

The second is that the pg_upgrade test (when run with<br>
olddump/oldinstall) compares the before and after dumps, and if the<br>
&quot;before&quot; version is 17, then it will not have the relallfrozen ar=
gument<br>
to pg_restore_relation_stats. We might need a filtering step in<br>
adjust_new_dumpfile?<br></blockquote><div><br></div><div>That sounds tricki=
er. Do we already have filtering steps that are sensitive to the &quot;befo=
re&quot; version dump?</div></div></div>

--000000000000a314c2063174b0f3--