MIME-Version: 1.0
References: <aRbLV7Tru3ulO5ru@paquier.xyz> <aRrHBj7I4CeV21dj@paquier.xyz>
 <CACJufxGGzkb58BU+YyTa9cBAawhybwk2cPFZ1XupS-8xuAzN9A@mail.gmail.com>
 <aRwGeN7o22HJclg5@paquier.xyz>
 <CADkLM=czQ0UUyBn3AiHZfJJWRwXH5e2xn056yG0mpuXpW09RSw@mail.gmail.com>
 <CACJufxHVKiVEvCsc11oxOM=0GgjqChFwi-ii4RJuw95ZFB_fHQ@mail.gmail.com>
 <CADkLM=eRop0t==hg0TU3KuDH6DgnUxQ6vZxV9th=6vW1JG36MQ@mail.gmail.com>
 <CACJufxGgEnOzFq0HjmkKBTnEUgToGFC0g0A4wPWoJMzOuoWUhw@mail.gmail.com>
 <CADkLM=crdyK3w7-EDEdDfXHGidxm2ms+bQYNFOZUD4eOLuLXEQ@mail.gmail.com>
 <aSVas5CIr1mvR2VK@paquier.xyz> <aSZgkssl7NT1jI2h@paquier.xyz>
In-Reply-To: <aSZgkssl7NT1jI2h@paquier.xyz>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Tue, 25 Nov 2025 23:37:09 -0600
Message-ID: 
 <CADkLM=dJzKGDK6aTEaO6NUFmSZ6wTc9Mtkho7KOEaQzjVQy60Q@mail.gmail.com>
Subject: Re: Extended Statistics set/restore/clear functions.
To: Michael Paquier <michael@paquier.xyz>
Cc: jian he <jian.universality@gmail.com>, Tomas Vondra <tomas@vondra.me>,
	pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us
Content-Type: multipart/alternative; boundary="00000000000057a3b2064478ca27"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3DdJzKGDK6aTEaO6NUFmSZ6wTc9Mtkho7KOEaQzjVQy60Q%40mail.gmail.com>
Precedence: bulk

--00000000000057a3b2064478ca27
Content-Type: text/plain; charset="UTF-8"

>
>
> non-UTF8 databases, plus a few more tests that were missing, I have
> applied the two patches for the input functions.
>

I've reviewed what you committed and it looks good to me aside from the one
nitpick I already made.


> Perhaps these will need some adjustments, but I also see little point
> in moving on with these based on the coverage we have and how the code
> is shaped.  Could you rebase the rest of the patch set for the three
> remaining pieces, Corey?  You will also need to address some of the
> comments from Chao based on a review of v16, that were not addressed
> as of v17.
>

+1

--00000000000057a3b2064478ca27
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><br>
non-UTF8 databases, plus a few more tests that were missing, I have<br>
applied the two patches for the input functions.<br></blockquote><div><br><=
/div><div>I&#39;ve reviewed what you committed and it looks good to me asid=
e from the one nitpick I already=C2=A0made.</div><div>=C2=A0</div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">
Perhaps these will need some adjustments, but I also see little point<br>
in moving on with these based on the coverage we have and how the code<br>
is shaped.=C2=A0 Could you rebase the rest of the patch set for the three<b=
r>
remaining pieces, Corey?=C2=A0 You will also need to address some of the<br=
>
comments from Chao based on a review of v16, that were not addressed<br>
as of v17. <br></blockquote><div><br></div>+1</div></div>

--00000000000057a3b2064478ca27--