MIME-Version: 1.0
References: 
 <CA+TgmoYqMtWb4zLUkT98oFnEkJ=Wz0Pw-ggDJrp9wnSXPzUaeQ@mail.gmail.com>
 <CAPmGK161TJ4G01eptv3sBqgxa4SNHDE9VRqoC6jy5Y6G3D8yDw@mail.gmail.com>
 <CA+TgmoZpwfTGqqp=0efV99e_BMYWdLFq2XKRWVSDcukifkZMeA@mail.gmail.com>
 <CADkLM=dxe8NbQu4RNi2OFXpaRKdpS0-CHGm6Mqtf_rW155BM4g@mail.gmail.com>
 <CADkLM=cV=uezAKyZdyyxnZOBRhGLUSbeYfDj5_jbDCLP9LP24Q@mail.gmail.com>
 <CA+TgmoaVcgZJpwxyi7HEfNMJhmm7BXkTQ468jvxkW2QzQZRkvg@mail.gmail.com>
 <CADkLM=dy18dDJ+j3-_Ofn11vt5J7zF33oTWnE6N=ePc83uS91A@mail.gmail.com>
 <CAPmGK15MfVT2H+PUvA_nAJvySGr_pAVkVx3KcnVXWGO36acWLA@mail.gmail.com>
In-Reply-To: 
 <CAPmGK15MfVT2H+PUvA_nAJvySGr_pAVkVx3KcnVXWGO36acWLA@mail.gmail.com>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Wed, 17 Jun 2026 12:00:02 -0400
Message-ID: 
 <CADkLM=dr5bfB8YN-bV1U0NDvyVO7a6uuz0BsAi89a1Md4A==8g@mail.gmail.com>
Subject: Re: use of SPI by postgresImportForeignStatistics
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000cb9e300654752762"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3Ddr5bfB8YN-bV1U0NDvyVO7a6uuz0BsAi89a1Md4A%3D%3D8g%40mail.gmail.com>
Precedence: bulk

--000000000000cb9e300654752762
Content-Type: text/plain; charset="UTF-8"

>
>
> IMO I don't think we need to go that far, because 1) the new functions
> are provided for FDW authors only, and 2) we don't make changes to the
> stats that often.
>

That would be simpler, to be sure. However, in the past I've received
pushback on functions that had a large number of parameters, and this would
definitely be a large number of parameters, approximately 17, so I thought
I should at least offer the variadic way.

I'm proceeding with the many-parameters model.

--000000000000cb9e300654752762
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><br>
IMO I don&#39;t think we need to go that far, because 1) the new functions<=
br>
are provided for FDW authors only, and 2) we don&#39;t make changes to the<=
br>
stats that often.<br></blockquote><div><br></div><div>That would be simpler=
, to be sure. However, in the past I&#39;ve received pushback on functions =
that had a large number of parameters, and this would definitely be a large=
 number of parameters, approximately 17, so I thought I should at least off=
er the variadic way.<br><br></div><div>I&#39;m proceeding with the many-par=
ameters model.</div></div></div>

--000000000000cb9e300654752762--