MIME-Version: 1.0
References: 
 <CACJufxHZzUeu_fyem2oA_FSrjk0ky5vn_h1Dw68=UVLekXPjXA@mail.gmail.com>
 <CACJufxHP+wZ9Th2U9JW27cCq-me222e76pv7vcjqt+oCL03m5Q@mail.gmail.com>
 <CADkLM=c8-U4GLMw5VdeDdfp1ae6BW=PCfEQqAky04iZMbckCFw@mail.gmail.com>
 <CACJufxFo5b0FvmV4CmOb74NFrXm_znZHh7bLiiVkAzVzTnJiVw@mail.gmail.com>
 <CADkLM=fky861BrifcuWc0CbWfo3yMbRB+m1jG4qqXG_3hnqdtA@mail.gmail.com>
 <CACJufxFni1oB-VFuLbVs9VSgVx0czvoZyoW0z_tJ2kq4E3SXYw@mail.gmail.com>
 <CADkLM=d_mmTn3+ChL-z_ZomwOKT-BssQU+=6_a8WDv6A4b7uAA@mail.gmail.com>
 <aRbLV7Tru3ulO5ru@paquier.xyz> <aRrHBj7I4CeV21dj@paquier.xyz>
 <CACJufxGGzkb58BU+YyTa9cBAawhybwk2cPFZ1XupS-8xuAzN9A@mail.gmail.com>
 <aRwGeN7o22HJclg5@paquier.xyz>
 <CADkLM=czQ0UUyBn3AiHZfJJWRwXH5e2xn056yG0mpuXpW09RSw@mail.gmail.com>
 <CACJufxHVKiVEvCsc11oxOM=0GgjqChFwi-ii4RJuw95ZFB_fHQ@mail.gmail.com>
 <CADkLM=eRop0t==hg0TU3KuDH6DgnUxQ6vZxV9th=6vW1JG36MQ@mail.gmail.com>
 <CAD43U4Xe5tTUR0eO-TAD6xcSUYYHrnT51XQb2TJL29hTs7Om0w@mail.gmail.com>
In-Reply-To: 
 <CAD43U4Xe5tTUR0eO-TAD6xcSUYYHrnT51XQb2TJL29hTs7Om0w@mail.gmail.com>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Fri, 21 Nov 2025 17:41:15 -0500
Message-ID: 
 <CADkLM=dwpSPt6yJfcBoZ_GGyVFZ4D5GCTsw3q8dTG+FVgMd8iA@mail.gmail.com>
Subject: Re: Extended Statistics set/restore/clear functions.
To: Yuefei Shi <shiyuefei1004@gmail.com>
Cc: jian he <jian.universality@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
	Tomas Vondra <tomas@vondra.me>, pgsql-hackers@lists.postgresql.org,
 tgl@sss.pgh.pa.us
Content-Type: multipart/alternative; boundary="0000000000009c446e0644228393"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3DdwpSPt6yJfcBoZ_GGyVFZ4D5GCTsw3q8dTG%2BFVgMd8iA%40mail.gmail.com>
Precedence: bulk

--0000000000009c446e0644228393
Content-Type: text/plain; charset="UTF-8"

>
>
> A few small comments.
>
> 1. Minor typo fixes:
>

+1 Thanks.


> 2.Code maintainability suggestion:
> I noticed the string "malformed pg_dependencies: "%s"" is used repeatedly
> throughout the code. Would you consider defining this as a macro? This
> could reduce duplication and make future updates easier.
>

It seems to be the way of things. As I stated earlier, what I'd really like
is the ability to form different errdetails and have them feed into one
errsave(), and still have the strings go through translation.


>
> 3.Memory management observation:
> Regarding item_attnum_list, while PostgreSQL's memory context mechanism
> handles cleanup, explicitly freeing the allocated memory after use might
> improve code clarity.
>
> These are all minor points - the implementation looks solid overall. Thank
> you for your work on this feature!
>

+1

--0000000000009c446e0644228393
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gma=
il_quote"><br><div>A few small comments.</div><div><br></div><div>1.=C2=A0M=
inor typo fixes:</div></div></div></blockquote><div><br></div><div>+1 Thank=
s.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">=
<div dir=3D"ltr"><div class=3D"gmail_quote"><div>2.Code maintainability sug=
gestion:</div><div>I noticed the string &quot;malformed pg_dependencies: &q=
uot;%s&quot;&quot; is used repeatedly throughout the code. Would you consid=
er defining this as a macro? This could reduce duplication and make future =
updates easier.</div></div></div></blockquote><div><br></div><div>It seems =
to be the way of things. As I stated earlier, what I&#39;d really like is t=
he ability to form different errdetails=C2=A0and have them feed into one er=
rsave(), and still have the=C2=A0strings go through translation.</div><div>=
<br></div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex=
"><div dir=3D"ltr"><div class=3D"gmail_quote"><div><br></div>3.Memory manag=
ement observation:</div><div class=3D"gmail_quote">Regarding item_attnum_li=
st, while PostgreSQL&#39;s memory context mechanism handles cleanup, explic=
itly freeing the allocated memory after use might improve code clarity.</di=
v><div class=3D"gmail_quote"><br>These are all minor points - the implement=
ation looks solid overall. Thank you for your work on this feature!</div></=
div></blockquote><div><br></div><div>+1=C2=A0</div></div></div>

--0000000000009c446e0644228393--