Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vMZTJ-00Dcfq-17 for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Nov 2025 22:19:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vMZTH-009lny-2W for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Nov 2025 22:19:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vMZTH-009lnq-1b for pgsql-hackers@lists.postgresql.org; Fri, 21 Nov 2025 22:19:15 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vMZTF-000lTa-1k for pgsql-hackers@lists.postgresql.org; Fri, 21 Nov 2025 22:19:14 +0000 Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-435a16798feso12994955ab.0 for ; Fri, 21 Nov 2025 14:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763763552; x=1764368352; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pgoQ4/PP76W/O7xXzjMJR2TzVpkTtw/skVbNg1RcEHA=; b=GpB5gI6WBD0nA6MP8ZG/aboRmM2f0yjVSAxzKblovHSMJYov4LgWIdvXKGVCMQBUcW yOpIjytWg88gXcuCBehOMV9bft1JBTiN+XVIyzyD1Ed2tatGIGpVMxWigN5W7HLQXHVw xCYW0HtoGPqExJYGUJa2EC2/HsKuDlYQ+JATcixSBLNc/3zSv/CcYt4UaSYi4Wj/zgnL pjFp2JpuG9P2Rx+erULQ9YO1+WVUjgDMPedodgDCbv/3cgux4d8lNh05RX+YJdmlidTe s9hFn5czNalljuEr6uTIFmjLSzUseL3cFD4DezJnjS0El/rj165spxnt02SdKyoMcCDI 7y+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763763552; x=1764368352; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pgoQ4/PP76W/O7xXzjMJR2TzVpkTtw/skVbNg1RcEHA=; b=TLc3agXehm4RTBVqiCpunFf5Dnt9nvYFa0Y4VPl74uXmkeAeMZljH+CRiaoNoI8+re BcQ2dl82DKcNNQ64qfIiQFcRrh49+0BamSwWlGKXH/eB0TyqbG8vH3uRt6ubKP+Lte6V fQozDAqu87/hG7EoNo1+uYPrEXMiidYNYS+om3jPfZQICbVYko68ps+KcD+0Wiphbe3o oMnlpi/Iqwge/ahwm2+cGZ48dmkSeeEeyQcLZ6blrXVZ7XO8Ejng2MqxGeGi5vnqLl/X QdMLAcrUfoyl+7SiOBKrwZMsdtLm5gV468OiDo2T9OwsX3YjsS65ZBTkPxMSZ0nLNtiq ga/g== X-Forwarded-Encrypted: i=1; AJvYcCXwBFGJmPGA8ltjb8IekkX4R8CnCajCbZfDDj/QfUAV7BpmO/cttioEXsGzFJ3hyv92T59Xqj0fURNzGAgG@lists.postgresql.org X-Gm-Message-State: AOJu0YyVYdHrUNDwdcxcowce20Nphu7wlADK8JZvQlzu4jIrkutfwJOO 5nmdqyCVtVD6zVGG1q5gZ6ENRa2FRe25kgluT4RWLfZ82rvSE3WrzqVAsm/TVLMoPduAe2N7xkJ EHDNUZMZ6YK3c5lEW+pODokUHjloQGl0= X-Gm-Gg: ASbGncv7G6WdvUe+IBiJaDBDKPddor2HpF+PK4dqtB1fWPAR+wWmlZRXQTO7LhA842Q WRwPlHRmrDcqQvh86yyhzJn/sZaGRsrgEwocxw540/clrrLKQQu2sc7AmTGdYkMAbvLTpyMJ0VW c+TDuSbBlI9yVg3z9VNr8l2/Er8VtzSqHMaizvBMs3HtVQ5726vzDT25LOWu4JIv8gIQXp9RI5/ byZg+Ug+E1O6XvU87DJLTS4xDYetJncB4pa/bVxdJxMe9+JBagZlM2Z4c4X6Ua5AraVc9Ejyaq4 y2DryHq3ZTVOPy5nLLVGHUG2mSI= X-Google-Smtp-Source: AGHT+IFbUIjBtHzzDiokfT3qvW4zB7kpiRhOM2nrBtnxYwDM5ITPzN+D7WFoD7uh1Yti/tm5O5++TUoYIrqlwpYuiRI= X-Received: by 2002:a92:ddc7:0:b0:433:7183:c2de with SMTP id e9e14a558f8ab-435aa881552mr50000415ab.7.1763763551820; Fri, 21 Nov 2025 14:19:11 -0800 (PST) MIME-Version: 1.0 References: <04afcd1f-ed7d-4c0a-add1-50e3719ccbf9@postgresfriends.org> <762ae707-7fdc-43d8-a77a-3a10d12ce21d@postgresfriends.org> In-Reply-To: From: Corey Huinker Date: Fri, 21 Nov 2025 17:18:59 -0500 X-Gm-Features: AWmQ_bk_MHRg4VTbbK0YfzXztjqfGrxGeeb4X4FaOmDjvvyINcQA2xtVev_LqrM Message-ID: Subject: Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions To: jian he Cc: Amul Sul , Vik Fearing , Isaac Morland , pgsql-hackers@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000f960e906442233c5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000f960e906442233c5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > > The same logic applies to RangeVarGetRelidExtendedSafe() and > > makeRangeVarFromNameListSafe. These can be called from > > RangeVarGetRelidExtended() and makeRangeVarFromNameList(), > > respectively. > > -- > > > > I don=E2=80=99t see any way to pass the escontext (ErrorSaveContext) with= out > changing > the textToQualifiedNameList function signature. > ... > Am I missing something? > I think we need to keep these separate. The execution paths that don't care about capturing errors shouldn't be slowed down by minority of paths that do. That may change in the future, but if it does, we'll be getting rid of a lot of internal functions with this type of difference. --000000000000f960e906442233c5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> The same logic applies to Ran= geVarGetRelidExtendedSafe() and
> makeRangeVarFromNameListSafe. These can be called from
> RangeVarGetRelidExtended() and makeRangeVarFromNameList(),
> respectively.
> --
>

I don=E2=80=99t see any way to pass the escontext (ErrorSaveContext) wi= thout changing
the textToQualifiedNameList function signature.
...
Am I missing some= thing?

I think we need to keep these se= parate. The execution paths that don't care about capturing errors shou= ldn't be slowed down by minority of paths that do. That may change in t= he future, but if it does, we'll be getting rid of a lot of internal fu= nctions with this type of difference.
--000000000000f960e906442233c5--