MIME-Version: 1.0
References: 
 <CADkLM=czQ0UUyBn3AiHZfJJWRwXH5e2xn056yG0mpuXpW09RSw@mail.gmail.com>
 <CACJufxHVKiVEvCsc11oxOM=0GgjqChFwi-ii4RJuw95ZFB_fHQ@mail.gmail.com>
 <CADkLM=eRop0t==hg0TU3KuDH6DgnUxQ6vZxV9th=6vW1JG36MQ@mail.gmail.com>
 <CACJufxGgEnOzFq0HjmkKBTnEUgToGFC0g0A4wPWoJMzOuoWUhw@mail.gmail.com>
 <CADkLM=crdyK3w7-EDEdDfXHGidxm2ms+bQYNFOZUD4eOLuLXEQ@mail.gmail.com>
 <aSVas5CIr1mvR2VK@paquier.xyz> <aSZgkssl7NT1jI2h@paquier.xyz>
 <1341064.1764895052@sss.pgh.pa.us> <aTIzH-2Spb4H6BNP@paquier.xyz>
 <1353179.1764901790@sss.pgh.pa.us> <aTJT2arh0B6dWLci@paquier.xyz>
In-Reply-To: <aTJT2arh0B6dWLci@paquier.xyz>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Fri, 5 Dec 2025 00:30:38 -0500
Message-ID: 
 <CADkLM=fnhZQzrRRB4ig5FvDfZ0trrYugLk2_R6qyzDPG4ESLpg@mail.gmail.com>
Subject: Re: Extended Statistics set/restore/clear functions.
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, jian he <jian.universality@gmail.com>,
	Tomas Vondra <tomas@vondra.me>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000c0b99406452dbf7f"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3DfnhZQzrRRB4ig5FvDfZ0trrYugLk2_R6qyzDPG4ESLpg%40mail.gmail.com>
Precedence: bulk

--000000000000c0b99406452dbf7f
Content-Type: multipart/alternative; boundary="000000000000c0b99206452dbf7d"

--000000000000c0b99206452dbf7d
Content-Type: text/plain; charset="UTF-8"

>
>
> Some of them are, yes.  However, they are also worded with the same
> format as some of the legit cases.  So they don't add any extra
> workload on the translation side as far as I recall, and I've been
> fond of the errdetail part to get a consistent style across the board.
> I'll double-check the whole a bit later, attached is the rest of them.
>
> Corey, any comments about these?
>

The wordings are fine, and I'm sorry I didn't word them as complete
sentences from the get-go.

Attached is a follow-on to Michael's most recent uncommitted patch,
changing the errors that I see as "impossible" to elogs. However, I agree
that they don't add significant workload to the translations, and most
input functions need to avoid any hard error returns lest they be called in
a soft-error context.

--000000000000c0b99206452dbf7d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><br>
Some of them are, yes.=C2=A0 However, they are also worded with the same<br=
>
format as some of the legit cases.=C2=A0 So they don&#39;t add any extra<br=
>
workload on the translation side as far as I recall, and I&#39;ve been<br>
fond of the errdetail part to get a consistent style across the board.<br>
I&#39;ll double-check the whole a bit later, attached is the rest of them.<=
br>
<br>
Corey, any comments about these?<br></blockquote><div><br></div>The wording=
s are fine, and I&#39;m sorry I didn&#39;t word them as complete sentences =
from the get-go.</div><div class=3D"gmail_quote gmail_quote_container"><br>=
</div><div class=3D"gmail_quote gmail_quote_container">Attached is a follow=
-on to Michael&#39;s most recent uncommitted patch, changing the errors tha=
t I see as &quot;impossible&quot; to elogs. However, I agree that they don&=
#39;t add significant=C2=A0workload to the translations, and most input fun=
ctions need to avoid any hard error returns lest they be called in a soft-e=
rror context.</div></div>

--000000000000c0b99206452dbf7d--

--000000000000c0b99406452dbf7f
Content-Type: text/x-patch; charset="US-ASCII";
	name="v2-0002-Change-impossible-conditions-to-elogs.patch"
Content-Disposition: attachment;
	filename="v2-0002-Change-impossible-conditions-to-elogs.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_misfdeam0>
X-Attachment-Id: f_misfdeam0

RnJvbSA5ZTdjNzAzZWIwZWQwNGRkZTI1YTJhNmUxODlmMjFlOTE2ZTU4MWJjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDb3JleSBIdWlua2VyIDxjb3JleS5odWlua2VyQGdtYWlsLmNv
bT4KRGF0ZTogRnJpLCA1IERlYyAyMDI1IDAwOjI0OjAyIC0wNTAwClN1YmplY3Q6IFtQQVRDSCB2
MSAyLzJdIENoYW5nZSBpbXBvc3NpYmxlIGNvbmRpdGlvbnMgdG8gZWxvZ3MuCgotLS0KIHNyYy9i
YWNrZW5kL3V0aWxzL2FkdC9wZ19kZXBlbmRlbmNpZXMuYyB8IDE0ICsrKysrKy0tLS0tLS0tCiBz
cmMvYmFja2VuZC91dGlscy9hZHQvcGdfbmRpc3RpbmN0LmMgICAgfCAgNyArKystLS0tCiAyIGZp
bGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0
IGEvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3BnX2RlcGVuZGVuY2llcy5jIGIvc3JjL2JhY2tlbmQv
dXRpbHMvYWR0L3BnX2RlcGVuZGVuY2llcy5jCmluZGV4IDE1NTJlMDNkMWMxLi43Mzc1ZTg0OThj
NSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3BnX2RlcGVuZGVuY2llcy5jCisr
KyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ19kZXBlbmRlbmNpZXMuYwpAQCAtMzI2LDEwICsz
MjYsOSBAQCBkZXBlbmRlbmNpZXNfYXJyYXlfZW5kKHZvaWQgKnN0YXRlKQogCQkJICogVGhpcyBj
YW4gb25seSBoYXBwZW4gaWYgYSBjYXNlIHdhcyBtaXNzZWQgaW4KIAkJCSAqIGRlcGVuZGVuY2ll
c19hcnJheV9zdGFydCgpLgogCQkJICovCi0JCQllcnJzYXZlKHBhcnNlLT5lc2NvbnRleHQsCi0J
CQkJCWVycmNvZGUoRVJSQ09ERV9JTlZBTElEX1RFWFRfUkVQUkVTRU5UQVRJT04pLAotCQkJCQll
cnJtc2coIm1hbGZvcm1lZCBwZ19kZXBlbmRlbmNpZXM6IFwiJXNcIiIsIHBhcnNlLT5zdHIpLAot
CQkJCQllcnJkZXRhaWwoIkFycmF5IGhhcyBiZWVuIGZvdW5kIGF0IGFuIHVuZXhwZWN0ZWQgbG9j
YXRpb24uIikpOworCQkJZWxvZyhFUlJPUiwKKwkJCQkgInBnX2RlcGVuZGVuY2llcyBhcnJheSBl
bmQgZW5jb3VudGVyZWQgaW4gdW5leHBlY3RlZCBwYXJzZSBzdGF0ZTogJWQuIiwKKwkJCQkgKGlu
dCkgcGFyc2UtPnN0YXRlKTsKIAkJCWJyZWFrOwogCX0KIAlyZXR1cm4gSlNPTl9TRU1fQUNUSU9O
X0ZBSUxFRDsKQEAgLTQ0MywxMCArNDQyLDkgQEAgZGVwZW5kZW5jaWVzX2FycmF5X2VsZW1lbnRf
c3RhcnQodm9pZCAqc3RhdGUsIGJvb2wgaXNudWxsKQogCQkJYnJlYWs7CiAKIAkJZGVmYXVsdDoK
LQkJCWVycnNhdmUocGFyc2UtPmVzY29udGV4dCwKLQkJCQkJZXJyY29kZShFUlJDT0RFX0lOVkFM
SURfVEVYVF9SRVBSRVNFTlRBVElPTiksCi0JCQkJCWVycm1zZygibWFsZm9ybWVkIHBnX2RlcGVu
ZGVuY2llczogXCIlc1wiIiwgcGFyc2UtPnN0ciksCi0JCQkJCWVycmRldGFpbCgiVW5leHBlY3Rl
ZCBhcnJheSBlbGVtZW50IGhhcyBiZWVuIGZvdW5kLiIpKTsKKwkJCWVsb2coRVJST1IsCisJCQkJ
ICJwZ19kZXBlbmRlbmNpZXMgYXJyYXkgZWxlbWVudCBlbmNvdW50ZXJlZCBpbiB1bmV4cGVjdGVk
IHBhcnNlIHN0YXRlOiAlZC4iLAorCQkJCSAoaW50KSBwYXJzZS0+c3RhdGUpOwogCQkJYnJlYWs7
CiAJfQogCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdfbmRpc3RpbmN0LmMg
Yi9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdfbmRpc3RpbmN0LmMKaW5kZXggOWJmMTU0NmM4MDMu
LjcxOGQxNjFlYzQxIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdfbmRpc3Rp
bmN0LmMKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3BnX25kaXN0aW5jdC5jCkBAIC0yODYs
MTAgKzI4Niw5IEBAIG5kaXN0aW5jdF9hcnJheV9lbmQodm9pZCAqc3RhdGUpCiAJCQkgKiBUaGlz
IGNhbiBvbmx5IGhhcHBlbiBpZiBhIGNhc2Ugd2FzIG1pc3NlZCBpbgogCQkJICogbmRpc3RpbmN0
X2FycmF5X3N0YXJ0KCkuCiAJCQkgKi8KLQkJCWVycnNhdmUocGFyc2UtPmVzY29udGV4dCwKLQkJ
CQkJZXJyY29kZShFUlJDT0RFX0lOVkFMSURfVEVYVF9SRVBSRVNFTlRBVElPTiksCi0JCQkJCWVy
cm1zZygibWFsZm9ybWVkIHBnX25kaXN0aW5jdDogXCIlc1wiIiwgcGFyc2UtPnN0ciksCi0JCQkJ
CWVycmRldGFpbCgiQXJyYXkgaGFzIGJlZW4gZm91bmQgYXQgYW4gdW5leHBlY3RlZCBsb2NhdGlv
bi4iKSk7CisJCQllbG9nKEVSUk9SLAorCQkJCSAicGdfbmRpc3RpbmN0IGFycmF5IGVsZW1lbnQg
ZW5jb3VudGVyZWQgaW4gdW5leHBlY3RlZCBwYXJzZSBzdGF0ZTogJWQuIiwKKwkJCQkgKGludCkg
cGFyc2UtPnN0YXRlKTsKIAkJCWJyZWFrOwogCX0KIAotLSAKMi41Mi4wCgo=
--000000000000c0b99406452dbf7f--