MIME-Version: 1.0
References: <8b8aa673-fcef-4e14-a05d-0885283ef1b8@pgbackrest.org>
 <d21f3c7c-563c-49db-8983-faa73ed4369f@pgbackrest.org>
 <f74cab02-5ebb-439c-975b-29d019eed787@pgbackrest.org>
 <17DC1346-0CDE-4E39-B110-3D6FB0797AC6@gmail.com>
 <feb68313-3257-4d9d-8b69-6468e506a61a@pgbackrest.org>
 <7F7B289B-F94F-42C2-9E54-6A689C0D64BB@gmail.com>
 <aboDQSoywyKGGNCr@paquier.xyz>
 <1800c83c-264a-4183-9da5-ac78e25849a8@pgbackrest.org>
 <abov3-Kre8ntiL-S@paquier.xyz>
 <3b23e3b7-53d2-4784-b482-05cca3327acb@pgbackrest.org>
 <abphw4g2TwuPP0Cv@paquier.xyz>
 <df9e4c1f-4178-47fb-abdd-9829f7079b44@pgbackrest.org>
In-Reply-To: <df9e4c1f-4178-47fb-abdd-9829f7079b44@pgbackrest.org>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Wed, 18 Mar 2026 17:00:34 -0400
Message-ID: 
 <CADkLM=fpAVj_YU8aU-_o8LCPTGcuQXxucoV7TXFv5vtGHmghMg@mail.gmail.com>
Subject: Re: Return pg_control from pg_backup_stop().
To: David Steele <david@pgbackrest.org>
Cc: Michael Paquier <michael@paquier.xyz>, Haibo Yan <tristan.yim@gmail.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>,
 Heikki Linnakangas <hlinnaka@iki.fi>,
	Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
	Fujii Masao <masao.fujii@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000efa28e064d52bed7"
Archived-At: 
 <https://www.postgresql.org/message-id/CADkLM%3DfpAVj_YU8aU-_o8LCPTGcuQXxucoV7TXFv5vtGHmghMg%40mail.gmail.com>
Precedence: bulk

--000000000000efa28e064d52bed7
Content-Type: text/plain; charset="UTF-8"

>
> Whatever gets committed for PG19 I'll write a followup patch to describe
> the hazards of reading pg_control and generally how to get a good copy.
> However, this will be complicated enough that the best answer will
> likely be to use pg_basebackup or some other reputable backup software.
> I don't love this -- I feel like the low-level interface should be
> usable with such hazards.


Surya Poondla and I had decided on this patchset as a pair-reviewing
exercise. However, events have overtaken us, and several other people have
chimed in expressing the same concerns that we had observed but hadn't yet
completed our review. All of the main concerns that we had found up to this
point have been addressed in the lastest patchset, except for the trivial
observation that the ereport() uses the old style and doesn't need the set
of parens around (errmsg(), errhint()). Patches apply clean, tests pass,
test coverage seems sufficient, we're happy with the wording of the
documentation, in short there really isn't a whole lot for us to add to the
review, and for that reason we're removing our names from the list of
reviewers in the commitfest app.

--000000000000efa28e064d52bed7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">Whatever gets committed for PG19 I=
&#39;ll write a followup patch to describe <br>
the hazards of reading pg_control and generally how to get a good copy. <br=
>
However, this will be complicated enough that the best answer will <br>
likely be to use pg_basebackup or some other reputable backup software. <br=
>
I don&#39;t love this -- I feel like the low-level interface should be <br>
usable with such hazards.</blockquote><div><br></div><div>Surya Poondla and=
 I had decided on this patchset as a pair-reviewing exercise. However, even=
ts have overtaken us, and several other people have chimed in expressing th=
e same concerns that we had observed but hadn&#39;t yet completed our revie=
w. All of the main concerns that we had found up to this point have been ad=
dressed in the lastest patchset, except for the trivial observation that th=
e ereport() uses the old style and doesn&#39;t need the set of parens aroun=
d (errmsg(), errhint()). Patches apply clean, tests pass, test coverage see=
ms sufficient, we&#39;re happy with the wording of the documentation, in sh=
ort there really isn&#39;t a whole lot for us to add to the review, and for=
 that reason we&#39;re removing our names from the list of reviewers in the=
 commitfest app.</div></div></div>

--000000000000efa28e064d52bed7--