MIME-Version: 1.0
References: 
 <CAASxf_P1F75Ck+0qyb10auT+BORupOM4yigXBnm7aWRNx1LYcA@mail.gmail.com>
 <3007317.1765210195@sss.pgh.pa.us>
 <CAASxf_P5f=Frf8S7rN9BzphtCLoeN9vFuh-V7ukotOQZU54g+w@mail.gmail.com>
 <CAHGQGwHAPXexiGaHMkDDRF7cPBr_3fgCNdT4n2+1UjaEU++BAQ@mail.gmail.com>
 <CAASxf_OGWD7PA5TMEh2MdF2YxN8V3ByLhnFJ=uw0hKr33sgqAw@mail.gmail.com>
 <CAKYtNAqjJbzV+ZJDqA-s0fHSLen6msc=A0SfrTS1ub1KKH9haQ@mail.gmail.com>
 <CADrsxdbb2fn1LACQShrQT0bNqSCQ3hSzEojb2tODhD0PmewDiA@mail.gmail.com>
 <CAASxf_OdsJRi17EZ_ZMyQgOwUzn357YyMqJ2Z2qiExPaLRW_Lg@mail.gmail.com>
 <CADrsxdbPw1ZYcuqH1-DTNhAvRN=tRTTY+_dFy8wU2g4DQb67Bg@mail.gmail.com>
 <CAASxf_PtXCsmu5oCvZH4BmLdojG+0XJUH8foHFZv+2vmsSbNwA@mail.gmail.com>
In-Reply-To: 
 <CAASxf_PtXCsmu5oCvZH4BmLdojG+0XJUH8foHFZv+2vmsSbNwA@mail.gmail.com>
From: Nishant Sharma <nishant.sharma@enterprisedb.com>
Date: Thu, 16 Apr 2026 12:34:19 +0530
Message-ID: 
 <CADrsxdZMOc6qkoVcyp67+Ez8cesey3iDVaVm617oSpiDdf=5xQ@mail.gmail.com>
Subject: Re: [BUG] CRASH: ECPGprepared_statement() and ECPGdeallocate_all()
 when connection is NULL
To: Shruthi Gowda <gowdashru@gmail.com>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>,
 Fujii Masao <masao.fujii@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
 PostgreSQL Development <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000009e0244064f8e71bb"
Archived-At: 
 <https://www.postgresql.org/message-id/CADrsxdZMOc6qkoVcyp67%2BEz8cesey3iDVaVm617oSpiDdf%3D5xQ%40mail.gmail.com>
Precedence: bulk

--0000000000009e0244064f8e71bb
Content-Type: text/plain; charset="UTF-8"

Thanks Shruthi for the new patches!

I can apply v5 on all active branches (i.e master, REL_18, REL_17, REL_16,
REL_15, REL_14).
I checked PG's ECPG regression with v5 and v2_test on master, REL_18,
REL_17, and REL_16 using both make and meson.

The v5 patch looks good to me now. I only have a few observations on
v2_test patch.

Review comments on v2_test:
1. Not able to apply the v2 test patch on PG15 and PG14 branch, appears
meson.build for test is not there on these branches. Need to remove all
meson related changes for these branches.
2. char val2[5] = "data1"; --> val2's size will not be able to fit '\0' for
the string. As size of val2 and number of characters in "data1" are exactly
same?
3. "exec sql disconnect;" - Do we need this at the end as we have already
disconnected before Test 2.
3. Minor - Do we need "printf("sqlca.sqlcode = %ld\n", sqlca.sqlcode);"? I
see all others have it, but not Test 4?


Regards,
Nishant Sharma,
Pune, EDB.
https://www.enterprisedb.com/

>

--0000000000009e0244064f8e71bb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Thanks Shruthi for the new patches!<br><b=
r>I can apply v5 on all active branches (i.e master, REL_18, REL_17, REL_16=
, REL_15, REL_14).<br>I checked PG&#39;s ECPG regression with v5 and v2_tes=
t on master, REL_18, REL_17, and REL_16 using both make and meson.<br><br>T=
he v5 patch looks good to me now. I only have a few observations on v2_test=
 patch.<br><br>Review comments on v2_test:<br>1. Not able to apply the v2 t=
est patch on PG15 and PG14 branch, appears meson.build for test is not ther=
e on these branches. Need to remove all meson related changes for these bra=
nches.<br>2. char val2[5] =3D &quot;data1&quot;; --&gt; val2&#39;s size wil=
l not be able to fit &#39;\0&#39; for the string. As size of val2 and numbe=
r of characters in &quot;data1&quot; are exactly same?<br>3. &quot;exec sql=
 disconnect;&quot; - Do we need this at the end as we have already disconne=
cted before Test 2.<br>3. Minor - Do we need &quot;printf(&quot;sqlca.sqlco=
de =3D %ld\n&quot;, sqlca.sqlcode);&quot;? I see all others have it, but no=
t Test 4?</div><div dir=3D"ltr"><br></div><div dir=3D"ltr"><br></div><div>R=
egards,</div><div>Nishant Sharma,</div><div>Pune, EDB.</div><div><a href=3D=
"https://www.enterprisedb.com/">https://www.enterprisedb.com/</a></div><div=
 class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex">
</blockquote></div></div>

--0000000000009e0244064f8e71bb--