MIME-Version: 1.0
References: <CADrsxdb0ueGV9nrC6s8zvXLkGUhnEjx7Ou_p5wo38TvmSvF83A@mail.gmail.com>
In-Reply-To: <CADrsxdb0ueGV9nrC6s8zvXLkGUhnEjx7Ou_p5wo38TvmSvF83A@mail.gmail.com>
From: Nishant Sharma <nishant.sharma@enterprisedb.com>
Date: Tue, 10 Oct 2023 11:27:14 +0530
Message-ID: <CADrsxdaZ84tJ9hu9SSgR-PMDk7X+4LpLV0aQfxpZhVaR0V36_w@mail.gmail.com>
Subject: Re: [Code Cleanup] : Small code cleanup in twophase.sql
To: pgsql-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="00000000000092e84006075661d0"
Archived-At: <https://www.postgresql.org/message-id/CADrsxdaZ84tJ9hu9SSgR-PMDk7X%2B4LpLV0aQfxpZhVaR0V36_w%40mail.gmail.com>
Precedence: bulk

--00000000000092e84006075661d0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Any taker or rejector for above? -- It's a very small 'good to have' change
patch for cleanup.

Thanks,
Nishant (EDB).

On Tue, Sep 26, 2023 at 6:31=E2=80=AFPM Nishant Sharma <
nishant.sharma@enterprisedb.com> wrote:

> Hi,
>
>
> PFA small code cleanup in twophase.sql. Which contains a drop table
> statement for 'test_prepared_savepoint'. Which, to me, appears to be
> missing in the cleanup section of that file.
>
> To support it I have below points:-
>
> 1) Grepping this table 'test_prepared_savepoint' shows occurrences
> only in twophase.out & twophase.sql files. This means that table is
> local to that sql test file and not used in any other test file.
>
> 2) I don't see any comment on why this was not added in the cleanup
> section of twophase.sql, but drop for other two test tables are done.
>
> 3) I ran "make check-world" with the patch and I don't see any failures.
>
> Kindly correct, if I missed anything.
>
>
> Regards,
> Nishant (EDB).
>

--00000000000092e84006075661d0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<br><div><br></div><div>Any taker or rejector for above=
? -- It&#39;s a very small &#39;good to have&#39; change patch for cleanup.=
</div><div><br></div><div>Thanks,</div><div>Nishant (EDB).</div></div><br><=
div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Sep=
 26, 2023 at 6:31=E2=80=AFPM Nishant Sharma &lt;<a href=3D"mailto:nishant.s=
harma@enterprisedb.com">nishant.sharma@enterprisedb.com</a>&gt; wrote:<br><=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo=
rder-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi,=
<div><br></div><div><br></div><div>PFA small code cleanup in twophase.sql. =
Which contains a drop table</div><div>statement for &#39;test_prepared_save=
point&#39;. Which, to me, appears to be</div><div>missing in the cleanup se=
ction of that file.</div><div><br></div><div>To support it I have below poi=
nts:-</div><div><br></div><div>1) Grepping this table &#39;test_prepared_sa=
vepoint&#39; shows occurrences</div><div>only in twophase.out &amp; twophas=
e.sql files. This means that table is</div><div>local to that sql test file=
 and not used in any other test file.</div><div><br></div><div>2) I don&#39=
;t see any comment on why this was not added in the cleanup</div><div>secti=
on of twophase.sql, but drop for other two test tables are done.</div><div>=
<br></div><div>3) I ran &quot;make=C2=A0check-world&quot; with the patch an=
d I don&#39;t=C2=A0see any failures.</div><div><br></div><div>Kindly correc=
t, if I missed anything.</div><div><br></div><div><br></div><div>Regards,</=
div><div>Nishant (EDB).</div></div>
</blockquote></div>

--00000000000092e84006075661d0--