MIME-Version: 1.0
References: <202512151349.vlq3mpfniyk3@alvherre.pgsql> <11247.1767609087@localhost>
 <11558.1767609632@localhost> <141054.1767891540@localhost>
 <CADzfLwU-OmxW3t3AoQo9=K7uq4G1yZ-txcetzW3jbcVxV_pJew@mail.gmail.com> <137668.1768235610@localhost>
In-Reply-To: <137668.1768235610@localhost>
From: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Date: Mon, 12 Jan 2026 21:20:35 +0300
Message-ID: <CADzfLwUJSHKGxYw+vMUZ_Hr2YeuxO2Q5w13HKgUUN1725tjY5Q@mail.gmail.com>
Subject: Re: Adding REPACK [concurrently]
To: Antonin Houska <ah@cybertec.at>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	Pg Hackers <pgsql-hackers@lists.postgresql.org>, Robert Treat <rob@xzilla.net>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CADzfLwUJSHKGxYw%2BvMUZ_Hr2YeuxO2Q5w13HKgUUN1725tjY5Q%40mail.gmail.com>
Precedence: bulk

Hello, Antonin!

More comments - now for 0005 (but v29, but I think they are mostly up to date).

--- 0005 ---

> potentiallly
extra 'l' in commit message

> Memory the queue is located int.
"in"?

>  again if its still eligible
if it's still eligible

> int initialized;
probably better to be bool (as in shared)

> DecodingWorkerState
such type does not exists in commit

> REPACK_WORKER_MAIN
Not used in code anywhere.

> int64 timeout = 0;
> WaitLSNResult   res;
formatting issue here (tab vs space)

> if (size >= MaxAllocSize)
Seems like we lost that check, I think it may be executed on storing
the data or before "tup = (HeapTuple) palloc(HEAPTUPLESIZE + t_len);"
in apply_concurrent_changes

> bool done;
I still think it is a confusing name.

> chgdst.file_seq = WORKER_FILE_SNAPSHOT + 1;
I think it is better to increment it once a snapshot is received. And
rename to last_processed/last_improrted to be aligned with
last_exported.

Best regards,
Mikhail.