public inbox for [email protected]
help / color / mirror / Atom feedFrom: Mihail Nikalayeu <[email protected]>
To: Alvaro Herrera <[email protected]>
Cc: Srinath Reddy Sadipiralla <[email protected]>
Cc: Antonin Houska <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: Robert Treat <[email protected]>
Subject: Re: Adding REPACK [concurrently]
Date: Fri, 20 Mar 2026 13:35:00 +0100
Message-ID: <CADzfLwURy8_BYyqrvr6rhTXsW3=5QMRLHuNati3CgY0nKRSwyw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAFC+b6qk3-DQTi43QMqvVLP+sudPV4vsLQm5iHfcCeObrNaVyA@mail.gmail.com>
<[email protected]>
Hello, everyone!
Some comments for v43:
---
src/backend/commands/cluster.c:3211
slot_attisnull(dest, i) uses a 0-based loop index but slot_attisnull
starts with "Assert(attnum > 0);".
Also, it proves it has not been tested in any way yet.
------------------------------
src/backend/storage/ipc/standby.c:1376
"if (xlrec.xcnt > 0)"
looks like it should be "xlrec.xcnt + xlrec.xcnt_repack > 0" because
of "CurrentRunningXacts->xcnt = count - subcount - count_repack;"
------------------------------
src/backend/storage/ipc/procarray.c:2673-2681
"nrepack = logical_decoding_enabled ? MAX_REPACK_XIDS : 0"
not sure it is a real issue, but if EnableLogicalDecoding is called
somehow after allocating the array - it makes it possible to overrun
the array later by MAX_REPACK_XIDS.
------------------------------
src/backend/commands/cluster.c:3006
"apply_cxt = AllocSetContextCreate(TopTransactionContext,
"REPACK - apply",
ALLOCSET_DEFAULT_SIZES);"
Should we do it before the "MakeSingleTupleTableSlot" calls?
Because MakeSingleTupleTableSlot stored CurrentMemoryContext in tts_mcxt.
------------------------------
src/backend/commands/cluster.c:3187
if (natt_ext != 0)
elog(WARNING, "have natt_ext %d, weird", natt_ext);
Should we make that ERROR?
------------------------------
src/backend/access/rmgrdesc/standbydesc.c:24
appendStringInfo(buf, "nextXid %u latestCompletedXid %u
oldestRunningXid %u oldestRunningXid %u",
"oldestRunningXidLogical" at the end?
------------------------------
src/backend/catalog/index.c:766,1464-1469
"bool progress = (flags & INDEX_CREATE_REPORT_PROGRESS) != 0;"
AFAIU gin, hash and btree (at least) still just unconditionally write
PROGRESS_CREATEIDX_* progress.
------------------------------
src/backend/catalog/toasting.c:334
"INDEX_CREATE_IS_PRIMARY | INDEX_CREATE_REPORT_PROGRESS, 0,"
Should we add the "progress" flag too here and move it from make_new_heap?
-------------------------------
Also just, gently remind you about [1] and a simple way to avoid any
unnoticed MVCC-related issues with REPACK proposed here [2].
Best regards,
Mikhail.
[1]: https://www.postgresql.org/message-id/flat/5k2dfckyp6zv2fiovosvtbya5onvplgviz5n4kdamxupff4vi2%40yytz...
[2]: https://www.postgresql.org/message-id/[email protected]...
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <CADzfLwURy8_BYyqrvr6rhTXsW3=5QMRLHuNati3CgY0nKRSwyw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox