MIME-Version: 1.0
References: 
 <CADzfLwUB=iafkv2dR-9oFgjAANRZE2icUJQyt-zLpcs_T_ug8w@mail.gmail.com>
 <202604061043.4tvvhamrwnlc@alvherre.pgsql>
In-Reply-To: <202604061043.4tvvhamrwnlc@alvherre.pgsql>
From: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Date: Mon, 6 Apr 2026 13:21:32 +0200
Message-ID: 
 <CADzfLwWFr9h_+cbSQvPpdxgLbVL5wwxFRx21ezNvLYgJM=FVCQ@mail.gmail.com>
Subject: Re: Adding REPACK [concurrently]
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Antonin Houska <ah@cybertec.at>,
 Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Robert Treat <rob@xzilla.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CADzfLwWFr9h_%2BcbSQvPpdxgLbVL5wwxFRx21ezNvLYgJM%3DFVCQ%40mail.gmail.com>
Precedence: bulk

Hi!

On Mon, Apr 6, 2026 at 12:48=E2=80=AFPM Alvaro Herrera <alvherre@alvh.no-ip=
.org> wrote:
> Hmm, how about something like this?
>
>             natt_ext--;
>             if (natt_ext < 0)
>                 ereport(ERROR,
>                         errcode(ERRCODE_DATA_CORRUPTED),
>                         errmsg("insufficient number of attributes stored =
separately"));
I think it is ok.

> Yeah but I don't want the virtual tuple to be materialized (which would
> happen in tts_virtual_materialize if I set shouldFree=3Dtrue).  The memor=
y
> should be freed in
>                 ResetPerTupleExprContext(chgcxt->cc_estate);
> anyway, right?  Maybe deserves a comment.

Not sure, ResetPerTupleExprContext resets just "ExecutorState".
But slots are created in another memory context.

Also, we can't reset slot->tts_mcxt itself - it will free the slot also.