MIME-Version: 1.0
References: <202508301750.cbohxyy2pcce@alvherre.pgsql>
 <202509251758.t77p7r2ocmej@alvherre.pgsql>
In-Reply-To: <202509251758.t77p7r2ocmej@alvherre.pgsql>
From: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Date: Fri, 26 Sep 2025 16:27:12 +0200
Message-ID: 
 <CADzfLwXUcQL-dK7J7KKxTnPR95ruc5wHP71rKYG35fnt4MktpA@mail.gmail.com>
Subject: Re: Adding REPACK [concurrently]
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Antonin Houska <ah@cybertec.at>,
	Robert Treat <rob@xzilla.net>, Fujii Masao <masao.fujii@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CADzfLwXUcQL-dK7J7KKxTnPR95ruc5wHP71rKYG35fnt4MktpA%40mail.gmail.com>
Precedence: bulk

Hello!

=C3=81lvaro Herrera <alvherre@kurilemu.de>:
> So here's v22 with those and rebased to current sources.  Only the first
> two patches this time, which are the ones I would be glad to receive
> input on.

> get_tables_to_repack_partitioned(RepackCommand cmd, MemoryContext cluster=
_context,
>                          Oid relid, bool rel_is_index)

Should we rename it to repack_context to be aligned with the calling side?

---------
'cmd' in

> static List *get_tables_to_repack(RepackCommand cmd, bool usingindex,
>                           MemoryContext permcxt);

but 'command' in

> get_tables_to_repack(RepackCommand command, bool usingindex,
>                 MemoryContext permcxt)

---------

> cmd =3D=3D REPACK_COMMAND_CLUSTER ? "CLUSTER" : "REPACK",

May be changed to RepackCommandAsString

-----------

if (cmd =3D=3D REPACK_COMMAND_REPACK)
    pgstat_progress_update_param(PROGRESS_REPACK_COMMAND,
                          PROGRESS_REPACK_COMMAND_REPACK);
else if (cmd =3D=3D REPACK_COMMAND_CLUSTER)
{
    pgstat_progress_update_param(PROGRESS_REPACK_COMMAND,
                          PROGRESS_CLUSTER_COMMAND_CLUSTER);
} else ....

'{' and '}' looks a little bit weird.

--------
Documentation of pg_repackdb contains a lot of "analyze" and even
"--analyze" parameter - but I can't see anything related in the code.


Best regards,
Mikhail.