MIME-Version: 1.0
References: <a5313e34-3fa2-4d66-ba88-e4df9ea3b4af@vondra.me>
 <202507071221.am6rbd6n4dct@alvherre.pgsql>
 <CAE7r3MJeqDSfic9pQedsRg3xg49q7=iq5PTuZNNNi7yqAw8dTw@mail.gmail.com>
 <67115399-4799-4c3b-bd17-d43c98099919@vondra.me>
 <CAE7r3MLDcDjh5ieGS=UNtKVm6wG0mRRqdYGUEoKvsDoFp9PgRQ@mail.gmail.com>
 <CAE7r3MJfwYQq9LqVYJDB85XwuXPD1GPsys8HvnqLQT-uB7Z-nw@mail.gmail.com>
In-Reply-To: 
 <CAE7r3MJfwYQq9LqVYJDB85XwuXPD1GPsys8HvnqLQT-uB7Z-nw@mail.gmail.com>
From: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>
Date: Fri, 1 Aug 2025 23:22:13 +0300
Message-ID: 
 <CAE7r3ML7ua99HAHPkrwi5sFER+kt7_ZeARMn57JCqwKaWLhEng@mail.gmail.com>
Subject: Re: amcheck support for BRIN indexes
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAE7r3ML7ua99HAHPkrwi5sFER%2Bkt7_ZeARMn57JCqwKaWLhEng%40mail.gmail.com>
Precedence: bulk

Hi,

On Tue, Jul 22, 2025 at 6:43=E2=80=AFPM Arseniy Mukhin
<arseniy.mukhin.dev@gmail.com> wrote:
>
> Hi,
>
> While reviewing gist amcheck patch [1] I realized that brin amcheck
> also must check if current snapshot is OK with index indcheckxmin (as
> btree, gist do it). Currently this check is contained in btree amcheck
> code, but other AMs need it for heapallindexed as well, so I moved it
> from btree to verify_common (0003 patch).

There was a compiler warning on CI, so there is a new version with the
fix (adds #include to verify_common).
I also moved it to PG19-2.


Best regards,
Arseniy Mukhin