MIME-Version: 1.0
References: 
 <CANhcyEVSXyQkvmrsOWPdQqnm2J3GMyQQrKhyCJiBQzqs6AvSow@mail.gmail.com>
 <CALDaNm125dv88fUDgBPBM-N-hXbF0NLqKe-ymEpMRNymUYRQAA@mail.gmail.com>
 <CANhcyEUxgzaNJNNO_-12wYwGLihpuKmsMH2g4TFnRPx5AQVZmg@mail.gmail.com>
 <CAJpy0uBB4N8KOrHchdgprVi2Ws1+gTcEr+bC2A_ziAHOcZcTqA@mail.gmail.com>
 <CAJpy0uCAJQvBjD7qNWWGnZP_LDwS8AiUJC7YMict9UcYqH=XeQ@mail.gmail.com>
 <CANhcyEU_Yq9ZJ2n5Sqa7RoHze0TD0RGxLQQgV1F6Jm2AROEh8g@mail.gmail.com>
 <CANhcyEWj-ECj=WC+HD_kv27Dn6FkTngFQCVJVTVZfJnjCTKMBQ@mail.gmail.com>
 <CANhcyEW03XO5tLb7opt1yQGHWJ7Ew=L65EWcdrKH=F0mUpuR3A@mail.gmail.com>
 <CAHut+Ptu0Bkwnr5eetdmFhJC7SsEtKjNe_cTwOg5wF65fjyV8w@mail.gmail.com>
 <CANhcyEU+4Z6NXMEk6OmctFv=_pY8K5AiazkfVmn7zxhwQO6CEQ@mail.gmail.com>
 <CAHut+PvOWjKJfNorGO8whnaAtqZb-4zN8u6aOajCw3hn-tMwyA@mail.gmail.com>
 <CANhcyEV_Sv+xQzsjo6hbowDbGV5J7RhFWuQQxWeUWPNPd0k1=w@mail.gmail.com>
 <CAHut+Pt6O3YD8h61RCtzMrRwgvS=RDRNf4KuXAUn1WYnoFU_uQ@mail.gmail.com>
 <CANhcyEU=Vi2oNRWTSph3x2884J7aTt5BTb4AzwmmY0uQAsEMMg@mail.gmail.com>
 <CAHut+Pv9ru8tNLz1LaPjuG-1X5dsLd36cFbb11e=bhYrHz60CQ@mail.gmail.com>
 <CANhcyEVDStqoR3qDSgsv5VEuBMzMX4YpdEfW-7VPX3c5Vf1YJA@mail.gmail.com>
 <CAHut+PsFNboBR8E+NRY_3hMqdpbj3y3jX1+vQTow2khgj4t=qw@mail.gmail.com>
 <CANhcyEW+aJ1rAAodQZDvCd-WpQ+b8r5wBs8H+mNdQS8URmkODg@mail.gmail.com>
 <CAHut+PvXpsFrNn2NOhepVOS7Zf_OvX-m71Wu+m-o_q9odYFXnA@mail.gmail.com>
 <CANhcyEWfzDRCiny6A_swAD7WUgdb37-TA4xTAUQ3JJXK9UPBZQ@mail.gmail.com>
 <CAJpy0uCLhrwK_s3VbEjO+qD7amdxuYgNxi8OX4VLdb5pZkorwQ@mail.gmail.com>
 <CANhcyEVzkYgMu0ah7kUmPgk6n14xsFZL8XvhiJXNsCW9oRjdGg@mail.gmail.com>
 <CAHut+PsgCQa2hcT8TNqejV3y4U5ouj=ZCOLMxgVGvBrUEkLaKg@mail.gmail.com>
 <CAJpy0uCV-L8DP+AfZq2Rj1xEjyzwZW-ugfmmXMPpotiyNTHG_A@mail.gmail.com>
 <CANhcyEW_4=OECRiHStsCJUJ_Ng-V=EJ+Oaeji4uk3s4yazqUBg@mail.gmail.com>
 <CAHut+PtVyhHpMWCMrgO--dnHza00nBY3wZagfycWTDhSJ6sGFA@mail.gmail.com>
 <CANhcyEV201=vsz8aoOpSgYWEbG4WuxtL1P=a8X9N+48ZBtBfNQ@mail.gmail.com>
In-Reply-To: 
 <CANhcyEV201=vsz8aoOpSgYWEbG4WuxtL1P=a8X9N+48ZBtBfNQ@mail.gmail.com>
From: Ashutosh Sharma <ashu.coek88@gmail.com>
Date: Tue, 30 Jun 2026 13:16:53 +0530
Message-ID: 
 <CAE9k0PnBrRaqOAqGVKmcaCKKKoZEx_sEf6p=hQRn_ZW2+04afw@mail.gmail.com>
Subject: Re: Support EXCEPT for ALL SEQUENCES publications
To: Shlok Kyal <shlok.kyal.oss@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>,
 shveta malik <shveta.malik@gmail.com>,
	vignesh C <vignesh21@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAE9k0PnBrRaqOAqGVKmcaCKKKoZEx_sEf6p%3DhQRn_ZW2%2B04afw%40mail.gmail.com>
Precedence: bulk

Hi,

On Tue, Jun 30, 2026 at 12:14=E2=80=AFPM Shlok Kyal <shlok.kyal.oss@gmail.c=
om> wrote:
>
> On Mon, 29 Jun 2026 at 06:02, Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > Hi Shlok.
> >
> > I only had one general comment about v14. IMO, it would be better to
> > try to make the regression test object names more meaningful where
> > possible (though sometimes it won't be). The xxx1, xxx2, and xxx3
> > become harder to read as more gets added.
> >
> > e.g. `regress_pub_seq3` -- What does 'pub' mean here? This is an
> > unlogged sequence you want to exclude.
> > e.g. `regress_pub_forallsequences4` -- Doesn't mean much.
> > e.g. `tab_seq` -- This is meant to be a plain table; Not a table
> > pretending to be a seq.
> >
> > Below is an example of some modifications, but there are many more.
> > Consider checking all the names to see if they can be improved
> > (sometimes you may be stuck having to accommodate existing names).
> > (same comment applies to both patches).
> >
> > ~~~
> >
> > BEFORE
> > +-- fail - unlogged sequence is specified in EXCEPT sequence list
> > +CREATE UNLOGGED SEQUENCE regress_pub_seq3;
> > +CREATE PUBLICATION regress_pub_forallsequences4 FOR ALL SEQUENCES
> > EXCEPT (SEQUENCE regress_pub_seq3);
> > +
> > +-- fail - temporary sequence is specified in EXCEPT sequence list
> > +CREATE TEMPORARY SEQUENCE regress_pub_seq4;
> > +CREATE PUBLICATION regress_pub_forallsequences4 FOR ALL SEQUENCES
> > EXCEPT (SEQUENCE regress_pub_seq4);
> > +
> > +-- fail - sequence object is specified in EXCEPT table list
> > +CREATE PUBLICATION regress_pub_forallsequences4 FOR ALL TABLES EXCEPT
> > (TABLE regress_pub_seq0);
> > +
> > +-- fail - table object is specified in EXCEPT sequence list
> > +CREATE TABLE tab_seq(a int);
> > +CREATE PUBLICATION regress_pub_forallsequences4 FOR ALL SEQUENCES
> > EXCEPT (SEQUENCE tab_seq);
> > +
> >
> >
> > SUGGESTION
> > +-- fail - unlogged sequence is specified in EXCEPT sequence list
> > +CREATE UNLOGGED SEQUENCE regress_seq_unlogged;
> > +CREATE PUBLICATION regress_pub_should_fail FOR ALL SEQUENCES EXCEPT
> > (SEQUENCE regress_seq_unlogged);
> > +
> > +-- fail - temporary sequence is specified in EXCEPT sequence list
> > +CREATE TEMPORARY SEQUENCE regress_seq_temp;
> > +CREATE PUBLICATION regress_pub_should_fail FOR ALL SEQUENCES EXCEPT
> > (SEQUENCE regress_seq_temp);
> > +
> > +-- fail - sequence object is specified in EXCEPT table list
> > +CREATE PUBLICATION regress_pub_should_fail FOR ALL TABLES EXCEPT
> > (TABLE regress_seq1);
> > +
> > +-- fail - table object is specified in EXCEPT sequence list
> > +CREATE TABLE tab1(a int);
> > +CREATE PUBLICATION regress_pub_should_fail FOR ALL SEQUENCES EXCEPT
> > (SEQUENCE tab1);
> > +
> >
> I agree with your suggestions, I have made the changes.
> I have also made changes for other objects as well in publication.sql
> and 037_except.pl files.
>
> I also agree with the suggestions by Shveta in [1] and made the
> required changes.
>
> Please find the updated v15 patch attached.
>

+ /* TODO : Add a version check for PG 20 */
+ if (pset.sversion >=3D 190000)
+ {
+ /* Get sequences in the EXCEPT clause for this publication */
+ printfPQExpBuffer(&buf, "/* %s */\n",
+   _("Get sequences excluded by this publication"));
+ printfPQExpBuffer(&buf,
+   "SELECT n.nspname || '.' || c.relname\n"
+   "FROM pg_catalog.pg_class c\n"
+   "     JOIN pg_catalog.pg_namespace n ON n.oid =3D c.relnamespace\n"
+   "     JOIN pg_catalog.pg_publication_rel pr ON c.oid =3D pr.prrelid\n"
+   "WHERE pr.prpubid =3D '%s' AND pr.prexcept AND c.relkind =3D 'S'\n"
+   "ORDER BY 1", pubid);
+ if (!addFooterToPublicationDesc(&buf, _("Except sequences:"),
+ true, &cont))
+ goto error_return;
+ }
+ }

I've few questions related to above change:

1) Should the second printfPQExpBuffer() be appendPQExpBuffer()? As
written, it overwrites the query comment added just above, so psql -E
will not show "Get sequences excluded by this publication".

2) The above query may work on PG 19, but since the feature is going
to be part of PG20, why do you want this query to be part of PG19?

--

Do we also need to include a tap test for "ALTER PUBLICATION ... SET
ALL SEQUENCES EXCEPT (...)" followed by "ALTER SUBSCRIPTION ...
REFRESH SEQUENCES", and then sequence replication behavior is
verified?

--
With Regards,
Ashutosh Sharma.