MIME-Version: 1.0
References: <CANNMO++9W_UA8PB9AkDRF3JBv4K7K1FnisrXTjicL+WZhwUJzw@mail.gmail.com>
 <CA+TgmoZF7PbO7DB_VMQS4664EgOdObhFtAoLUb83bp3i-623UQ@mail.gmail.com>
 <CANNMO++d9CKuJEzSnRWFCHcmKr2DGASTtEMZ9bpEYHSa4QFQvA@mail.gmail.com>
 <3076356.1730831425@sss.pgh.pa.us> <CANNMO++W7MM8T0KyXN3ZheXXt-uLVM3aEtZd+WNfZ=obxffUiA@mail.gmail.com>
 <CAKFQuwbLq3GWoJw-zNa43pkcfg5gh4gGQKMptQtp4qX_nQL9AQ@mail.gmail.com>
 <CAApHDvrYwEt=ueMTn39okNihZffhKgqvxedLqDJu=hmSsZ=g9Q@mail.gmail.com>
 <CAFwT4nC5255GkSt1WEfTHi6cwUuY4fjUmH15nD91c1JvNoOxNA@mail.gmail.com>
 <CAECtzeUKbyZNuFRu4DTr_3p44egDXGbPpGonixqJninWXyBvnQ@mail.gmail.com>
 <CA+TgmobY4N3QYWTW4bj9K=gG3Q4rTAsZLvi_=ODZYRBpk=ZVNA@mail.gmail.com>
 <CAECtzeVvrjxXmE3TB9zz3MD_RwiE=MCg2Xjx0HXoSn4e-VRSOg@mail.gmail.com>
 <CAECtzeWpusNrZADkQ01ZZL_fFtOWtwtnw_uixqy9hgK0qUCScQ@mail.gmail.com>
 <CA+TgmoZO2HtDGHf7K4rmNdfUGuS=ngsPgwrH=JdyF6Okcnzfkw@mail.gmail.com>
 <CAECtzeW=yo4H-G8rBheWwiET-e+PaBpOHHaL9Yu0JpYTd557_Q@mail.gmail.com>
 <CAKAnmmLOkvJ85MGyouFBr2tS+0TSZ87=t=8iaZKU25WG98nZaw@mail.gmail.com>
 <CAECtzeUwpK5gNWQqoK4ZjwXANtdE2fWirJyaBDqkytPzfWZqzg@mail.gmail.com>
 <CAKAnmm+QQP-dTkjsDVbEcphrdXqCTq-ALTCMUwPaYWZmqUp=NQ@mail.gmail.com>
 <CAECtzeVkkmvmHWVOTzwpX_GX+k4h7EWAyfERqes9C0z4pzMN2A@mail.gmail.com> <CAApHDvpj0Cj6Z8VnDN5htzF24b4_hKL+1_n=HOehLHkBK_E_TQ@mail.gmail.com>
In-Reply-To: <CAApHDvpj0Cj6Z8VnDN5htzF24b4_hKL+1_n=HOehLHkBK_E_TQ@mail.gmail.com>
From: Guillaume Lelarge <guillaume@lelarge.info>
Date: Tue, 10 Dec 2024 13:22:38 +0100
Message-ID: <CAECtzeUWiA+FNq0qGp94Ez4UAwbEZyB7avTqKDs6wkPhU56mpw@mail.gmail.com>
Subject: Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
To: David Rowley <dgrowleyml@gmail.com>
Cc: Greg Sabino Mullane <htamfids@gmail.com>, Robert Haas <robertmhaas@gmail.com>, 
	Michael Christofides <michael@pgmustard.com>, "David G. Johnston" <david.g.johnston@gmail.com>, 
	Nikolay Samokhvalov <samokhvalov@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000137c6b0628e98ae0"
Archived-At: <https://www.postgresql.org/message-id/CAECtzeUWiA%2BFNq0qGp94Ez4UAwbEZyB7avTqKDs6wkPhU56mpw%40mail.gmail.com>
Precedence: bulk

--000000000000137c6b0628e98ae0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Le mar. 10 d=C3=A9c. 2024 =C3=A0 03:57, David Rowley <dgrowleyml@gmail.com>=
 a =C3=A9crit :

> On Thu, 21 Nov 2024 at 08:30, Guillaume Lelarge <guillaume@lelarge.info>
> wrote:
> > OK, I'm fine with this. v4 patch attached with one plan showing read,
> written, and dirtied buffers.
>
> Today I spent more time polishing this patch. There were a few cases
> in the docs that displayed EXPLAIN ANALYZE output that you'd not
> adjusted to include the buffers output or adjusted to do BUFFERS OFF.
> I think I've got all these now. Tom went to some effort to fix some
> outdated EXPLAIN outputs for v17 in 5caa05749, so I think we owe it to
> him not to let these go out of date so soon after that change.
>
>
You're right and I completely forgot to check the whole documentation. I
just looked at perform.sgml which was the obvious file for explain plans.
Anyway, sorry about this, and thanks a lot for your work on this patch.

I also was thinking again about what Robert mentioned about
> auto_explain.log_buffers should now also be on by default.  I'm less
> certain than him about this change. It seems like a separate
> consideration that we could apply many of the same arguments for the
> main change to.  In any case, I extracted that change from the 0001
> patch and put it in a 0002 patch as it doesn't seem like something
> that should be a sidenote in the commit message. I felt doing that
> increases the chances that it would be overlooked in the release
> notes.
>
> I was very close to pushing 0001 today, but will hold off until
> tomorrow to see if anyone has final comments.
>
>
No more comments. I'm fine with both patches.


> For 0002, I'd really like to see a bit more justification for it.  For
> the record, I'm not against 0002, it's just that my personal arguments
> for wanting 0001 don't apply to 0002.
>
>
I guess consistency is the key word here. But I agree that 0001 is the one
that's really important to me.

Thanks again for your work on this.


--=20
Guillaume.

--000000000000137c6b0628e98ae0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hello,<br></div><br><div class=3D"gmail_q=
uote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">Le=C2=A0m=
ar. 10 d=C3=A9c. 2024 =C3=A0=C2=A003:57, David Rowley &lt;<a href=3D"mailto=
:dgrowleyml@gmail.com">dgrowleyml@gmail.com</a>&gt; a =C3=A9crit=C2=A0:<br>=
</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b=
order-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, 21 Nov 2024=
 at 08:30, Guillaume Lelarge &lt;<a href=3D"mailto:guillaume@lelarge.info" =
target=3D"_blank">guillaume@lelarge.info</a>&gt; wrote:<br>
&gt; OK, I&#39;m fine with this. v4 patch attached with one plan showing re=
ad, written, and dirtied buffers.<br>
<br>
Today I spent more time polishing this patch. There were a few cases<br>
in the docs that displayed EXPLAIN ANALYZE output that you&#39;d not<br>
adjusted to include the buffers output or adjusted to do BUFFERS OFF.<br>
I think I&#39;ve got all these now. Tom went to some effort to fix some<br>
outdated EXPLAIN outputs for v17 in 5caa05749, so I think we owe it to<br>
him not to let these go out of date so soon after that change.<br>
<br></blockquote><div><br></div><div>You&#39;re right and I completely forg=
ot to check the whole documentation. I just looked at perform.sgml which wa=
s the obvious file for explain plans. Anyway, sorry about this, and thanks =
a lot for your work on this patch.<br></div><div><br></div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex">
I also was thinking again about what Robert mentioned about<br>
auto_explain.log_buffers should now also be on by default.=C2=A0 I&#39;m le=
ss<br>
certain than him about this change. It seems like a separate<br>
consideration that we could apply many of the same arguments for the<br>
main change to.=C2=A0 In any case, I extracted that change from the 0001<br=
>
patch and put it in a 0002 patch as it doesn&#39;t seem like something<br>
that should be a sidenote in the commit message. I felt doing that<br>
increases the chances that it would be overlooked in the release<br>
notes.<br>
<br>
I was very close to pushing 0001 today, but will hold off until<br>
tomorrow to see if anyone has final comments.<br>
<br></blockquote><div><br></div><div>No more comments. I&#39;m fine with bo=
th patches.</div><div>=C2=A0<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">
For 0002, I&#39;d really like to see a bit more justification for it.=C2=A0=
 For<br>
the record, I&#39;m not against 0002, it&#39;s just that my personal argume=
nts<br>
for wanting 0001 don&#39;t apply to 0002.<br>
<br></blockquote><div><br></div><div>I guess consistency is the key word he=
re. But I agree that 0001 is the one that&#39;s really important to me.</di=
v><div><br></div><div>Thanks again for your work on this.<br></div></div><d=
iv class=3D"gmail_quote gmail_quote_container"><br></div><div class=3D"gmai=
l_quote gmail_quote_container"><br></div><span class=3D"gmail_signature_pre=
fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l=
tr"><div><div dir=3D"ltr"><div>Guillaume.<br></div></div></div></div></div>=
</div>

--000000000000137c6b0628e98ae0--