MIME-Version: 1.0
References: <CANNMO++9W_UA8PB9AkDRF3JBv4K7K1FnisrXTjicL+WZhwUJzw@mail.gmail.com>
 <CA+TgmoZF7PbO7DB_VMQS4664EgOdObhFtAoLUb83bp3i-623UQ@mail.gmail.com>
 <CANNMO++d9CKuJEzSnRWFCHcmKr2DGASTtEMZ9bpEYHSa4QFQvA@mail.gmail.com>
 <3076356.1730831425@sss.pgh.pa.us> <CANNMO++W7MM8T0KyXN3ZheXXt-uLVM3aEtZd+WNfZ=obxffUiA@mail.gmail.com>
 <CAKFQuwbLq3GWoJw-zNa43pkcfg5gh4gGQKMptQtp4qX_nQL9AQ@mail.gmail.com>
 <CAApHDvrYwEt=ueMTn39okNihZffhKgqvxedLqDJu=hmSsZ=g9Q@mail.gmail.com>
 <CAFwT4nC5255GkSt1WEfTHi6cwUuY4fjUmH15nD91c1JvNoOxNA@mail.gmail.com>
 <CAECtzeUKbyZNuFRu4DTr_3p44egDXGbPpGonixqJninWXyBvnQ@mail.gmail.com>
 <CA+TgmobY4N3QYWTW4bj9K=gG3Q4rTAsZLvi_=ODZYRBpk=ZVNA@mail.gmail.com>
 <CAECtzeVvrjxXmE3TB9zz3MD_RwiE=MCg2Xjx0HXoSn4e-VRSOg@mail.gmail.com>
 <CAECtzeWpusNrZADkQ01ZZL_fFtOWtwtnw_uixqy9hgK0qUCScQ@mail.gmail.com>
 <CA+TgmoZO2HtDGHf7K4rmNdfUGuS=ngsPgwrH=JdyF6Okcnzfkw@mail.gmail.com>
 <CAECtzeW=yo4H-G8rBheWwiET-e+PaBpOHHaL9Yu0JpYTd557_Q@mail.gmail.com>
 <CAKAnmmLOkvJ85MGyouFBr2tS+0TSZ87=t=8iaZKU25WG98nZaw@mail.gmail.com>
 <CAECtzeUwpK5gNWQqoK4ZjwXANtdE2fWirJyaBDqkytPzfWZqzg@mail.gmail.com>
 <CAKAnmm+QQP-dTkjsDVbEcphrdXqCTq-ALTCMUwPaYWZmqUp=NQ@mail.gmail.com>
 <CAECtzeVkkmvmHWVOTzwpX_GX+k4h7EWAyfERqes9C0z4pzMN2A@mail.gmail.com>
 <CAApHDvpj0Cj6Z8VnDN5htzF24b4_hKL+1_n=HOehLHkBK_E_TQ@mail.gmail.com>
 <CAECtzeUWiA+FNq0qGp94Ez4UAwbEZyB7avTqKDs6wkPhU56mpw@mail.gmail.com>
 <CAApHDvqjmr=CZ2M57eErxn2Ubcb0d2EmppZhTj8k==Ud_eRfoQ@mail.gmail.com> <CAApHDvqLdzgz77JsE-yTki3w9UiKQ-uTMLRctazcu+99-ips3g@mail.gmail.com>
In-Reply-To: <CAApHDvqLdzgz77JsE-yTki3w9UiKQ-uTMLRctazcu+99-ips3g@mail.gmail.com>
From: Guillaume Lelarge <guillaume@lelarge.info>
Date: Wed, 11 Dec 2024 13:41:09 +0100
Message-ID: <CAECtzeW38Dq89womdATHnwR7c0sv1FxaT6k8c_9xUGjmQnkAHg@mail.gmail.com>
Subject: Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
To: David Rowley <dgrowleyml@gmail.com>
Cc: Greg Sabino Mullane <htamfids@gmail.com>, Robert Haas <robertmhaas@gmail.com>, 
	Michael Christofides <michael@pgmustard.com>, "David G. Johnston" <david.g.johnston@gmail.com>, 
	Nikolay Samokhvalov <samokhvalov@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="0000000000003592d20628fdeab7"
Archived-At: <https://www.postgresql.org/message-id/CAECtzeW38Dq89womdATHnwR7c0sv1FxaT6k8c_9xUGjmQnkAHg%40mail.gmail.com>
Precedence: bulk

--0000000000003592d20628fdeab7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Le mer. 11 d=C3=A9c. 2024 =C3=A0 12:16, David Rowley <dgrowleyml@gmail.com>=
 a =C3=A9crit :

> On Wed, 11 Dec 2024 at 22:38, David Rowley <dgrowleyml@gmail.com> wrote:
> > I've pushed the main patch. I'm not planning on pushing the
> > auto_explain.log_buffers default change unless there's a bit more
> > discussion about it.
>
> There were a few places that were missing a BUFFERS OFF as indicated
> by the buildfarm. I've fixed a few of these, but there's at least one
> more in pg_stat_statements's level_tracking.sql. I'm currently running
> a -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE enabled make
> check-world.  It's going to take a while, so I'll hold off doing yet
> another commit to fix these until I see if the level_tracking.sql one
> is the last issue to fix.
>
>
Sorry for all those late fixes. I'll refrain from saying "Sure looks easy
enough to do" from now on :) Guess this is a great example of what Robert
said in
http://rhaas.blogspot.com/2024/05/hacking-on-postgresql-is-really-hard.html
.

Anyway, thanks again for your work on this.


--=20
Guillaume.

--0000000000003592d20628fdeab7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div dir=
=3D"ltr" class=3D"gmail_attr">Le=C2=A0mer. 11 d=C3=A9c. 2024 =C3=A0=C2=A012=
:16, David Rowley &lt;<a href=3D"mailto:dgrowleyml@gmail.com">dgrowleyml@gm=
ail.com</a>&gt; a =C3=A9crit=C2=A0:<br></div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex">On Wed, 11 Dec 2024 at 22:38, David Rowley &lt;<a href=
=3D"mailto:dgrowleyml@gmail.com" target=3D"_blank">dgrowleyml@gmail.com</a>=
&gt; wrote:<br>
&gt; I&#39;ve pushed the main patch. I&#39;m not planning on pushing the<br=
>
&gt; auto_explain.log_buffers default change unless there&#39;s a bit more<=
br>
&gt; discussion about it.<br>
<br>
There were a few places that were missing a BUFFERS OFF as indicated<br>
by the buildfarm. I&#39;ve fixed a few of these, but there&#39;s at least o=
ne<br>
more in pg_stat_statements&#39;s level_tracking.sql. I&#39;m currently runn=
ing<br>
a -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE enabled make<br>
check-world.=C2=A0 It&#39;s going to take a while, so I&#39;ll hold off doi=
ng yet<br>
another commit to fix these until I see if the level_tracking.sql one<br>
is the last issue to fix.<br>
<br></blockquote><div><br></div><div>Sorry for all those late fixes. I&#39;=
ll refrain from saying &quot;Sure looks easy enough to do&quot; from now on=
 :) Guess this is a great example of what Robert said in=C2=A0<a href=3D"ht=
tp://rhaas.blogspot.com/2024/05/hacking-on-postgresql-is-really-hard.html">=
http://rhaas.blogspot.com/2024/05/hacking-on-postgresql-is-really-hard.html=
</a> .</div><div><br></div><div>Anyway, thanks again for your work on this.=
<br></div></div><div class=3D"gmail_quote gmail_quote_container"><br></div>=
<div class=3D"gmail_quote gmail_quote_container"><br></div><span class=3D"g=
mail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signat=
ure"><div dir=3D"ltr"><div><div dir=3D"ltr"><div>Guillaume.<br></div></div>=
</div></div></div></div>

--0000000000003592d20628fdeab7--