public inbox for [email protected]  

help / color / mirror / Atom feed

From: J F <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: Contributing test cases to improve coverage
Date: Wed, 12 Jun 2024 20:51:48 +0100
Message-ID: <CAEFLKGjncwibWsaoTwfaOKJt2AkgT5V4PHQVZ8=bWWUxNZFpgQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAEFLKGhVEP4_N4T4KQ75av7CEJreJpY1j2T+Dxq96dyJ1khBhg@mail.gmail.com>
	<[email protected]>

> I am quite confused about what is the point of this.  You have not
> found any actual bug, nor have you demonstrated that this test case
> could discover a likely future bug that wouldn't be detected another
> way.  Moreover, it seems like the process would lead to some very
> large number of equally marginal test cases.  We aren't likely to
> accept such a patch, because we are concerned about keeping down the
> runtime of the test suite.
>
>                        regards, tom lane


The point of this project is to improve the coverage of PostgreSQL’s
preexisting test suite. Writing a test suite to achieve close to 100%
coverage is challenging, but I have proposed a workflow to automate this
process.

I assert that no test case in the regression test suite currently covers
the comparator in the expression rte->rtekind == RTE_SUBQUERY. I propose
adding a new test case that addresses exactly this. In the future, if
someone accidentally modifies the operator to become >=, it will trigger
incorrect behavior when certain queries are executed. This test case will
catch that issue.

I get that the test cases in /regress are likely reserved for actual bugs
found and are designed to run quickly. Would it be a good idea to have a
separate, more rigorous test suite that runs longer but provides better
code coverage?

Regards,
Jon

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Contributing test cases to improve coverage
  In-Reply-To: <CAEFLKGjncwibWsaoTwfaOKJt2AkgT5V4PHQVZ8=bWWUxNZFpgQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox