MIME-Version: 1.0
References: <CAEG8a3K_mZsBZ60smh4FM4Dk9cazAUmM72iXdFKEHgthZnaHcw@mail.gmail.com>
 <57c12c52-123c-4a13-a258-02639473fa17@dunslane.net> <dfd66b40-4b8d-4239-bbca-01d3e431ca5b@eisentraut.org>
In-Reply-To: <dfd66b40-4b8d-4239-bbca-01d3e431ca5b@eisentraut.org>
From: Junwang Zhao <zhjwpku@gmail.com>
Date: Sun, 4 Aug 2024 10:07:40 +0800
Message-ID: <CAEG8a3+av_p4fLA=dAAp1U7nMckt+D=qjEOVxqOio39u48qEkQ@mail.gmail.com>
Subject: Re: Official devcontainer config
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Andrew Dunstan <andrew@dunslane.net>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andrey Borodin <amborodin86@gmail.com>, 
	Jelte Fennema-Nio <postgres@jeltef.nl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAEG8a3%2Bav_p4fLA%3DdAAp1U7nMckt%2BD%3DqjEOVxqOio39u48qEkQ%40mail.gmail.com>
Precedence: bulk

On Sat, Aug 3, 2024 at 2:45=E2=80=AFAM Peter Eisentraut <peter@eisentraut.o=
rg> wrote:
>
> On 01.08.24 23:38, Andrew Dunstan wrote:
> > Not totally opposed, and I will probably give it a try very soon, but
> > I'm wondering if this really needs to go in the core repo. We've
> > generally shied away from doing much in the way of editor / devenv
> > support, trying to be fairly agnostic. It's true we carry .dir-locals.e=
l
> > and .editorconfig, so that's not entirely true, but those are really
> > just about supporting our indentation etc. standards.
>
> Yeah, the editor support in the tree ought to be minimal and factual,
> based on coding standards and widely recognized best practices, not a
> collection of one person's favorite aliases and scripts.  If the scripts
> are good, let's look at them and maybe put them under src/tools/ for
> everyone to use.  But a lot of this looks like it will requite active
> maintenance if output formats or node formats or build targets etc.
> change.  And other things require specific local paths.  That's fine for
> a local script or something, but not for a mainline tool that the
> community will need to maintain.

Yeah, personal favorite aliases and scripts are not good, that
also concerns me, I will delete those parts in future patches.

>
> I suggest to start with a very minimal configuration. What are the
> settings that absolute everyone will need, maybe to set indentation
> style or something.
>

Yeah, reasonable, I will discuss it with Andrey after he tries .devcontaine=
r.

--=20
Regards
Junwang Zhao