MIME-Version: 1.0
References: <CABBtG=d1Kkmi67VdM=jGaYkQ0+WGbhZpxwa3ms0s1DB_J_9Jww@mail.gmail.com>
 <b4da130f-35ae-4506-b6f5-b904b7cfe20a@tantorlabs.com>
In-Reply-To: <b4da130f-35ae-4506-b6f5-b904b7cfe20a@tantorlabs.com>
From: Junwang Zhao <zhjwpku@gmail.com>
Date: Tue, 15 Oct 2024 18:55:50 +0800
Message-ID: <CAEG8a3+o7Eh_6L+YA0vTXnNMcF1hgb3uRD7kRk+oUNhpf4+nQg@mail.gmail.com>
Subject: Re: Use function smgrclose() to replace the loop
To: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Cc: Steven Niu <niushiji@gmail.com>, pgsql-hackers@lists.postgresql.org, 
	Kirill Reshke <reshkekirill@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAEG8a3%2Bo7Eh_6L%2BYA0vTXnNMcF1hgb3uRD7kRk%2BoUNhpf4%2BnQg%40mail.gmail.com>
Precedence: bulk

On Mon, Oct 14, 2024 at 6:30=E2=80=AFPM Ilia Evdokimov
<ilya.evdokimov@tantorlabs.com> wrote:
>
>
> On 14.08.2024 09:32, Steven Niu wrote:
> > Hi, Kirill, Junwang,
> >
> > I made this patch to address the refactor issue in our previous email
> > discussion.
> > https://www.postgresql.org/message-id/flat/CABBtG=3DcDTCBDCBK7McSy6bJR3=
s5xUTOg0vSFfuW8oLdUYyCscA@mail.gmail.com
> >
> >
> > That is, the for loop in function smgrdestroy() and smgrdounlinkall
> > can be replaced with smgrclose().
> >
> > for (forknum =3D 0; forknum <=3D MAX_FORKNUM; forknum++)
> >     smgrsw[reln->smgr_which].smgr_close(reln, forknum);
> > -->
> > smgrclose(rels[i]);
> >
> > Please let me know if you have any questions.
> >
> > Best Regards,
> > Steven from Highgo.com
>
> Hello,
>
> Are you sure we can refactor loop by 'smgrclose()'? I see it is not
> quite the same.

smgrclose does more by setting smgr_cached_nblocks[] and smgr_targblock
to InvalidBlockNumber, I see no harm with the replacement, not 100% sure
though.

>
> Regards,
> Ilia Evdokimov,
> Tantor Labs LLC.
>


--=20
Regards
Junwang Zhao