MIME-Version: 1.0
References: <CAEG8a3K_mZsBZ60smh4FM4Dk9cazAUmM72iXdFKEHgthZnaHcw@mail.gmail.com>
 <57c12c52-123c-4a13-a258-02639473fa17@dunslane.net> <dfd66b40-4b8d-4239-bbca-01d3e431ca5b@eisentraut.org>
 <f1ab7b6f-2a22-41ff-bcc0-885bd65e550d@dunslane.net> <CAEG8a3L6Bhk=6p9k7REG193Wfp_Sxfo3SjAwuyG10Z04dWCTdg@mail.gmail.com>
 <d7399b1f-a59b-4ff3-b3ac-f82439e3f261@dunslane.net>
In-Reply-To: <d7399b1f-a59b-4ff3-b3ac-f82439e3f261@dunslane.net>
From: Junwang Zhao <zhjwpku@gmail.com>
Date: Sat, 24 Aug 2024 20:49:34 +0800
Message-ID: <CAEG8a3J_kvvRFswpcgO0EGD3h5LLsPMOa6+4BaJskfJ0hHGsyw@mail.gmail.com>
Subject: Re: Official devcontainer config
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Peter Eisentraut <peter@eisentraut.org>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andrey Borodin <amborodin86@gmail.com>, 
	Jelte Fennema-Nio <postgres@jeltef.nl>
Content-Type: multipart/mixed; boundary="0000000000009bafad06206d5355"
Archived-At: <https://www.postgresql.org/message-id/CAEG8a3J_kvvRFswpcgO0EGD3h5LLsPMOa6%2B4BaJskfJ0hHGsyw%40mail.gmail.com>
Precedence: bulk

--0000000000009bafad06206d5355
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi hackers,

On Sun, Aug 4, 2024 at 10:12=E2=80=AFPM Andrew Dunstan <andrew@dunslane.net=
> wrote:
>
>
> On 2024-08-03 Sa 10:13 PM, Junwang Zhao wrote:
> > On Sat, Aug 3, 2024 at 7:30=E2=80=AFPM Andrew Dunstan <andrew@dunslane.=
net> wrote:
> >>
> >> On 2024-08-02 Fr 2:45 PM, Peter Eisentraut wrote:
> >>> On 01.08.24 23:38, Andrew Dunstan wrote:
> >>>> Not totally opposed, and I will probably give it a try very soon, bu=
t
> >>>> I'm wondering if this really needs to go in the core repo. We've
> >>>> generally shied away from doing much in the way of editor / devenv
> >>>> support, trying to be fairly agnostic. It's true we carry
> >>>> .dir-locals.el and .editorconfig, so that's not entirely true, but
> >>>> those are really just about supporting our indentation etc. standard=
s.
> >>> Yeah, the editor support in the tree ought to be minimal and factual,
> >>> based on coding standards and widely recognized best practices, not a
> >>> collection of one person's favorite aliases and scripts.  If the
> >>> scripts are good, let's look at them and maybe put them under
> >>> src/tools/ for everyone to use.  But a lot of this looks like it will
> >>> requite active maintenance if output formats or node formats or build
> >>> targets etc. change.  And other things require specific local paths.
> >>> That's fine for a local script or something, but not for a mainline
> >>> tool that the community will need to maintain.
> >>>
> >>> I suggest to start with a very minimal configuration. What are the
> >>> settings that absolute everyone will need, maybe to set indentation
> >>> style or something.
> >>>
> >> I believe you can get VS Code to support editorconfig, so from that PO=
V
> >> maybe we don't need to do anything.
> >>
> >> I did try yesterday with the code from the OP's patch symlinked into m=
y
> >> repo, but got an error with the Docker build, which kinda reinforces
> >> your point.
> > The reason symlink does not work is that configure_vscode needs to copy
> > launch.json and tasks.json into .vscode, it has to be in the
> > WORKDIR/.devcontainer.
>
>
> That's kind of awful. Anyway, I think we don't need to do anything about
> ignoring those. The user should simply add entries for them to
> .git/info/exclude or their local global exclude file (I have
> core.excludesfile =3D /home/andrew/.gitignore set.)
>
> I was eventually able to get it to work without using a symlink.
>
>
> cheers
>
>
> andrew
>
>
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
>

I did some work on the **devcontainer config** today, hoping this can
address some of the concerns raised on this thread.

1. I created a separate git repo named **Unofficial devcontainer
config for Postgres**[1].
2. The usage is quite simple, clone the repo directly into postgres's tree =
root,
    and reopen in DevContainer (See REAME in [1] if you are interested).
3. Using Tristan's vscode code extension postgres-hacker as the formatter,
    pgindent will be called on file save, I found this quite convenient.
4. Remove the git settings, Dev container copies the global
~/.gitconfig into the container
    by default, so normally it is not necessary to add extra git aliases.

What I haven't addressed is that the repo still uses specific local
paths, I think
this is ok since the code is not going into the core.

One thing I want to ask is, is there any objection to adding the
.devcontainer and .vscode to the .gitignore file?

There are *.vcproj and pgsql.sln in .gitignore, so I guess it's ok to add
.devcontainer and .vscode?

[1]: https://github.com/pghacking/.devcontainer

--=20
Regards
Junwang Zhao

--0000000000009bafad06206d5355
Content-Type: application/octet-stream; 
	name="v1-0001-add-.devcontainer-and-.vscode-to-.gitignore.patch"
Content-Disposition: attachment; 
	filename="v1-0001-add-.devcontainer-and-.vscode-to-.gitignore.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m084zp180>
X-Attachment-Id: f_m084zp180

RnJvbSBmY2MwOGQwZjQ3ZTU3MzViYzI1NTAxMTY1MmFjNzZiODFkMWJhZTk5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBaaGFvIEp1bndhbmcgPHpoandwa3VAZ21haWwuY29tPgpEYXRl
OiBTYXQsIDI0IEF1ZyAyMDI0IDEyOjQzOjU0ICswMDAwClN1YmplY3Q6IFtQQVRDSCB2MV0gYWRk
IC5kZXZjb250YWluZXIgYW5kIC52c2NvZGUgdG8gLmdpdGlnbm9yZQoKLS0tCiAuZ2l0aWdub3Jl
IHwgMiArKwogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhLy5n
aXRpZ25vcmUgYi8uZ2l0aWdub3JlCmluZGV4IDRlOTExMzk1ZmUuLjJlZmUxYzI0YjAgMTAwNjQ0
Ci0tLSBhLy5naXRpZ25vcmUKKysrIGIvLmdpdGlnbm9yZQpAQCAtNDMsMyArNDMsNSBAQCBsaWIq
LnBjCiAvUmVsZWFzZS8KIC90bXBfaW5zdGFsbC8KIC9wb3J0bG9jay8KKy5kZXZjb250YWluZXIv
CisudnNjb2RlLwotLSAKMi4zOS4yCgo=
--0000000000009bafad06206d5355--