public inbox for [email protected]  

help / color / mirror / Atom feed

From: Junwang Zhao <[email protected]>
To: SATYANARAYANA NARLAPURAM <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Subject: Re: [PATCH] Resolve unknown-type literals in GRAPH_TABLE COLUMNS
Date: Sun, 26 Apr 2026 23:10:24 +0800
Message-ID: <CAEG8a3KTP1sX+RbPFNST4kHdeRZQR5-dd6kEihV56=K5irrhyQ@mail.gmail.com> (raw)
In-Reply-To: <CAHg+QDcyKNWyzDoKMxiZNjv7C-wAxs8y0ZoNkOV137Y+nk3UXg@mail.gmail.com>
References: <CAHg+QDcyKNWyzDoKMxiZNjv7C-wAxs8y0ZoNkOV137Y+nk3UXg@mail.gmail.com>

Hi SATYANARAYANA,

On Sun, Apr 26, 2026 at 3:53 AM SATYANARAYANA NARLAPURAM
<[email protected]> wrote:
>
> Hi hackers,
>
> transformRangeGraphTable() calls transformExpr() and
> assign_list_collations() for COLUMNS expressions but missed calling
> resolveTargetListUnknowns(). As a result, literals such as 'val1'
> in a COLUMNS clause retained type "unknown", causing failures with
> ORDER BY, UNION, and output conversions.
>
> Fix by calling resolveTargetListUnknowns() on the columns target
> list right after assign_list_collations(), similar to SELECT target lists in
> transformSelectStmt().
>
> Attached a patch to fix this, which also includes test cases to reproduce.

I can reproduce this and the patch fixes it.

One question: why is resolveTargetListUnknowns called after
assign_list_collations?

I'm asking because in transformSelectStmt, resolveTargetListUnknowns
is invoked before assign_query_collations. It might not matter, but keeping
the order consistent would be good for readers.

>
>
> Thanks,
> Satya
>
>


-- 
Regards
Junwang Zhao

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Resolve unknown-type literals in GRAPH_TABLE COLUMNS
  In-Reply-To: <CAEG8a3KTP1sX+RbPFNST4kHdeRZQR5-dd6kEihV56=K5irrhyQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox