MIME-Version: 1.0
References: <b3a73eca-ec3b-4b64-b6c2-82418bb16701@manitou-mail.org>
 <b7d8c88b-d175-44ca-a323-ec2f5c3cd37d@joeconway.com>
 <8620df11-96e4-4ca3-8f3c-33a479260961@joeconway.com>
 <4162f7f7-6fd6-4720-98e2-89f80e3de2ed@joeconway.com>
 <CAD21AoCb02zhZM3vXb8HSw8fwOsL+iRdEFb--Kmunv8PjPAWjw@mail.gmail.com>
 <CACJufxEh0QWok=XZTgFksSYSKLgkidud4cXJvJPxbTzVAsniPA@mail.gmail.com>
 <CAEG8a3KT+UXo78qoy9EZkp96BFTojuiALQvB8wsJhWV0CCreQQ@mail.gmail.com>
 <CALDaNm3Fq=r04XbFcqUS3AXs0EO3ta7sceKr8jmPjK8wrNH2ZA@mail.gmail.com>
In-Reply-To: 
 <CALDaNm3Fq=r04XbFcqUS3AXs0EO3ta7sceKr8jmPjK8wrNH2ZA@mail.gmail.com>
From: Junwang Zhao <zhjwpku@gmail.com>
Date: Wed, 31 Jan 2024 17:58:00 +0800
Message-ID: 
 <CAEG8a3LrzG=yjF9TO-e+_ZtOfUrLo_UJ0fmJpLMwr5py2NGFLQ@mail.gmail.com>
Subject: Re: Emitting JSON to file using COPY TO
To: vignesh C <vignesh21@gmail.com>
Cc: jian he <jian.universality@gmail.com>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
	Joe Conway <mail@joeconway.com>, Daniel Verite <daniel@manitou-mail.org>,
	Andrew Dunstan <andrew@dunslane.net>, Davin Shearer <davin@apache.org>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Sutou Kouhei <kou@clear-code.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAEG8a3LrzG%3DyjF9TO-e%2B_ZtOfUrLo_UJ0fmJpLMwr5py2NGFLQ%40mail.gmail.com>
Precedence: bulk

Hi Vignesh,

On Wed, Jan 31, 2024 at 5:50=E2=80=AFPM vignesh C <vignesh21@gmail.com> wro=
te:
>
> On Sat, 27 Jan 2024 at 11:25, Junwang Zhao <zhjwpku@gmail.com> wrote:
> >
> > Hi hackers,
> >
> > Kou-san(CCed) has been working on *Make COPY format extendable[1]*, so
> > I think making *copy to json* based on that work might be the right dir=
ection.
> >
> > I write an extension for that purpose, and here is the patch set togeth=
er
> > with Kou-san's *extendable copy format* implementation:
> >
> > 0001-0009 is the implementation of extendable copy format
> > 00010 is the pg_copy_json extension
> >
> > I also created a PR[2] if anybody likes the github review style.
> >
> > The *extendable copy format* feature is still being developed, I post t=
his
> > email in case the patch set in this thread is committed without knowing
> > the *extendable copy format* feature.
> >
> > I'd like to hear your opinions.
>
> CFBot shows that one of the test is failing as in [1]:
> [05:46:41.678] /bin/sh: 1: cannot open
> /tmp/cirrus-ci-build/contrib/pg_copy_json/sql/test_copy_format.sql: No
> such file
> [05:46:41.678] diff:
> /tmp/cirrus-ci-build/contrib/pg_copy_json/expected/test_copy_format.out:
> No such file or directory
> [05:46:41.678] diff:
> /tmp/cirrus-ci-build/contrib/pg_copy_json/results/test_copy_format.out:
> No such file or directory
> [05:46:41.678] # diff command failed with status 512: diff
> "/tmp/cirrus-ci-build/contrib/pg_copy_json/expected/test_copy_format.out"
> "/tmp/cirrus-ci-build/contrib/pg_copy_json/results/test_copy_format.out"
> > "/tmp/cirrus-ci-build/contrib/pg_copy_json/results/test_copy_format.out=
.diff"
> [05:46:41.678] Bail out!make[2]: *** [../../src/makefiles/pgxs.mk:454:
> check] Error 2
> [05:46:41.679] make[1]: *** [Makefile:96: check-pg_copy_json-recurse] Err=
or 2
> [05:46:41.679] make: *** [GNUmakefile:71: check-world-contrib-recurse] Er=
ror 2
>
> Please post an updated version for the same.

Thanks for the reminder, the patch set I posted is not for commit but
for further discussion.

I will post more information about the *extendable copy* feature
when it's about to be committed.

>
> [1] - https://cirrus-ci.com/task/5322439115145216
>
> Regards,
> Vignesh


--=20
Regards
Junwang Zhao