MIME-Version: 1.0
From: Dean Rasheed <dean.a.rasheed@gmail.com>
Date: Mon, 20 Feb 2023 18:52:16 +0000
Message-ID: <CAEZATCUg8V+K+GcafOPqymxk84Y_prXgfe64PDoopjLFH6Z0Aw@mail.gmail.com>
Subject: Missing cases from SPI_result_code_string()
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000001ff2ba05f5262ae2"
Archived-At: <https://www.postgresql.org/message-id/CAEZATCUg8V%2BK%2BGcafOPqymxk84Y_prXgfe64PDoopjLFH6Z0Aw%40mail.gmail.com>
Precedence: bulk

--0000000000001ff2ba05f5262ae2
Content-Type: text/plain; charset="UTF-8"

Another one noticed from the MERGE RETURNING patch -- the switch
statement in SPI_result_code_string() is missing cases for
SPI_OK_TD_REGISTER and SPI_OK_MERGE.

The SPI_OK_TD_REGISTER case goes back all the way, so I suppose it
should be back-patched to all supported branches, though evidently
this is not something anyone is likely to care about.

The SPI_OK_MERGE case is perhaps a little more visible (e.g., execute
MERGE from PL/Perl using $rv = spi_exec_query() and then examine
$rv->{status}). It's also missing from the docs for SPI_Execute().
Having tested that it now works as expected, I don't think there's
much point in adding a regression test case for it though.

Regards,
Dean

--0000000000001ff2ba05f5262ae2
Content-Type: text/x-patch; charset="US-ASCII"; name="SPI_result_code_string.patch"
Content-Disposition: attachment; filename="SPI_result_code_string.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_led657pt0>
X-Attachment-Id: f_led657pt0

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9zcGkuc2dtbCBiL2RvYy9zcmMvc2dtbC9zcGkuc2dt
bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCA3NTgxNjYxLi42NTE5MzBhCi0tLSBhL2RvYy9z
cmMvc2dtbC9zcGkuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvc3BpLnNnbWwKQEAgLTQzOCw2ICs0
MzgsMTUgQEAgdHlwZWRlZiBzdHJ1Y3QgU1BJVHVwbGVUYWJsZQogICAgIDwvdmFybGlzdGVudHJ5
PgogCiAgICAgPHZhcmxpc3RlbnRyeT4KKyAgICAgPHRlcm0+PHN5bWJvbD5TUElfT0tfTUVSR0U8
L3N5bWJvbD48L3Rlcm0+CisgICAgIDxsaXN0aXRlbT4KKyAgICAgIDxwYXJhPgorICAgICAgIGlm
IGEgPGNvbW1hbmQ+TUVSR0U8L2NvbW1hbmQ+IHdhcyBleGVjdXRlZAorICAgICAgPC9wYXJhPgor
ICAgICA8L2xpc3RpdGVtPgorICAgIDwvdmFybGlzdGVudHJ5PgorCisgICAgPHZhcmxpc3RlbnRy
eT4KICAgICAgPHRlcm0+PHN5bWJvbD5TUElfT0tfSU5TRVJUX1JFVFVSTklORzwvc3ltYm9sPjwv
dGVybT4KICAgICAgPGxpc3RpdGVtPgogICAgICAgPHBhcmE+CmRpZmYgLS1naXQgYS9zcmMvYmFj
a2VuZC9leGVjdXRvci9zcGkuYyBiL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL3NwaS5jCm5ldyBmaWxl
IG1vZGUgMTAwNjQ0CmluZGV4IDYxZjAzZTMuLmUzYTE3MGMKLS0tIGEvc3JjL2JhY2tlbmQvZXhl
Y3V0b3Ivc3BpLmMKKysrIGIvc3JjL2JhY2tlbmQvZXhlY3V0b3Ivc3BpLmMKQEAgLTIwMjksNiAr
MjAyOSwxMCBAQCBTUElfcmVzdWx0X2NvZGVfc3RyaW5nKGludCBjb2RlKQogCQkJcmV0dXJuICJT
UElfT0tfUkVMX1JFR0lTVEVSIjsKIAkJY2FzZSBTUElfT0tfUkVMX1VOUkVHSVNURVI6CiAJCQly
ZXR1cm4gIlNQSV9PS19SRUxfVU5SRUdJU1RFUiI7CisJCWNhc2UgU1BJX09LX1REX1JFR0lTVEVS
OgorCQkJcmV0dXJuICJTUElfT0tfVERfUkVHSVNURVIiOworCQljYXNlIFNQSV9PS19NRVJHRToK
KwkJCXJldHVybiAiU1BJX09LX01FUkdFIjsKIAl9CiAJLyogVW5yZWNvZ25pemVkIGNvZGUgLi4u
IHJldHVybiBzb21ldGhpbmcgdXNlZnVsIC4uLiAqLwogCXNwcmludGYoYnVmLCAiVW5yZWNvZ25p
emVkIFNQSSBjb2RlICVkIiwgY29kZSk7Cg==
--0000000000001ff2ba05f5262ae2--