MIME-Version: 1.0
References: <20250422181006.dd6f9d1d81299f5b2ad55e1a@sraoss.co.jp>
 <20250808122125.e9eaff938f8c83556f337e50@sraoss.co.jp>
 <20250820141028.dc06e0d1d787ce1151f69ed6@sraoss.co.jp>
 <20250902163341.c174d0e83eedfc54d68b8e9c@sraoss.co.jp>
 <20251231194455.5975fda68ed8e941e4afb805@sraoss.co.jp>
 <CAEZATCV6=q0-5HFBMg4jFS-j1ZCwANhp1sLXBQZYsK2ZLwq0AQ@mail.gmail.com>
 <20260324195727.43416b69c71b5f63eed3b4bc@sraoss.co.jp>
 <CAEZATCUR5B=6M7H2bwRU0_6FrbSE8yHe_+9bTbRUdU=jE33yog@mail.gmail.com>
 <20260325130127.7bc85919861f494ce7c332a5@sraoss.co.jp>
 <20260327000931.d2303c198c7c9445e90aeab7@sraoss.co.jp>
 <CAEZATCWkQhG0fwz5Z34vn=LcKdCb3DGfomPPwcXL_qtKfEt5+w@mail.gmail.com>
 <20260327021807.3ae563de0a288086b98755fb@sraoss.co.jp>
 <CAEZATCV5ZbGZzmqKPow9tsaVuE3vmTU4WwEq0wHrsM=QHBpUEQ@mail.gmail.com>
 <20260327143511.d84a76decfcbd6b80bdf56ed@sraoss.co.jp>
 <20260327164359.ee19c1e71c80163517a1051e@sraoss.co.jp>
 <CAEZATCXMxaMP68A9HjC0NtMtzCfVyvDiYjH-zOVLcLj5B1pFgg@mail.gmail.com>
 <20260331233517.05fbaa30b1b0b96d16b0d556@sraoss.co.jp>
In-Reply-To: <20260331233517.05fbaa30b1b0b96d16b0d556@sraoss.co.jp>
From: Dean Rasheed <dean.a.rasheed@gmail.com>
Date: Wed, 1 Apr 2026 17:12:38 +0100
Message-ID: 
 <CAEZATCVtSyr1eOmHT=8B4i=RqHHM6_vbhLJhJorU+F89MMpA-A@mail.gmail.com>
Subject: Re: Allow to collect statistics on virtual generated columns
To: Yugo Nagata <nagata@sraoss.co.jp>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAEZATCVtSyr1eOmHT%3D8B4i%3DRqHHM6_vbhLJhJorU%2BF89MMpA-A%40mail.gmail.com>
Precedence: bulk

On Tue, 31 Mar 2026 at 15:35, Yugo Nagata <nagata@sraoss.co.jp> wrote:
>
> Thank you for updating the patch. I am fine with that.
>
> One concern is that users might interpret "stored" as referring to
> "stored generated columns", rather than including regular columns,

Yeah, possibly. I changed "stored" to "non-virtual", which should
reduce the chances of that particular confusion.

> Also, the meaning of "automatically" might be a bit unclear, so we
> could clarify it by adding "without defining extended statistics."
>
>       Defining extended statistics on a single <emphasis>stored</emphasis>
>       column is not supported or necessary, because statistics are built
>       automatically on such columns without defining extended statistics.

OK, pushed that way.

I also noticed that a few places in CreateStatistics() could use the
variable "numcols" instead of "list_length(stmt->exprs)", so I changed
that.

I decided to include the change to the error message discussed in [1],
since there seemed to be a consensus there, except that I think it
also needs to make it clear that it refers only to non-virtual
columns.

In addition, there was another nearby error message which was no
longer quite right for statistics on virtual generated columns, and I
changed the order of checks, since that allowed the "if" statements to
be simplified a bit.

Regards,
Dean

[1] https://www.postgresql.org/message-id/20260324203430.411331c59ca462457ec0aa8b%40sraoss.co.jp