Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tmXEq-007RQ3-At
	for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Feb 2025 12:07:08 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tmXEo-0026RW-P9
	for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Feb 2025 12:07:06 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <dean.a.rasheed@gmail.com>)
	id 1tmXEo-0026RO-F7
	for pgsql-hackers@lists.postgresql.org; Mon, 24 Feb 2025 12:07:06 +0000
Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <dean.a.rasheed@gmail.com>)
	id 1tmXEl-000TI7-1w
	for pgsql-hackers@postgresql.org;
	Mon, 24 Feb 2025 12:07:05 +0000
Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-85595f813caso345878039f.3
        for <pgsql-hackers@postgresql.org>; Mon, 24 Feb 2025 04:07:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1740398824; x=1741003624; darn=postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=JbFjaOGwXVr6neEcHC3+9INbQUQW6oWWT8F7gl//Lxw=;
        b=KLVNMwUGpDmatB8yEaVpdni91G1xlYrCy690nE+w+LHkowtUImtkjzNicqYnn5xNzA
         eCVM+SsAOUceBSH6itgqnIzHjjAG6ePk7LLpoKJ8BstOLNXOim/raKiUuw7iDy3j31Ey
         cPDOcZBFb8FSeoysX9iafI5hCHPOjnZxeGAkEoyOScXtCTj6L9E0eomKdT35cf8L7mI0
         S3Ikx8SAZeSg1R6pRfGYaZlHgnTXG2zR3XeJRJjQi17JJ7MMDiJsijH5TN49iH0G3bqb
         1duUGZuyDPGiYptFkUiQYrOGNLGuBqEuqGCr9j9VK7kmnCOu4khb0oaVX7m3gWZHp7Ho
         9FoA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1740398824; x=1741003624;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=JbFjaOGwXVr6neEcHC3+9INbQUQW6oWWT8F7gl//Lxw=;
        b=NG20yQ1ac8EjruGkRehxTBYGpSQW+ddn1MTopo/S3eaS6U9mgUP5RWO4w5qsOxuKEt
         A2VYIDOKgmknGmurPu7CX9DU44xDSVhQrilmdzUPjS/L/aKLC3kzjSPJYg3z0/YKPuph
         lOQFqZhak9znPrvk/ErOSxivSz+FGtM6im+In3EwegmIY5D3FwLBML6ElzGBQ1dXv55v
         A3BGy0woNX1n0DX27KnroLCl0YROoJhvtvfalAyqSIVolVt2pShDOHTiSmNfBoy9+07l
         9o7EONdFKetF1GQhe3GuJKVte/P65wtyUUC0ueRly8n1gymlRGTsiFbBI/NO06TDaiiz
         TMDQ==
X-Forwarded-Encrypted: i=1; AJvYcCVnPcTtGDP18kNPLdAmhnRMBo4loPG72UazTQEtDiuURKQiz1uIjlwUNhPyz4lZ+WQszZnOcflkAbcDWpud@postgresql.org
X-Gm-Message-State: AOJu0Yzo9XPMgWusuCKvbA/ekiSrJn3n/QmwdJrXn0/h3kdRK5v66gTs
	L2tSw8T0krW1Ph3Xanp6goc6BRCxminCicOUXvyCBAyNuUlDzmtllUAtUAlWCnjg6eJVK7PrI6t
	k3GINsPKerIJf9SgVAaAa2RSwAUs=
X-Gm-Gg: ASbGnctGsp0VnA/2pqGV3lCc1UG+JOkPhszLEttNARgwqYDf0zDi/hDJFL9cxoBuYr5
	6ko7odHIzgUWep8mIbsM1lVYbKAMgFDMqip9PMEQJuVCxd+4x0bd3QDJVI6ALOT8DZihq3iBy7k
	bcEcysU527/86hFzoAJnB94tXR6kjNZOh8FkfmYLntDQ==
X-Google-Smtp-Source: AGHT+IF8Cn47+A+3hz3hiKELmB08rEkitHA+bZK588ZEAUcxqS8aJPZtFvSgi+Gw+vTZAxWRMEhnQ5eEt7cfEJ5l6a4=
X-Received: by 2002:a05:6e02:3092:b0:3d0:21aa:a756 with SMTP id
 e9e14a558f8ab-3d2cae4c215mr137771785ab.5.1740398823992; Mon, 24 Feb 2025
 04:07:03 -0800 (PST)
MIME-Version: 1.0
References: <a368248e-69e4-40be-9c07-6c3b5880b0a6@eisentraut.org>
 <831d7f99-0618-48e5-8557-f3d57137f339@eisentraut.org> <CAEZATCXnp5XTkUCsmfjLXVWZ7TaibWatnXDdu52J6zN3XsyZhw@mail.gmail.com>
 <64c2468c-3b69-44d7-863a-165931a70c1d@eisentraut.org> <b4139280-073a-4226-8bea-3ea9a3ad6e3f@eisentraut.org>
 <CAEZATCX6SHevKrVfAOq+88b4Ysm4Rqq2yeO6He3N0pttEbjYag@mail.gmail.com>
 <afb36e1f-8be9-4900-b29e-b095e30e9416@eisentraut.org> <CAEZATCVsfdp5MQpENpbrFAAfpC2tYU7y-Q=uOG57UubGy48Gyw@mail.gmail.com>
 <8be3512a-a23f-4088-a9ec-bf68650a2997@eisentraut.org> <75eb1a6f-d59f-42e6-8a78-124ee808cda7@gmail.com>
 <8d6a3d4c-f630-4cf9-aced-6cead95776e5@Spark> <CAMbWs4-h49s0ehfSq4CnztRLSwOF79ZQUkSPzGCQLNroAG7joA@mail.gmail.com>
 <CACJufxHVsCoxhqeDV973Hny3EtgCGztDJj=KKvErexnH=2k6yQ@mail.gmail.com>
 <12d5cce9-917f-4a99-86d3-715bb3b363bb@Spark> <CAMbWs4_xiGiB5Oufdn62cJ=MoiS9cJWLzq=jR_7xnTO8x_oPqg@mail.gmail.com>
 <CACJufxEWnz__Bf-KhVaiisHZd-5JcRRY_xttCKLs_m2xaUJmQA@mail.gmail.com>
 <d23c8a44-9124-4eaa-af90-e5482b3b4680@eisentraut.org> <CAEZATCUpzF0XZGVpuJ-O4WLnDWBmddSc+yMWvg6zsz_ekegfPg@mail.gmail.com>
 <CAMbWs4-JmGEBDucPw8iJ3H8hg-7TkbOqE0WTVzhJ5iyzQyP=-A@mail.gmail.com>
 <CAMbWs4_LRNGAxbQbLOrj+VMy80dUR5v2JQ9fVcre10C4KVYUDg@mail.gmail.com>
 <CAEZATCWhr=FM4X5kCPvVs-g2XEk+ceLsNtBK_zZMkqFn9vUjsw@mail.gmail.com>
 <CAEZATCWsKqCtZ=ud26-gGV3zHt-hjS4OKG43GCBhSaYUWyfKiw@mail.gmail.com>
 <CAMbWs4_Rg-F=jQ7-WfBztnVZG2i5kAUwoQv0O5GbGPzxpjDeTQ@mail.gmail.com>
 <CAEZATCV+msUomqYUc-M70epBn7WppLqiw1z=4u4yf6w4vUECiQ@mail.gmail.com>
 <CAMbWs4_DVtFfonq7eL6Ocor4apV9dBb6wOhJ5iUZPEddKc-_vg@mail.gmail.com>
 <CAMbWs4-cXOHx4D_UxsRKsnqF_EvsGj25WTW8FL2RNBhyxZh-bw@mail.gmail.com>
 <CACJufxFCqCDMaH403R8nFjvWQ3fDXyzuypaDhBVjeB+YJHEpMw@mail.gmail.com> <CAMbWs4815nLUPbs1y6FmmHCyn0b0E6MGhcB_qLfCEoFUmkCyzw@mail.gmail.com>
In-Reply-To: <CAMbWs4815nLUPbs1y6FmmHCyn0b0E6MGhcB_qLfCEoFUmkCyzw@mail.gmail.com>
From: Dean Rasheed <dean.a.rasheed@gmail.com>
Date: Mon, 24 Feb 2025 12:06:51 +0000
X-Gm-Features: AWEUYZkV0BRnUPU55yJ6SuL_ZVIjAItAENeYI8ZOUfFxPqSHuFcU8xoTioE_f2M
Message-ID: <CAEZATCW19SyP8=rOtcJWmh0-z354NMKx_ntFsruQ9GPHY+eDog@mail.gmail.com>
Subject: Re: Virtual generated columns
To: Richard Guo <guofenglinux@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, 
	Zhang Mingli <zmlpostgres@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/CAEZATCW19SyP8%3DrOtcJWmh0-z354NMKx_ntFsruQ9GPHY%2BeDog%40mail.gmail.com>
Precedence: bulk

On Mon, 24 Feb 2025 at 09:21, Richard Guo <guofenglinux@gmail.com> wrote:
>
> Here are the updated patches with revised comments and some tweaks to
> the commit messages.  I plan to push them in one or two days.
>

LGTM.

Regards,
Dean