public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dean Rasheed <[email protected]>
To: Alvaro Herrera <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Incorrect command tag row count for MERGE with a cross-partition update
Date: Wed, 22 Feb 2023 09:50:05 +0000
Message-ID: <CAEZATCWTTrGAgTfM_tNoGocnEKkYZT8dEic+Ewf_Ki76YCZ76w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAEZATCWRMG7XX2QEsVL1LswmNo2d_YG8tKTLkpD3=Lp644S7rg@mail.gmail.com>
	<[email protected]>

On Tue, 21 Feb 2023 at 09:34, Alvaro Herrera <[email protected]> wrote:
>
> > I think the best fix is to have ExecMergeMatched() pass canSetTag =
> > false to ExecUpdateAct(), so that ExecMergeMatched() takes
> > responsibility for updating estate->es_processed in all cases.
>
> Sounds sensible.
>

I decided it was also probably worth having a regression test covering
this, since it would be quite easy to break if the code is ever
refactored.

Pushed and back-patched.

Regards,
Dean

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Incorrect command tag row count for MERGE with a cross-partition update
  In-Reply-To: <CAEZATCWTTrGAgTfM_tNoGocnEKkYZT8dEic+Ewf_Ki76YCZ76w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox