MIME-Version: 1.0
References: <328e4371-9a4c-4196-9df9-1f23afc900df@eisentraut.org>
 <69b34d70-844c-4bc7-ad02-f239a6a63d56@iki.fi> <8333bca3-2d7d-4513-b44d-a168e75171e9@eisentraut.org>
In-Reply-To: <8333bca3-2d7d-4513-b44d-a168e75171e9@eisentraut.org>
From: Dean Rasheed <dean.a.rasheed@gmail.com>
Date: Tue, 20 Jan 2026 11:31:22 +0000
Message-ID: <CAEZATCX3SP0bjbkSurf6mkSJ8nGDPcv2+PfYvxNV9zdE4DCkeQ@mail.gmail.com>
Subject: Re: commented out code
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAEZATCX3SP0bjbkSurf6mkSJ8nGDPcv2%2BPfYvxNV9zdE4DCkeQ%40mail.gmail.com>
Precedence: bulk

On Tue, 20 Jan 2026 at 08:49, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On 05.12.25 17:38, Heikki Linnakangas wrote:
> > #if 0
> >      Oid      subtype = PG_GETARG_OID(3);
> > #endif
> >
> > is yet another option. It keeps the indentation, although you won't get
> > the compiler checking.
>
> After some reflection, I like this approach.  It keeps the indentation
> and enables syntax highlighting, so it makes some of these blocks much
> easier to read.

Quite a few other places use this pattern:

#ifdef NOT_USED
    Oid      subtype = PG_GETARG_OID(3);
#endif

Nothing #define's NOT_USED, so it works the same, but helps document
that the argument isn't used.

Regards,
Dean