MIME-Version: 1.0
From: Chao Li <li.evan.chao@gmail.com>
Date: Wed, 21 Jan 2026 11:55:27 +0800
Message-ID: <CAEoWx2kggo1N2kDH6OSfXHL_5gKg3DqQ0PdNuL4LH4XSTKJ3-g@mail.gmail.com>
Subject: tablecmds: reject CLUSTER ON for partitioned tables earlier
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000bd92f90648dde5c4"
Archived-At: <https://www.postgresql.org/message-id/CAEoWx2kggo1N2kDH6OSfXHL_5gKg3DqQ0PdNuL4LH4XSTKJ3-g%40mail.gmail.com>
Precedence: bulk

--000000000000bd92f90648dde5c4
Content-Type: multipart/alternative; boundary="000000000000bd92f80648dde5c2"

--000000000000bd92f80648dde5c2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Hacker,

I noticed this while working other patches related to =E2=80=9CALTER TABLE=
=E2=80=9D.

=E2=80=9CALTER TABLE =E2=80=A6 CLUSTER ON=E2=80=9D and "SET WITHOUT CLUSTER=
" are not supported for
partitioned tables, but currently ATPrepCmd() allows them through and they
only fail later at execution time.

This patch rejects these commands earlier by using the existing
ATSimplePermissions() infrastructure in ATPrepCmd(), matching the handling
of other unsupported ALTER TABLE actions on partitioned tables (such as SET
LOGGED / SET UNLOGGED). This makes the behavior more consistent and
simplifies the code path.

As a result, the error reported for partitioned tables changes:

Before the patch:
```
evantest=3D# ALTER TABLE p_test CLUSTER ON idx_p_test_id;
ERROR:  cannot mark index clustered in partitioned table
```

With the patch:
```
evantest=3D# ALTER TABLE p_test CLUSTER ON idx_p_test_id;
ERROR:  ALTER action CLUSTER ON cannot be performed on relation "p_test"
DETAIL:  This operation is not supported for partitioned tables.
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

--000000000000bd92f80648dde5c2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"auto" style=3D"line-break:after-white-space">H=
i Hacker,<div><br></div><div>I noticed this while working other patches rel=
ated to =E2=80=9CALTER TABLE=E2=80=9D.</div><div><br></div><div>=E2=80=9CAL=
TER TABLE =E2=80=A6 CLUSTER ON=E2=80=9D and &quot;SET WITHOUT CLUSTER&quot;=
 are not supported for partitioned tables, but currently ATPrepCmd() allows=
 them through and they only fail later at execution time.</div><div><br></d=
iv><div><div>This patch rejects these commands earlier by using the existin=
g ATSimplePermissions() infrastructure in ATPrepCmd(), matching the handlin=
g of other unsupported ALTER TABLE actions on partitioned tables (such as S=
ET LOGGED / SET UNLOGGED). This makes the behavior more consistent and simp=
lifies the code path.</div></div><div><br></div><div>As a result, the error=
 reported for partitioned tables changes:</div><div><br></div><div>Before t=
he patch:</div><div>```</div><div>evantest=3D#=C2=A0ALTER=C2=A0TABLE=C2=A0p=
_test CLUSTER=C2=A0ON=C2=A0idx_p_test_id;<br>ERROR:=C2=A0=C2=A0cannot=C2=A0=
mark=C2=A0index=C2=A0clustered=C2=A0in=C2=A0partitioned=C2=A0table</div><di=
v>```</div><div><br></div><div>With the patch:</div><div>```</div><div><div=
>evantest=3D# ALTER TABLE p_test CLUSTER ON idx_p_test_id;</div><div>ERROR:=
 =C2=A0ALTER action CLUSTER ON cannot be performed on relation &quot;p_test=
&quot;</div><div>DETAIL: =C2=A0This operation is not supported for partitio=
ned tables.</div></div><div>```</div><div><br></div><div>Best regards,</div=
><div><div id=3D"m_-4353349767148808562AppleMailSignature">
--<br>Chao Li (Evan)<br>HighGo Software Co., Ltd.<br><a href=3D"https://www=
.highgo.com/" target=3D"_blank">https://www.highgo.com/</a><br><br><br><br>

</div>
<br></div></div></div>

--000000000000bd92f80648dde5c2--
--000000000000bd92f90648dde5c4
Content-Type: application/octet-stream; 
	name="v1-0001-tablecmds-reject-CLUSTER-ON-for-partitioned-table.patch"
Content-Disposition: attachment; 
	filename="v1-0001-tablecmds-reject-CLUSTER-ON-for-partitioned-table.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mknhmllw0>
X-Attachment-Id: f_mknhmllw0

RnJvbSBjOTk3ZjQ4MTE5MzRlNjcxNjQxNTI5YjRhMjI5MmU0YWMzNjJlN2M4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiQ2hhbyBMaSAoRXZhbikiIDxsaWNAaGlnaGdvLmNvbT4KRGF0
ZTogV2VkLCAyMSBKYW4gMjAyNiAxMToyNzowMyArMDgwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIHRh
YmxlY21kczogcmVqZWN0IENMVVNURVIgT04gZm9yIHBhcnRpdGlvbmVkIHRhYmxlcwogZWFybGll
cgoKQUxURVIgVEFCTEUgLi4uIENMVVNURVIgT04gYW5kIFNFVCBXSVRIT1VUIENMVVNURVIgYXJl
IG5vdCBzdXBwb3J0ZWQgZm9yCnBhcnRpdGlvbmVkIHRhYmxlcyBhbmQgYWxyZWFkeSBmYWlsIHRv
ZGF5LCBidXQgb25seSBhdCBleGVjIHRpbWUuCgpSZWplY3QgdGhlc2UgY29tbWFuZHMgZWFybGll
ciB2aWEgQVRTaW1wbGVQZXJtaXNzaW9ucygpLCBtYXRjaGluZyB0aGUKaGFuZGxpbmcgb2Ygb3Ro
ZXIgdW5zdXBwb3J0ZWQgQUxURVIgVEFCTEUgYWN0aW9ucyBvbiBwYXJ0aXRpb25lZCB0YWJsZXMK
KHN1Y2ggYXMgU0VUIExPR0dFRCAvIFNFVCBVTkxPR0dFRCkuIFRoaXMgY2VudHJhbGl6ZXMgdGhl
IHJlbGF0aW9uLWtpbmQKY2hlY2sgaW4gdGhlIEFMVEVSIFRBQkxFIHByZXBhcmF0aW9uIHBoYXNl
LCBpbXByb3ZpbmcgY29uc2lzdGVuY3kgYW5kCm1haW50YWluYWJpbGl0eS4KCkFzIGEgcmVzdWx0
LCBwYXJ0aXRpb25lZCB0YWJsZXMgbm93IHJlcG9ydCB0aGUgc3RhbmRhcmQgQVRTaW1wbGVQZXJt
aXNzaW9ucygpCmVycm9yIGZvciB1bnN1cHBvcnRlZCBBTFRFUiBUQUJMRSBhY3Rpb25zLgoKQXV0
aG9yOiBDaGFvIExpIDxsaWNAaGlnaGdvLmNvbT4KLS0tCiBzcmMvYmFja2VuZC9jb21tYW5kcy90
YWJsZWNtZHMuYyAgICAgIHwgMiArLQogc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jbHVzdGVy
Lm91dCB8IDYgKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMyBkZWxl
dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYyBi
L3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jCmluZGV4IGY5NzZjMGU1YzdlLi4zZTlm
NjJlOWQzNyAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKKysr
IGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKQEAgLTUxNDIsNyArNTE0Miw3IEBA
IEFUUHJlcENtZChMaXN0ICoqd3F1ZXVlLCBSZWxhdGlvbiByZWwsIEFsdGVyVGFibGVDbWQgKmNt
ZCwKIAkJY2FzZSBBVF9DbHVzdGVyT246CQkvKiBDTFVTVEVSIE9OICovCiAJCWNhc2UgQVRfRHJv
cENsdXN0ZXI6CS8qIFNFVCBXSVRIT1VUIENMVVNURVIgKi8KIAkJCUFUU2ltcGxlUGVybWlzc2lv
bnMoY21kLT5zdWJ0eXBlLCByZWwsCi0JCQkJCQkJCUFUVF9UQUJMRSB8IEFUVF9QQVJUSVRJT05F
RF9UQUJMRSB8IEFUVF9NQVRWSUVXKTsKKwkJCQkJCQkJQVRUX1RBQkxFIHwgQVRUX01BVFZJRVcp
OwogCQkJLyogVGhlc2UgY29tbWFuZHMgbmV2ZXIgcmVjdXJzZSAqLwogCQkJLyogTm8gY29tbWFu
ZC1zcGVjaWZpYyBwcmVwIG5lZWRlZCAqLwogCQkJcGFzcyA9IEFUX1BBU1NfTUlTQzsKZGlmZiAt
LWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvY2x1c3Rlci5vdXQgYi9zcmMvdGVzdC9y
ZWdyZXNzL2V4cGVjdGVkL2NsdXN0ZXIub3V0CmluZGV4IDRkNDBhNjgwOWFiLi4wN2M1MmU2NDdm
NyAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jbHVzdGVyLm91dAorKysg
Yi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2NsdXN0ZXIub3V0CkBAIC00OTIsOSArNDkyLDEx
IEBAIE51bWJlciBvZiBwYXJ0aXRpb25zOiAzIChVc2UgXGQrIHRvIGxpc3QgdGhlbS4pCiBDTFVT
VEVSIGNsc3RycGFydDsKIEVSUk9SOiAgdGhlcmUgaXMgbm8gcHJldmlvdXNseSBjbHVzdGVyZWQg
aW5kZXggZm9yIHRhYmxlICJjbHN0cnBhcnQiCiBBTFRFUiBUQUJMRSBjbHN0cnBhcnQgU0VUIFdJ
VEhPVVQgQ0xVU1RFUjsKLUVSUk9SOiAgY2Fubm90IG1hcmsgaW5kZXggY2x1c3RlcmVkIGluIHBh
cnRpdGlvbmVkIHRhYmxlCitFUlJPUjogIEFMVEVSIGFjdGlvbiBTRVQgV0lUSE9VVCBDTFVTVEVS
IGNhbm5vdCBiZSBwZXJmb3JtZWQgb24gcmVsYXRpb24gImNsc3RycGFydCIKK0RFVEFJTDogIFRo
aXMgb3BlcmF0aW9uIGlzIG5vdCBzdXBwb3J0ZWQgZm9yIHBhcnRpdGlvbmVkIHRhYmxlcy4KIEFM
VEVSIFRBQkxFIGNsc3RycGFydCBDTFVTVEVSIE9OIGNsc3RycGFydF9pZHg7Ci1FUlJPUjogIGNh
bm5vdCBtYXJrIGluZGV4IGNsdXN0ZXJlZCBpbiBwYXJ0aXRpb25lZCB0YWJsZQorRVJST1I6ICBB
TFRFUiBhY3Rpb24gQ0xVU1RFUiBPTiBjYW5ub3QgYmUgcGVyZm9ybWVkIG9uIHJlbGF0aW9uICJj
bHN0cnBhcnQiCitERVRBSUw6ICBUaGlzIG9wZXJhdGlvbiBpcyBub3Qgc3VwcG9ydGVkIGZvciBw
YXJ0aXRpb25lZCB0YWJsZXMuCiBEUk9QIFRBQkxFIGNsc3RycGFydDsKIC0tIE93bmVyc2hpcCBv
ZiBwYXJ0aXRpb25zIGlzIGNoZWNrZWQKIENSRUFURSBUQUJMRSBwdG5vd25lcihpIGludCB1bmlx
dWUpIFBBUlRJVElPTiBCWSBMSVNUIChpKTsKLS0gCjIuMzkuNSAoQXBwbGUgR2l0LTE1NCkKCg==
--000000000000bd92f90648dde5c4--